Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, luiz.dentz@gmail.com,
        Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH 1/1] Bluetooth: ISO: Allow binding a bcast listener to 0 bises
Date:   Wed, 27 Sep 2023 10:58:35 +0300
Message-Id: <20230927075835.20125-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20230927075835.20125-1-iulia.tanasescu@nxp.com>
References: <20230927075835.20125-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?71zoEs76goKr5UJkIrB7zrJeoyL+UVnDx1a5UrFpSDpJWLooYKTXltYv5Una?=
 =?us-ascii?Q?23pJJRHAkc1uathTO4Ov5eo1dCP2XdVkUSv9f22oAynDIAhRTvo+/44tczSe?=
 =?us-ascii?Q?vY5ZaqckdxkOhJzS02pudxCRvn11ugmU1XsizSJmM1wRSceeF3Ibx7+vG6mA?=
 =?us-ascii?Q?Nt3woce0b2EW+tJlu8cNBoJJ+5PSJrcY/bPax7RGGSvabDX5mR/pZgCLXlNj?=
 =?us-ascii?Q?pJQhKDC8P+rCLUMaqb5ODva5a5DjpAD3k5lF6cXR+8+Knmwub79GSUsBnevw?=
 =?us-ascii?Q?+71v9jYHguk+QeYoPXWcjGafnpytXclncYDyiZasI8OEQ2Wz8Av8Dur39faK?=
 =?us-ascii?Q?sQa9yTtENs2xqC9RxcazOtuvu5UjrRkV0pDM4z3+82tkri6LA0gm4Q+iSm6D?=
 =?us-ascii?Q?kPoqKS/6gxjTjfEXervllAy2UFIH+k9JR89V16ZY3UScV6H6Tfck4wOEalhD?=
 =?us-ascii?Q?dskK+ntbS4HG2fbQI+TvM6xwS6boLF6p38kzFvyFmV+uwa749OR3fcGNI19E?=
 =?us-ascii?Q?jxvrr01J89D+x3ZFzgbg0JyX5WmcuPcaOjgpWOwQW8BqJnnfTuwD85Duu/Xw?=
 =?us-ascii?Q?pVUVCCexP+uyavoeC7YyrU/n3HZVC0QugK0NXEgxAJrPpEdJ/fnvwAh8rzNE?=
 =?us-ascii?Q?BbWW203/ab9OFXsXvW3HVy0qrEzEWaB4cANyT+nynCPmTn8JbyyTqATkB3Up?=
 =?us-ascii?Q?RffVVIGGpQWmQISIWoWlRtdhJ83RyVk0Wj+1PHmoRWU+kQG/SBJefBWtb2k4?=
 =?us-ascii?Q?jQhebPrcuaSAH1ImnO0Y5mH4Nz/xgQ2X6HHNPasENxVDMXUpREvt4bMNsScd?=
 =?us-ascii?Q?Ac6z0FU9/3CWmxkK4sqlXja6UK0uYLoF2iUeboD1ztKpDtyppI7LXv7wEosA?=
 =?us-ascii?Q?avwfZlqV+SCxudvzrNZWHrB552tXsB8U/qc1YpDPmXrY9h+yRak17vvfdcWs?=
 =?us-ascii?Q?krIxVwrq6PZLyDN7Exj5i29vdG0fGjHtZgmDi/Uhi2pCKJCoquQO/wDMFD+y?=
 =?us-ascii?Q?21s6PJJJB7zv8wjIyB34UkH+rDNf7LBcHpHmcEqDhQ45i/WhBwt0aBkS1i03?=
 =?us-ascii?Q?ByylOhcQphgIu7COgktzebXY+nkJvLqN6cXNwdLxuYPZNi9fmWP4NHRFT2qx?=
 =?us-ascii?Q?9xukc2iC0apBYd1qkX5B8Elc8dG3uVoMM0SOk1NXsKOCjNnErAZfx/9btrRk?=
 =?us-ascii?Q?Z+qecQcky13B/kAt+Xguth2kzxKJFsn60laAcXXBvhDsDv5eH9PvhBaToCw+?=
 =?us-ascii?Q?MnlkFeNyUmwZe9ldtA4TO04MJAldfxTMuuj/LN55aCpevKbWUzOEpZT00S+6?=
 =?us-ascii?Q?r0xfGXgSqP2x9XY0+CMWr0iCBYdCqbvEd6aHMtAgm6PqeaEXE6UVoXqIhWAC?=
 =?us-ascii?Q?xoWz5Jfjbiau+wvAVaMQB8N0WT5XROYYCtHGWsGT62psB5hMGNstvp+taVR+?=
 =?us-ascii?Q?xsm88BXZ8AqIKLrRNLstwO9YXJaATAAmCyGcPE9GuAi+wPUraeHiQH4cifwo?=
 =?us-ascii?Q?5v59i9k66sJ5lVCYs8iI8FmPzt0pq2p+ZwX5KzIVZKaAUDCMInl/xNVR//nP?=
 =?us-ascii?Q?0g0GCrABbWpL+A6eArF76xLQD655x5L9uzbrSgnZ475Es9lBQX/OxIZY4SI5?=
 =?us-ascii?Q?uQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67130bd2-6c5c-4c1d-107d-08dbbf2f9b5b
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 07:58:59.7180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pq+gvSdUxI34q6z7qe8FoDOSK3Rq4x6/FQ07EFCmTVOSXT+owRwFC4Xu4QAE1JCOTdutkcKxjq5JVM/z4mWoBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7802
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 27 Sep 2023 00:59:10 -0700 (PDT)

This makes it possible to bind a broadcast listener to a broadcaster
address without asking for any BIS indexes to sync with.

Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com>
---
 net/bluetooth/hci_conn.c | 2 +-
 net/bluetooth/iso.c      | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index e62a5f368a51..c4395d34da70 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -2138,7 +2138,7 @@ int hci_le_big_create_sync(struct hci_dev *hdev, struct hci_conn *hcon,
 	} pdu;
 	int err;
 
-	if (num_bis > sizeof(pdu.bis))
+	if (num_bis < 0x01 || num_bis > sizeof(pdu.bis))
 		return -EINVAL;
 
 	err = qos_set_big(hdev, qos);
diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
index 2132a16be93c..8ab7ea5ebedf 100644
--- a/net/bluetooth/iso.c
+++ b/net/bluetooth/iso.c
@@ -790,8 +790,7 @@ static int iso_sock_bind_bc(struct socket *sock, struct sockaddr *addr,
 	BT_DBG("sk %p bc_sid %u bc_num_bis %u", sk, sa->iso_bc->bc_sid,
 	       sa->iso_bc->bc_num_bis);
 
-	if (addr_len > sizeof(*sa) + sizeof(*sa->iso_bc) ||
-	    sa->iso_bc->bc_num_bis < 0x01 || sa->iso_bc->bc_num_bis > 0x1f)
+	if (addr_len > sizeof(*sa) + sizeof(*sa->iso_bc))
 		return -EINVAL;
 
 	bacpy(&iso_pi(sk)->dst, &sa->iso_bc->bc_bdaddr);
-- 
2.39.2