Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, luiz.dentz@gmail.com,
        Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH 1/1] Bluetooth: ISO: Fix invalid context error
Date:   Wed, 27 Sep 2023 14:37:39 +0300
Message-Id: <20230927113739.3332-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20230927113739.3332-1-iulia.tanasescu@nxp.com>
References: <20230927113739.3332-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bdX6koQVu7wAbJPZveqFr8/VCFXs74P1PWFu4cDXmmEK2lVpbghtH02HzOB0?=
 =?us-ascii?Q?O89/H1cvt6NE9ddst/bJSkxUS/P6WEwXaquJfvRsR9gekBbbMiFzJvpRNKkh?=
 =?us-ascii?Q?A95r8N5aeBjMV5wSZVSQUV91EeU3Z0VeEsK4GZfSdxreCqnVunuVG/LRTiJL?=
 =?us-ascii?Q?moZ7ZLqsq0tXWguAkf6I0waYS+y51fyOCuachZzTtc8uN9JRiEqJeuUdq6Ef?=
 =?us-ascii?Q?HV9Awb6c4Fcn/opkZLbR/1IEDbiHs9mP297pEiFh6aFZ4fL9b9UBp4gBh2uL?=
 =?us-ascii?Q?82KPzAcDv0WaQcM8s9bcahVYUXKKxElaQwBuZyo8BOdgxGY9QhPG6FbSSZWX?=
 =?us-ascii?Q?6PvWrh/nhHixo3hEksm5ITJKEnDUEPbk2WIU5ulyGakeobWTTbyc4Iouy63/?=
 =?us-ascii?Q?+zu7rHOsgwgzw+qINzbUniuR0jABcfoyHHtSGJATVhSCKh8rTKp9XIMR4OpV?=
 =?us-ascii?Q?jqOKd7IYfAJ8KVMzy7Vh9vJG+CEuS1YR+f0ix8tnYdsQ6fEHP0fIFbiHugE7?=
 =?us-ascii?Q?T0r/j+8bbrbS4xgY/p8eI0htzLGy9kP04TtaHfyZB97gENlClMeh+yUUHVuP?=
 =?us-ascii?Q?Pmxym83WId+64PsBVxsI31EMAoPM1b5DfAgHBtXTQvWylJ1OCo15OAdY5x30?=
 =?us-ascii?Q?mH/2Q2XcPJTTMVQZM9O8hBlnQEuqNoj+cUg7ixEQQjjhgm9jvb2YexMObuCs?=
 =?us-ascii?Q?svi/VKfDTVaIl9tXYKfyN2xRtKoPv1KHyY8yvocKFPdxhii9Kq4uCCNp29xG?=
 =?us-ascii?Q?fErifXdzafpgY0saIcOALr5F57U06jhlzmXgEKjLWp/XPJmQa58y7V+msJ2J?=
 =?us-ascii?Q?zwTtRDuk7IiW4v9SO9X5D6Rsv9Vfv7j+UKdgjav50Li7YoWJu2tyC0gS0M8a?=
 =?us-ascii?Q?iixvIWKkPXufjw06QMByPfrxHgK7pB1nA5ZVROt4FQ1FQ0DjketVX/++EszR?=
 =?us-ascii?Q?VA37kTCuuRHYuzWNtDLHu7VAtyfqt2JSHhqiPCn/eMhrMnoH4VEWW6rO8mRr?=
 =?us-ascii?Q?TVnW/hlQmhnsuBm0tsXIQlWRg7ADTlSrSj9txyfPu9btoojUDtsC3hq+WynT?=
 =?us-ascii?Q?DqFlsTlcxeUhjpulslX587m15TcTJeb/wRCXoNNGGSDKFV6FkXjICL5vCOx9?=
 =?us-ascii?Q?Iehchx3ujHHwCu+bJ8/yZKjQ69NZxun79saZDYvqn/X1nDJ6vASXgczkcvhB?=
 =?us-ascii?Q?ox165aKovEZ8Y4elDD3IwP+HO6cY7Rbnfj6bTxLnG4eb/K95of/ylLvKjfH5?=
 =?us-ascii?Q?0jlYJOSuLCGKltB01fcNrn4Rxw+HTdj+ZOm0GXZdW4/+vHog/qvHA7IsNQx1?=
 =?us-ascii?Q?5PaQPqumNuXO/0x9njMRos6YfS90Ty1/r36/gwtTFeFiNXBvRNxEQVLQMHQp?=
 =?us-ascii?Q?7nJ7iq0pV88oX1uOaQlQ2Ca7jIpmo5WiaUgqAuxnMztJcTwyX/JNLtuRD91z?=
 =?us-ascii?Q?pqT4g07kM8Z/XAhuHtPnyUxEVTYdosbeF8Yc1ALldC6QAIktp8Hc7gMru0B6?=
 =?us-ascii?Q?uR2PCuGIqcbAaKahVCiJQYDxZvJIoLV1eaLdh5ftCiORk1YXs5ZpvZfff6wl?=
 =?us-ascii?Q?WSlQEOZ4crnEsSZ1cJtuoYkIjURGygWoEPMEHmOrQqXXv71UQV3pFvHGS2j2?=
 =?us-ascii?Q?UA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5aaa54b-57bc-40c0-4d25-08dbbf4e3277
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2023 11:37:57.9515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AW9AU10Act0kt4E9pE3o7y6TclPcqTrK71MyXe0J+aaU/5kBhqBvlCY320lKYmx3DkEBHyX5/6CZWv7iFu2c1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7826
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 27 Sep 2023 04:38:07 -0700 (PDT)

This moves the hci_le_terminate_big_sync call from rx_work
to cmd_sync_work, to avoid calling sleeping function from
an invalid context.

Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com>
---
 net/bluetooth/hci_event.c | 31 +++++++++++++++++++++++++++----
 1 file changed, 27 insertions(+), 4 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index d242f956dea8..640921358e5f 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -7020,12 +7020,26 @@ static void hci_le_cis_req_evt(struct hci_dev *hdev, void *data,
 	hci_dev_unlock(hdev);
 }
 
+static int hci_iso_term_big_sync(struct hci_dev *hdev, void *data)
+{
+	__u8 *handle = data;
+
+	return hci_le_terminate_big_sync(hdev, *handle,
+					 HCI_ERROR_LOCAL_HOST_TERM);
+}
+
+static void hci_iso_term_big_destroy(struct hci_dev *hdev, void *data, int err)
+{
+	kfree(data);
+}
+
 static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,
 					   struct sk_buff *skb)
 {
 	struct hci_evt_le_create_big_complete *ev = data;
 	struct hci_conn *conn;
 	__u8 i = 0;
+	__u8 *big_handle;
 
 	BT_DBG("%s status 0x%2.2x", hdev->name, ev->status);
 
@@ -7064,16 +7078,25 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,
 		rcu_read_lock();
 	}
 
-	if (!ev->status && !i)
+	rcu_read_unlock();
+
+	if (!ev->status && !i) {
 		/* If no BISes have been connected for the BIG,
 		 * terminate. This is in case all bound connections
 		 * have been closed before the BIG creation
 		 * has completed.
 		 */
-		hci_le_terminate_big_sync(hdev, ev->handle,
-					  HCI_ERROR_LOCAL_HOST_TERM);
+		big_handle = kzalloc(sizeof(*big_handle), GFP_KERNEL);
+		if (!big_handle)
+			goto unlock;
 
-	rcu_read_unlock();
+		*big_handle = ev->handle;
+
+		hci_cmd_sync_queue(hdev, hci_iso_term_big_sync, big_handle,
+				   hci_iso_term_big_destroy);
+	}
+
+unlock:
 	hci_dev_unlock(hdev);
 }
 
-- 
2.39.2