Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, luiz.dentz@gmail.com,
        Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH v2 1/1] Bluetooth: ISO: Fix invalid context error
Date:   Thu, 28 Sep 2023 10:52:57 +0300
Message-Id: <20230928075257.3123-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20230928075257.3123-1-iulia.tanasescu@nxp.com>
References: <20230928075257.3123-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?aVH+GCHIhJSkyVbBXA/jqEOXpB5OsiVST9IjdM5x8uQmo9hqkotR2SL2Fw0S?=
 =?us-ascii?Q?DXxxE/SUAcmZVhtoMMenWfVQUQqkQv5UYJNiqoMKxyPck8cYBnT6REksZt0w?=
 =?us-ascii?Q?vZJwKUOuVhTdvxLVYGwOL4pO72p/Tujdl1a/1NbgNA8uTNLcKWm2I6z4vYqr?=
 =?us-ascii?Q?XnXXnYzUrE8AEHspaaIvHhF8PEFhwPLJCTExJPV/c6pWj3YywLZA+rdPIZtA?=
 =?us-ascii?Q?7R1IhPO8YvjRpcV5/BJYLDO+Ajd/zJH/rY3jVHZfCb9sYEeX62B7RmCxrqgA?=
 =?us-ascii?Q?yPoHyiHqdXyIg3XElBcT8gLDA1vb86xk7k7RVOg1z5XS6++c2utlWiTxt14E?=
 =?us-ascii?Q?NfQQSlspWi4H1EtRSJ5nGo1u8GkmZC1H1O3iiHKVGu/D2JMaeFkqoeNVIvOt?=
 =?us-ascii?Q?dN727X0GvQU1dWMXrJ4nClEez2/g+vhjR5fM3KNe+V3Uy6DrVVjwwxRmVbG/?=
 =?us-ascii?Q?qywim+qNxR5BBA1ds9ecqiIoECX0QUkC22CuvpljlOwwr6QgEm+YS/4WA+uh?=
 =?us-ascii?Q?7h4C7dILM20iDv7h0QpCti0pjmbkZWb9PPgKhAWZ6d7jWO2Mv3TaFVlVMfRb?=
 =?us-ascii?Q?YLy3rSy4ZpzJXIYR2SR38Fe8zI2fa/lxzHFkP+QgETzFtm6g6FnP7YRdsp4l?=
 =?us-ascii?Q?79VIgvzI0z33FCfSok3WqnegMUpFoJRHKsjdr7YZsLUB4yWMjVvYXQvekrZB?=
 =?us-ascii?Q?xcvoo4Ly0YbSGxyO8+5cqXyPLPW28O8518UneStSDS5xG9prHewbGrfbwOUu?=
 =?us-ascii?Q?OqBa8874bh3PwZ50XDhnIAvdBXxiLXoVDrvCSIrJagGt8vyS9fAJleEG2NEE?=
 =?us-ascii?Q?jsP8JLWhMlXoS8nMkAIVOB9N4SoVfaaXWZtQyXp1Z7iBuzWnaptcdQxaAcQn?=
 =?us-ascii?Q?8Iw3BGa9SpFO/2IJ2BZl2wcRrQ9i/2K6E+By6ftv2x5w6ltnE6evC+wYork6?=
 =?us-ascii?Q?UrsdDOLH7VxbRNm1d94Zyiwt1m6YRCrF5Kgx2jDNicSHaIkdcgFTyxSR09Of?=
 =?us-ascii?Q?PLtTjoUDiSajwukY57xazYQSZbeyCKNaFqTjeh3v8wcv0Vz0/0aDkYGcMGR0?=
 =?us-ascii?Q?E9OYOnEI4c0wze7elqSOPQCyCYRiUdRj9kQ5OGYQRVpe1c+RYTa1bmlYjtIl?=
 =?us-ascii?Q?WWmViGjxdubhsMyc0EBvwq7yce+2AIi/0MbJxNkWV/cvr+2faY5BS7GBmvTU?=
 =?us-ascii?Q?Zyda9n8vpwKwZRpJTGIpa/fgETOMzhob4qfs0EPKjUS89efp324b/PtGSVQP?=
 =?us-ascii?Q?R/28uLD6EO51YrZybUR3RyKJJVsC5ZkyqQbv2m5ciuum/CzPa//9Rp9jDaqj?=
 =?us-ascii?Q?z/YqwawoYw7y7aJU48VpJ/G/aOdWOSG+cZVC/Ml+I+KhxH5Y2ea6bvP3NOwx?=
 =?us-ascii?Q?RKN91mgjgrc5LTPWi3031R1RgXcUkequJ1lDG0Z2iE9iqaSXxad2JE8MDrPr?=
 =?us-ascii?Q?zI6LMjqEn0lO/7qlquoRxMNUccZOqaLU5HD/9DYD8Cps3YIibYN20yr2hNBJ?=
 =?us-ascii?Q?C5WmPw1wURRoZyAUHQmB7nwZqrP+nm8hgTP6x67yTNZZQfSE3HsJqA/ZEt8Z?=
 =?us-ascii?Q?6Emi6ZiPZDTE8xbaeMTYiAjUcz83EV2ypsDbxaSJadPHj64TjjAhOmG2kNMa?=
 =?us-ascii?Q?8A=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a58bf43-bde6-4522-be7f-08dbbff7f587
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 07:53:10.1296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hhl6Sr3DXRh7xgVm1rBk+HAP1MHrgxBjvl0fpYnWTK/bePtDyu04pV+0vw74B4+bGjhTXqKSmrjNmpG6onjnqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7027
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 28 Sep 2023 00:53:46 -0700 (PDT)

This moves the hci_le_terminate_big_sync call from rx_work
to cmd_sync_work, to avoid calling sleeping function from
an invalid context.

Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com>
---
 net/bluetooth/hci_event.c | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index d242f956dea8..89ba3e5a9c0e 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -7020,6 +7020,14 @@ static void hci_le_cis_req_evt(struct hci_dev *hdev, void *data,
 	hci_dev_unlock(hdev);
 }
 
+static int hci_iso_term_big_sync(struct hci_dev *hdev, void *data)
+{
+	u8 handle = PTR_UINT(data);
+
+	return hci_le_terminate_big_sync(hdev, handle,
+					 HCI_ERROR_LOCAL_HOST_TERM);
+}
+
 static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,
 					   struct sk_buff *skb)
 {
@@ -7064,16 +7072,17 @@ static void hci_le_create_big_complete_evt(struct hci_dev *hdev, void *data,
 		rcu_read_lock();
 	}
 
+	rcu_read_unlock();
+
 	if (!ev->status && !i)
 		/* If no BISes have been connected for the BIG,
 		 * terminate. This is in case all bound connections
 		 * have been closed before the BIG creation
 		 * has completed.
 		 */
-		hci_le_terminate_big_sync(hdev, ev->handle,
-					  HCI_ERROR_LOCAL_HOST_TERM);
+		hci_cmd_sync_queue(hdev, hci_iso_term_big_sync,
+				   UINT_PTR(ev->handle), NULL);
 
-	rcu_read_unlock();
 	hci_dev_unlock(hdev);
 }
 
-- 
2.39.2