Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   Vlad Pruteanu <vlad.pruteanu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, iulia.tanasescu@nxp.com,
        andrei.istodorescu@nxp.com, luiz.dentz@gmail.com,
        Vlad Pruteanu <vlad.pruteanu@nxp.com>
Subject: [PATCH BlueZ 1/1] client/player: Allow the user to control BIG encryption
Date:   Mon,  2 Oct 2023 15:37:38 +0300
Message-Id: <20231002123738.22210-2-vlad.pruteanu@nxp.com>
In-Reply-To: <20231002123738.22210-1-vlad.pruteanu@nxp.com>
References: <20231002123738.22210-1-vlad.pruteanu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PSzJQEaTcPhDun07htHQZDFPAXAATTpT6dnineVahMI1jlAy6a1f2emn7c9n?=
 =?us-ascii?Q?x7FXw0KD3YoJD0F+O7nBNNtlBYe9WgDjW04GnErV20zvppNDqHFooktfL/qM?=
 =?us-ascii?Q?AF3+MbRa5DuvBXwDsHNaxUIwnG5/Dq7jhrwuW60EKBs6q6H1JNnibgTsLFMe?=
 =?us-ascii?Q?ugMr/VyaPj5HgmiPh5X8/3Oy47e8ylAXVlqYUovZdcUfI0bVmHpV9vdLP7SE?=
 =?us-ascii?Q?wuVnKcuTWs5T6gniDNX0zJl9asuf8+3XCS6pRhADtuFUm5N/g1IRUDe43Bio?=
 =?us-ascii?Q?g8I3jkNBmpV4f3HcmzqLInuaFqsOuLz05U8fhN6CwHWe5A/qVeJLtihPWd6c?=
 =?us-ascii?Q?iM0OSOorywZzxODt+AiAOi6+XMfg8KoyyiFCH6vyZQLQCUmD4KulXntO7fSv?=
 =?us-ascii?Q?0jAV515tZYM+PANAVp3/cTxWlAm5SnhEB4DA7N5/W5FutM0Fb10UopgEfh47?=
 =?us-ascii?Q?1o9Mr8ZsJ4VsYDD8vVJmpPaEGO/c7ghvRnbFQCjViXyY6IfkGrSVeo9FfMQX?=
 =?us-ascii?Q?0bzKsgkvftz3qYVcgOWYUU4UaLgC7vtYK758YLJ0FcFFImVtyuH80PP99B00?=
 =?us-ascii?Q?cu6PsmT5kjBmkP7qZeqDLL4TrecITGsjog7dAFPD7HY5Td511ODAEl6Wp3OE?=
 =?us-ascii?Q?94RfEAbKk/i8/gl+dlITEOtYJHZLg6BQgxr4jt38i5tXKS2Jgsqw1q9kH3UL?=
 =?us-ascii?Q?NWf0MFXt6R2cR2Wx5ZRReuK9zTjQdqMQT9ZQdvIxJpbUE0ofKB6tu/qNBIo+?=
 =?us-ascii?Q?/Wlixrf6MFQNlNjBreOPcG97FymcRAW841xEkfC9fzhNFapSOy+rBD+s+EL8?=
 =?us-ascii?Q?qyAPCtztKPjspfbe8M5rve4xoPxg/bdJz16yARkSucjhaQ7PLGuW8i25+VQS?=
 =?us-ascii?Q?dgBx2w2U+msZurgUO3lmH5y7R/XoniX7oSIIXpt8TgB9ZVc5hHJO52pyYp1D?=
 =?us-ascii?Q?ftOSiSBxKBCjNVzyJ57bV84dWkDz6BJIxNzcRstkNXM8KcFSOUTWGQDCoUIh?=
 =?us-ascii?Q?uCm8rP+bRH4blSuYg/mgNfOSaiGpm0B7S25SZ3izpvP35RZbXDBPvwurmsa1?=
 =?us-ascii?Q?kiKLtbY3L1WbFqA8po9ItJltChErzsSggaPTJruXX7VZEaQZBFcXsOyTdAel?=
 =?us-ascii?Q?oOOYdpQQZdXlwX2hMe1rumJl2xMlwG4Mt2nlbMcnwwlST/x0xq7bqE+BCyr/?=
 =?us-ascii?Q?qtPAGCV+SToKnOqFrXO/Sggka6xUxQlcoTTlAdCuiIQbnwzVRCiwWWXVdikk?=
 =?us-ascii?Q?mIlV9Q3u/GAvpm9ZLUGvEpC4ymImuFv3qlv484dRrHoKZ+JaGLLk2FLXI7H0?=
 =?us-ascii?Q?isG2QaluhamCp04309swPqqCYGzmfqWYo/bAFUfkHCZHRIxjT85R8O0KraDb?=
 =?us-ascii?Q?708bkcQ+GzYL0dMP9nC3heqOzWnXKtJuU9y0DYJExggQ4pOYgYwB+dDAvi0X?=
 =?us-ascii?Q?5U3GSBDmNazqiOiwd2DspL1W2Sxb0Mv6jAsih7dtalxVAT6MUBcqF3KtFY8p?=
 =?us-ascii?Q?bkw5YfG0Ajwy6SjVpZ0ZkeAeDdwOC9YQwEAzAeWW38vQP4uNi9kFzu8o4ORQ?=
 =?us-ascii?Q?6XlrJgg9Oirk2KFKDX05IjqkYxjwxMVEeEIr6ROg?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46ac2106-19ca-4152-f198-08dbc344658f
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9398.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 12:37:53.3585
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EQXocZv0VtatS+FT12Uxqec3tJjv64sNIBy4r+6VIxzFyvG7V+G0UJCusIoWpp5JJeaHR/BTQWVQvpudg++2xg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7471
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 02 Oct 2023 05:37:59 -0700 (PDT)

This commit adds support for controling the use of encryption and
setting the broadcast code. This is done as part of the endpoint.config
command. For source endpoints the encryption flag and broadcast code can
be set, while the sink supports only broadcast code setting. If no custom
broadcast code is provided, the default one will be used.
---
 client/player.c | 50 ++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 43 insertions(+), 7 deletions(-)

diff --git a/client/player.c b/client/player.c
index d1809f24f..3a9313bfd 100644
--- a/client/player.c
+++ b/client/player.c
@@ -2792,10 +2792,10 @@ static void cmd_config_endpoint(int argc, char *argv[])
 	const struct capabilities *cap;
 	char *uuid;
 	uint8_t codec_id;
-	bool broadcast = false;
+	bool local_ep_not_provided = false;
+	uint8_t bcode_arg_position = 0;
 
 	cfg = new0(struct endpoint_config, 1);
-
 	/* Search for the remote endpoint name on DBUS */
 	cfg->proxy = g_dbus_proxy_lookup(endpoints, NULL, argv[1],
 						BLUEZ_MEDIA_ENDPOINT_INTERFACE);
@@ -2815,7 +2815,7 @@ static void cmd_config_endpoint(int argc, char *argv[])
 		codec_id = strtol(argv[3], NULL, 0);
 		cap = find_capabilities(uuid, codec_id);
 		if (cap) {
-			broadcast = true;
+			local_ep_not_provided = true;
 			cfg->ep = endpoint_new(cap);
 			cfg->ep->preset = find_presets_name(uuid, argv[3]);
 			if (!cfg->ep->preset)
@@ -2827,9 +2827,10 @@ static void cmd_config_endpoint(int argc, char *argv[])
 		}
 	}
 
-	if (((broadcast == false) && (argc > 3)) ||
-		((broadcast == true) && (argc > 4))) {
-		char *preset_name = (broadcast == false)?argv[3]:argv[4];
+	if (((local_ep_not_provided == false) && (argc > 3)) ||
+		((local_ep_not_provided == true) && (argc > 4))) {
+		uint8_t offset = (local_ep_not_provided == false)?0:1;
+		char *preset_name = argv[3 + offset];
 
 		preset = preset_find_name(cfg->ep->preset, preset_name);
 		if (!preset) {
@@ -2837,7 +2838,42 @@ static void cmd_config_endpoint(int argc, char *argv[])
 			goto fail;
 		}
 
+		/* If the endpoint is configured to be a source allow
+		 *the user to decide if encryption is enabled or not.
+		 */
+		if (!strcmp(cfg->ep->uuid, BCAA_SERVICE_UUID) &&
+			argc > 4 + offset) {
+			uint8_t value = strtol(argv[4 + offset],
+							NULL, 0);
+
+			if (value < 2)
+				bcast_qos.bcast.encryption = value;
+			else
+				goto fail;
+		}
+
+		/* If the endpoint is configured to be a source or a
+		 *sink allow the user to set a custom broadcast code.
+		 *If no broadcast code is set, the default will be used.
+		 */
+		if (!strcmp(cfg->ep->uuid, BCAA_SERVICE_UUID) &&
+			(argc > 5 + offset))
+			bcode_arg_position = 5 + offset;
+
+		/*The broadcast code is found at a smaller index due to the sink
+		 *config not using the encryption flag parameter.
+		 */
+		if (!strcmp(cfg->ep->uuid, BAA_SERVICE_UUID) &&
+			argc > 4 + offset)
+			bcode_arg_position = 4  + offset;
+
+		if (bcode_arg_position != 0)
+			for (uint8_t i = 0; i < 16; i++)
+				bcast_qos.bcast.bcode[i] =
+				strtol(argv[bcode_arg_position + i], NULL, 16);
+
 		if (cfg->ep->broadcast) {
+
 			iov_append(&cfg->ep->bcode, bcast_qos.bcast.bcode,
 				sizeof(bcast_qos.bcast.bcode));
 			/* Copy capabilities for broadcast*/
@@ -3253,7 +3289,7 @@ static const struct bt_shell_menu endpoint_menu = {
 						"Register Endpoint",
 						local_endpoint_generator },
 	{ "config",
-		"<endpoint> [local endpoint/UUID] [preset/codec id] [preset]",
+		"<endpoint> [local endpoint/UUID] [preset/codec id] [preset] [encryption] [broadcast code=xx xx ...]",
 						cmd_config_endpoint,
 						"Configure Endpoint",
 						endpoint_generator },
-- 
2.34.1