Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, luiz.dentz@gmail.com
Subject: [PATCH v2 2/3] transport: Update transport release flow for bcast src
Date:   Mon,  2 Oct 2023 18:33:51 +0300
Message-Id: <20231002153352.3163-3-iulia.tanasescu@nxp.com>
In-Reply-To: <20231002153352.3163-1-iulia.tanasescu@nxp.com>
References: <20231002153352.3163-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zZ/8oSsEQCRZROfuglCizXHnEZSNNiTxMlCSHA6J9SkUCOcHp/FI3x/XG/rp?=
 =?us-ascii?Q?OrJ2VKCGuBauUVQODr6R+ErAl2NeWgED4Mw047y+JAE564WFUtrXI3wfnjus?=
 =?us-ascii?Q?dYvO7anyKzXpiq17X1Jyt20NxgXJwN8GJ6I3LCMhl3zIH5CmQUgEYRGqE62A?=
 =?us-ascii?Q?HYC+WI8j1w5f9jKP0bIwFrhKvpkMx9yuB7gsS4gOFEYDaZueUMQPrQq9nvHn?=
 =?us-ascii?Q?7S7lXfrratwQ37j5XC2gU0tXI1NQDA1Z6lZJE3jmTt64A/C2d/ZA+TOWh7+h?=
 =?us-ascii?Q?av3SyLkNpUa7R9ENguRpjO5G0KrgVUdbdaDoSRxQLFiGqw93L0R0ojDgNAcl?=
 =?us-ascii?Q?zRT5ztw2Xg0DEa2X5xXgMtGnLnBtxvEPmJMfj2V0kr+9kv7ISHOQfO7xk76b?=
 =?us-ascii?Q?vqJ2skWXaEsINRs6UBacT8jUfR42w+8wLgpqOG4WlxHB4BC1CL3F9UhuHKyP?=
 =?us-ascii?Q?SUPdiXF6nVoy9AeCGrtHE8L7e+NeYXzL5R+TzHWzbYDrbWyuOg6st0pNHYpC?=
 =?us-ascii?Q?gWys68R/JC4R+sxiOIZ1hYGw0M2YiRgs136yrmlXCC8T/sUFheAbhGHWWOA9?=
 =?us-ascii?Q?87PswKDR5y+SbICFSdU82MQXltYGLuBv/ch+Jpl0yjL5XJwcinslVKvL/NA8?=
 =?us-ascii?Q?fuwiTFpzcb+S2aUN+sZ95QeDYwxUUGGyWwyKvE2tuIixu/W5OUyjWaHKf4Kf?=
 =?us-ascii?Q?WmWa1hpPAJ6hldnvdvVd0Y2IvJJ/sUplAAvNbbXUGRCRNY+Jm/FOU9tqsiWG?=
 =?us-ascii?Q?+41OHVIfWkDYn3PRhCKJujGg0VeWU9lqvt9z8bO3FYd/KMRR5b7nO8EtkW1U?=
 =?us-ascii?Q?8cKdrt7RQ4FVm1KeC2d/apGqFF1IZFmDuV7+0V8BA5bSmyE5gYx0mtiq4fA1?=
 =?us-ascii?Q?XVct546RAsjh0dlzF5C8d4R366tcaPJGjwmZx8+nDQn0vNqHa4B6eMH0BkyE?=
 =?us-ascii?Q?wm3y6rXzwMbMSw3QbrYRLAtfcbv1qpxDqMDObyP6/RhpzuPd3aLM6ow2BKvq?=
 =?us-ascii?Q?tZVrJmozTwudtfMkHikMV2rc9u52Bi1EyqadPObYDJzZAoyeH9Aa2tz59xb5?=
 =?us-ascii?Q?mz/CRG3b6D5gWpgz1QiBqREU5Ic3MZvPvjCRW32c9Xwu48zIycktkJ9FTPs+?=
 =?us-ascii?Q?DyDXMl3dyWARfQKEaE9xe5ASO8ABtaEl7HUlX3SVSzjB0ujdcIW1+dfv4NOf?=
 =?us-ascii?Q?pEhngKL7ML0d+ntRUzSIn/KZVv9qwoMU5MrUmSU0frNer8eUSTF7Ei3+QdSx?=
 =?us-ascii?Q?/1s928tdAaCgHZ1sBoAFfcsnKfPzO2cBZhHAJ0D1Dd29XgdqP+igFjDdBJoX?=
 =?us-ascii?Q?QdHZuqJtJY6byN5bN4k0PZsQQJ1tjM78bWtLVNkabOS1NzaGGeKHtxnJiK06?=
 =?us-ascii?Q?ApT+aS/s7CoRplfRIz75eNKP8YSPKjH534WeM5F8FMxIqIl67mY8xbS6gUSu?=
 =?us-ascii?Q?1U+bVS72nwztl6feAEMkVFedT4imZe/SzFGzqfj3qxRRbMweSN7HxyrxRWIX?=
 =?us-ascii?Q?uHN3xONg0bN2O6g231wttF+voDyollnMS9hqSbrWCZaDvzu1DT2pU8w1Vban?=
 =?us-ascii?Q?4wpS7bpCrh2H3nTl4yeHMZkDuGVgkhHvrjwqiYkbs18S35MZZyN82vHPuYX4?=
 =?us-ascii?Q?AA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 74715c15-3f7d-4944-6fb6-08dbc35d026e
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2023 15:34:04.4961
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PKZcdCEDZAH2f2l/EDOm0zO2rfOcEwvt3/wVXlJWEAhXdQBBvA18TTMPXiDU1g2Sy52ZKpZ0VV2YgPiW77Dv+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8839
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 02 Oct 2023 08:34:11 -0700 (PDT)

From: Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>

Update transport release flow for broadcast source

---
 profiles/audio/transport.c | 63 ++++++++++++++++++++++----------------
 1 file changed, 36 insertions(+), 27 deletions(-)

diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
index 1e03b7b51..646061358 100644
--- a/profiles/audio/transport.c
+++ b/profiles/audio/transport.c
@@ -606,11 +606,38 @@ static DBusMessage *try_acquire(DBusConnection *conn, DBusMessage *msg,
 	return NULL;
 }
 
+static void bap_stop_complete(struct bt_bap_stream *stream,
+					uint8_t code, uint8_t reason,
+					void *user_data)
+{
+	struct media_owner *owner = user_data;
+	struct media_request *req = owner->pending;
+	struct media_transport *transport = owner->transport;
+
+	/* Release always succeeds */
+	if (req) {
+		req->id = 0;
+		media_request_reply(req, 0);
+		media_owner_remove(owner);
+	}
+
+	transport_set_state(transport, TRANSPORT_STATE_IDLE);
+	media_transport_remove_owner(transport);
+}
+
+static void bap_disable_complete(struct bt_bap_stream *stream,
+					uint8_t code, uint8_t reason,
+					void *user_data)
+{
+	bap_stop_complete(stream, code, reason, user_data);
+}
+
 static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 					void *data)
 {
 	struct media_transport *transport = data;
 	struct media_owner *owner = transport->owner;
+	struct bap_transport *bap = transport->data;
 	const char *sender;
 	struct media_request *req;
 	guint id;
@@ -642,6 +669,11 @@ static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 	req = media_request_create(msg, id);
 	media_owner_add(owner, req);
 
+	if (bt_bap_stream_get_type(bap->stream) ==
+			BT_BAP_STREAM_TYPE_BCAST) {
+		bap_disable_complete(bap->stream, 0x00, 0x00, owner);
+	}
+
 	return NULL;
 }
 
@@ -1370,32 +1402,6 @@ static guint resume_bap(struct media_transport *transport,
 	return id;
 }
 
-static void bap_stop_complete(struct bt_bap_stream *stream,
-					uint8_t code, uint8_t reason,
-					void *user_data)
-{
-	struct media_owner *owner = user_data;
-	struct media_request *req = owner->pending;
-	struct media_transport *transport = owner->transport;
-
-	/* Release always succeeds */
-	if (req) {
-		req->id = 0;
-		media_request_reply(req, 0);
-		media_owner_remove(owner);
-	}
-
-	transport_set_state(transport, TRANSPORT_STATE_IDLE);
-	media_transport_remove_owner(transport);
-}
-
-static void bap_disable_complete(struct bt_bap_stream *stream,
-					uint8_t code, uint8_t reason,
-					void *user_data)
-{
-	bap_stop_complete(stream, code, reason, user_data);
-}
-
 static guint suspend_bap(struct media_transport *transport,
 				struct media_owner *owner)
 {
@@ -1499,9 +1505,12 @@ static void bap_state_changed(struct bt_bap_stream *stream, uint8_t old_state,
 			return;
 		break;
 	case BT_BAP_STREAM_STATE_STREAMING:
-		if (bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SOURCE)
 			bap_update_bcast_qos(transport);
 		break;
+	case BT_BAP_STREAM_STATE_RELEASING:
+		if (bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SINK)
+			return;
+		break;
 	}
 
 	io = bt_bap_stream_get_io(stream);
-- 
2.39.2