Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, luiz.dentz@gmail.com,
        Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH 1/1] Bluetooth: ISO: Allow binding a bcast listener to 0 bises
Date:   Tue,  3 Oct 2023 17:49:33 +0300
Message-Id: <20231003144933.3462-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20231003144933.3462-1-iulia.tanasescu@nxp.com>
References: <20231003144933.3462-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?m0Y2ppBT0NY+t+H93jmHqV9vGYgqx7IxPvsFdw1zYX2t7594jEgKqQ+A6iY9?=
 =?us-ascii?Q?a9WEv6SkikuHDLJMzTFJaadQh3t8GZA3vhW4fXYU4LedEYcoToTPc8IyI+i0?=
 =?us-ascii?Q?luyUySBqC5q7SnYDxd5tWymrjI5NA50LDJ2MrbcjSfNT50hRBxyTi5LpBf7R?=
 =?us-ascii?Q?Ty0MHV1p3egdIr8g1YEOlCDlYWU3JvwA9pP6gHDfHdtCZn/ycWXQuDi2X8R7?=
 =?us-ascii?Q?D8Fq1QZXbGlD2WIkXdvhBF9lTbntDe6FuRgW3Z3EASqiw3Dr6bUqKeVuKZ8O?=
 =?us-ascii?Q?XBCXwZhyZi0Gn/DFb3UZ31vJ9VqFRJayoJUNi/bnstWLWRH5wbKt7F0weGXx?=
 =?us-ascii?Q?m52bJouob/z9t8tDZcDObPn+SgZZOGZ9WBmgNgbmkIK5W7/cZlxBkK8MVgb9?=
 =?us-ascii?Q?wKWJwqfaU9SnogYpRhF2eLGVIw9us+knFraiZeJP1a8f7+00z5NcDNJn/dlK?=
 =?us-ascii?Q?Q8lQfDaVz1/4OGzim4yGV6v6YEw2Su/9YwydepAF+I8mAOzoMsVPyWZXLJBN?=
 =?us-ascii?Q?ksSSCP+PlC2UrC9y1glE7Mn05IV2ML/pD2Ybz2rfWewECu1N+O/szaj1nGa3?=
 =?us-ascii?Q?oqreO+n8YCQ4WFV0m0Oa13TRd5In7PRKJBKOwVj8VwksfnzjvAYe1l7MYZqn?=
 =?us-ascii?Q?FPfINHcrLii2hBrg/YbmPErHxd/von+gdLUc23LcQt6NtHaOGnGAL43I3kBU?=
 =?us-ascii?Q?AVCaYhkGzMlsi6+KCM6BGHhxej5vRDq8F11zl5WiSvk+UNMoCXcNcYWfX2hT?=
 =?us-ascii?Q?HNRse+foDghOcmMQXTIurs4ADzfF69vfn1ceFc/zTZUoioFtNoVGHsY4Dwem?=
 =?us-ascii?Q?Gsoi010yVJv0xS2Uf+/oioliKEV5EKhtGiWR1T0hehxWvWCuYFHyn3Y72tuz?=
 =?us-ascii?Q?rm7Ye1V4i3PF9vk2bA757vh8ZRPA1yOjmbIfSjhez2400e3SsceWSaRhN3D9?=
 =?us-ascii?Q?hzruqrX1+YmqqUKVKpLBh7v2QKrPvIrzkPP9137GtwhVbKHDwUvArA8JurzH?=
 =?us-ascii?Q?J7SzqTNEF/abTbUjeI6Ju+a8qt9w2DQNV0M1LwV8iCG6vXUSzqbEZ0kHREfH?=
 =?us-ascii?Q?iOIbrFWt64C0uL0cT9VF7eBxKswiIL9HZlz/8RA/ama4lr6/vpOcvsVuv9Vw?=
 =?us-ascii?Q?YIancqpKu0ZEg+1usUVeCUCs6qS6HHrUb+TJUZ3+pog5ucN/nkSgsMylC2d4?=
 =?us-ascii?Q?h/zwE8n+r22PTv7QGI3HOIH/H5jGuh7oQHCnsmpSfro1lwaDGTIr8L1LgThm?=
 =?us-ascii?Q?okVFDi8v0yBpdBdUUzZQOTNYBib/bN08okhGgryVgvxIB4HWGqsgbowjfwVk?=
 =?us-ascii?Q?vRrPmZEbO7R37pYw+9SbdBuQLPQ/FbqbI6o+FF5exQZgTGFnw+n0VXK/23tA?=
 =?us-ascii?Q?A31PshlUj3yLwRa4jZ+ttNO2Rb7QxSHgG802pVyBsyYyCE+CEcid/UEtKin6?=
 =?us-ascii?Q?MowT5d5WiZnZXb7ezZFosRbggcIqvrF16ioSaUB9Db9vH8oqGOKNTN0GzDQT?=
 =?us-ascii?Q?HMbgb9Mz9heWasIb0xNoB8Bfs4BrvtwhnK8qhzcSuKDmc0SLYAPO1p6FXqGn?=
 =?us-ascii?Q?PahCfRaX5mxV7d7JfC4TkHOXWnLTvNfKGyX2mvkEhbEyAYzrtAnTpqp1nD9f?=
 =?us-ascii?Q?9g=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f7252661-984e-4239-591b-08dbc41ffab5
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 14:49:43.3142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gn3ut3JEokKBzxVYkZORce7x6mQh5KSUCAZbtjefBReafGa4usr44dSqnzWy2hArVlL1HT7jSnw6S74CaJsCnQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7104
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 07:49:48 -0700 (PDT)

This makes it possible to bind a broadcast listener to a broadcaster
address without asking for any BIS indexes to sync with.

Signed-off-by: Iulia Tanasescu <iulia.tanasescu@nxp.com>
---
 net/bluetooth/hci_conn.c | 2 +-
 net/bluetooth/iso.c      | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index e62a5f368a51..c4395d34da70 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -2138,7 +2138,7 @@ int hci_le_big_create_sync(struct hci_dev *hdev, struct hci_conn *hcon,
 	} pdu;
 	int err;
 
-	if (num_bis > sizeof(pdu.bis))
+	if (num_bis < 0x01 || num_bis > sizeof(pdu.bis))
 		return -EINVAL;
 
 	err = qos_set_big(hdev, qos);
diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
index 2132a16be93c..8ab7ea5ebedf 100644
--- a/net/bluetooth/iso.c
+++ b/net/bluetooth/iso.c
@@ -790,8 +790,7 @@ static int iso_sock_bind_bc(struct socket *sock, struct sockaddr *addr,
 	BT_DBG("sk %p bc_sid %u bc_num_bis %u", sk, sa->iso_bc->bc_sid,
 	       sa->iso_bc->bc_num_bis);
 
-	if (addr_len > sizeof(*sa) + sizeof(*sa->iso_bc) ||
-	    sa->iso_bc->bc_num_bis < 0x01 || sa->iso_bc->bc_num_bis > 0x1f)
+	if (addr_len > sizeof(*sa) + sizeof(*sa->iso_bc))
 		return -EINVAL;
 
 	bacpy(&iso_pi(sk)->dst, &sa->iso_bc->bc_bdaddr);
-- 
2.39.2