Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, luiz.dentz@gmail.com,
        Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 1/1] iso-tester: Test bcast receiver with PA sync, no BIS
Date:   Tue,  3 Oct 2023 17:57:54 +0300
Message-Id: <20231003145754.3667-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20231003145754.3667-1-iulia.tanasescu@nxp.com>
References: <20231003145754.3667-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Uu2FrpsiTcZP8Eep7GPfos83CVXeaTcHJ9GIFMBFnwUqYHOzBoABpW4GhsL/?=
 =?us-ascii?Q?kWjLlklJ4k2b7+z9freULH1cTS5g2ncIqXkXB/y5V2P3TfzH/0v7aFeStYpm?=
 =?us-ascii?Q?0qae+qesuyE71ARCx2FXZGxCMZ65i9woGhjstu5oLZxJ+r/w0g54+OsWZxpz?=
 =?us-ascii?Q?gz4/0A0+bvRbqebExNG0cHwKIrWFqImpqa1EPHfsu2ilz6z307yOCnFZ9sH8?=
 =?us-ascii?Q?yS/22pyNi0MiqEHey+NPIhm2Y5bq53uEFwkJx5iPDsAHDy4EEk9buUuKO2h9?=
 =?us-ascii?Q?+EKRult5ZxPEa4zeqTdWNlHs/z+KRswVAIQyOws6F3h6cmV7jIJlUftGwpHz?=
 =?us-ascii?Q?mPe3ehVoqDa73qY29L7KB3jnEZbCl4SzTgqjygk0Z2051OzYULB2XWe4pYoH?=
 =?us-ascii?Q?mOe5pdRmk/ne4hudok2vqi1cjUjYmEzb+1uVgr7xmnU1/w+QrmJLwW8r1u8t?=
 =?us-ascii?Q?EuIC/DqH1BbVcLIuBfN7te82m10mkk80vzsJLhV08Im4reISh69lFpwoRfHM?=
 =?us-ascii?Q?8SYrrP+17MDu+Cxyi3Y4MzgL9LsVsQpLIS/YKWGvOFIry7BsqOGDbSXd263v?=
 =?us-ascii?Q?GtYkj/voNycoaNf0IjEn/bd2bE1TFDzLH41RL1GG6lsC1gY6pAN4XJPvml7A?=
 =?us-ascii?Q?ZKpl92rw4let8MysR9EITTHKBjL4RTo1S+IEoDyiIQOuDO7TGcVLw6H30gQ0?=
 =?us-ascii?Q?pofYRVuQzor1SkP6tiLgeHEMN/LXw7dqXPny5jO9ASKBT52ecL8/it1XAzyd?=
 =?us-ascii?Q?utMbaXbGl3nRQ8+H+BxSDcA0LGBophxKwbshUpWY+9BK+LDiK4VOd/k0xq2/?=
 =?us-ascii?Q?pv9pasm9Xl5d3NMstE8Hvci+f2ki7jls3voGlHMiJZHyhJUuJSqFlyvsG/+a?=
 =?us-ascii?Q?iGYqdaNLcNvPGSZoPGYahPjiKL0qHOTyOGBsLyp8vMg1jWOqnpjHdT7E9OdA?=
 =?us-ascii?Q?V5sibQzFjYJWSbDq0JWeBuhG7c+6oj0Se44DSUvNGvy3JGRMseUUSxTXof7J?=
 =?us-ascii?Q?2eQ8x2f4XMtyvU9DCzwkvFsw7s97K1m8+lvRk+wNaUMM8nl8ZIO2+HbeeMFc?=
 =?us-ascii?Q?oaBTrFaEJES4GxSQm8MewQIBoTlJ14x3q8SK76nK2tGcazRKIvs/jedB4FNH?=
 =?us-ascii?Q?6KQo1RPCe/f0+TroSkfAcBr2KheVnoLVOoxQlDQ0DNvRZ9CLAHJv2xomMnlz?=
 =?us-ascii?Q?R/hxQDvrRMet+2fsai+FTRDlxAdZBeN73/PxGQtoi7/Rf5Jl94e7jYrfIHdk?=
 =?us-ascii?Q?UBpYQXbjXyeDuJ15WXlhC9iE47Awlistuf4bu1SH/K8J8P/Ld3UtrDhha3E4?=
 =?us-ascii?Q?GSnXZmloHd4ZSH3IZfscfXphU8vOfZB24WkWEea0SWRwZ9/Iw6U8uzneEycZ?=
 =?us-ascii?Q?h7JBSVIVTHdlWFZ8oywc5fTPlOWe+y/DG4fXB7CUmleNpRqUykMfJUGnjAYZ?=
 =?us-ascii?Q?klwdn8yKIPJbRpl+efoQ4AWu00rH3FXcxMpQMQ/nLBvAHTsW/BVVSqWqCe59?=
 =?us-ascii?Q?LnxQpNsssTDSonUs9ZLPd/RsUjb/MOAvFdCADA++9u+ALQas7ZPFy5IekTiR?=
 =?us-ascii?Q?Ig6oVGmqrYNM25uCQQ83L4UuqjeoOVDQ1fjqXp30i+yfeGE9lG1AE7E7TVci?=
 =?us-ascii?Q?bg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 511c1018-dbfd-4e24-4945-08dbc4212419
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 14:58:02.4604
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4OiytoJprO8TJhEJlit4GsI9hWZaAjnvQSktfkLJWEt2sJhe+iXEhq40ldQWoAVfTz7BWiplHu+yzlcZY1ym1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7824
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 03 Oct 2023 07:58:11 -0700 (PDT)

This tests that a broadcast receiver is able to successfully sync to the
PA transmitted by a source, without performing BIS sync also:

ISO Broadcaster Receiver Defer No BIS - Success

---
 tools/iso-tester.c | 41 +++++++++++++++++++++++++++++++++++------
 1 file changed, 35 insertions(+), 6 deletions(-)

diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index 410da2c93..6d24c4c8c 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -411,6 +411,7 @@ struct iso_client_data {
 	uint8_t pkt_status;
 	const uint8_t *base;
 	size_t base_len;
+	bool bcast_defer_accept;
 };
 
 static void mgmt_debug(const char *str, void *user_data)
@@ -1141,6 +1142,16 @@ static const struct iso_client_data bcast_16_2_1_recv_defer = {
 	.recv = &send_16_2_1,
 	.bcast = true,
 	.server = true,
+	.bcast_defer_accept = true,
+};
+
+static const struct iso_client_data bcast_16_2_1_recv_defer_no_bis = {
+	.qos = QOS_IN_16_2_1,
+	.expect_err = 0,
+	.defer = true,
+	.bcast = true,
+	.server = true,
+	.bcast_defer_accept = false,
 };
 
 static const struct iso_client_data bcast_ac_12 = {
@@ -2257,8 +2268,11 @@ static int listen_iso_sock(struct test_data *data)
 
 		bacpy(&addr->iso_bc->bc_bdaddr, (void *) dst);
 		addr->iso_bc->bc_bdaddr_type = BDADDR_LE_PUBLIC;
-		addr->iso_bc->bc_num_bis = 1;
-		addr->iso_bc->bc_bis[0] = 1;
+
+		if (!isodata->defer || isodata->bcast_defer_accept) {
+			addr->iso_bc->bc_num_bis = 1;
+			addr->iso_bc->bc_bis[0] = 1;
+		}
 
 		err = bind(sk, (struct sockaddr *) addr, sizeof(*addr) +
 						   sizeof(*addr->iso_bc));
@@ -2420,9 +2434,21 @@ static gboolean iso_accept_cb(GIOChannel *io, GIOCondition cond,
 			return false;
 		}
 
-		if (isodata->bcast && data->step > 1) {
-			data->step--;
-			goto connect;
+		if (isodata->bcast) {
+			if (data->step > 1)
+				data->step--;
+			else
+				data->step++;
+
+			iso_connect(io, cond, user_data);
+
+			if (!data->step)
+				return false;
+
+			if (!isodata->bcast_defer_accept) {
+				tester_test_passed();
+				return false;
+			}
 		}
 
 		if (!iso_defer_accept(data, io)) {
@@ -2444,7 +2470,6 @@ static gboolean iso_accept_cb(GIOChannel *io, GIOCondition cond,
 		}
 	}
 
-connect:
 	return iso_connect(io, cond, user_data);
 }
 
@@ -3031,6 +3056,10 @@ int main(int argc, char *argv[])
 						&bcast_16_2_1_recv_defer,
 						setup_powered,
 						test_bcast_recv);
+	test_iso("ISO Broadcaster Receiver Defer No BIS - Success",
+						&bcast_16_2_1_recv_defer_no_bis,
+						setup_powered,
+						test_bcast_recv);
 
 	test_iso("ISO Broadcaster AC 12 - Success", &bcast_ac_12, setup_powered,
 							test_bcast);
-- 
2.39.2