Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
From:   Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, iulia.tanasescu@nxp.com
Subject: [PATCH v3 1/2] transport: Update transport release flow for bcast src
Date:   Wed,  4 Oct 2023 10:56:45 +0300
Message-Id: <20231004075646.4277-2-silviu.barbulescu@nxp.com>
In-Reply-To: <20231004075646.4277-1-silviu.barbulescu@nxp.com>
References: <20231004075646.4277-1-silviu.barbulescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ubXm3Alh9I9xXEGykRphqYdsXLIqEwWBH127Z0A3IrXlUG9eAsl7D7/4EpvZ?=
 =?us-ascii?Q?XOmHOeJWO+iJufST8bfj9MI64uZwDOi+8dERktR9i5s/rlLbeNq7mYeFouoC?=
 =?us-ascii?Q?xRRI/F9sYS9rZIZw7zcfE68bPKwR+/c5m6qoSv8XDfyMmS2dtXRyKyb4yCEv?=
 =?us-ascii?Q?73gS5akNgsmfeWD1UHsOFFuwqAbCHWLDNQ9Ph+tKPQ/TICi82yGrP5Zdi3BO?=
 =?us-ascii?Q?hAtWMQPJxaLpNNn8RvQQrE8U19YVpowx1ecFWU0T+C2OVmiVFuIGreY9xftc?=
 =?us-ascii?Q?4qJt5x1lCI8PrAOY3e3IPpEdky9shMy9njaRNI92nPyKfM+rgc3yLXYRJdSY?=
 =?us-ascii?Q?rSZVd7IIIFyrhKijpyCOyi8LtfNKP+n/6QfqajfPlwwEsceb+ckbkUElGN1p?=
 =?us-ascii?Q?N7V13Bv591WTjwLuyc7oeSfvFoKf08X8oGu5MOR6Yj9xHdQ3sb5EpUOLSHDY?=
 =?us-ascii?Q?53GliLH7JNF8DTIdhUbZBZdfiSM+5C4r9ckwRnLKN7sV6xhffWHoQtJ9+GAy?=
 =?us-ascii?Q?NVIeDOMmz5LockcttQ7lOt0E521VDzJ3tdSvMA5RmWqlv+3gNhmaMdNwFgh/?=
 =?us-ascii?Q?MDg+OpskuQxtBMNffcY/U85lZWszr1qItnzOQmbljjOjxrLpgpO4E+cTh98y?=
 =?us-ascii?Q?iAq1otaiQNiofYRuSlE6rTceI9JCZ4rOb850EtFKZXmwmZZVPxcGoBv4PpGB?=
 =?us-ascii?Q?1KgN8qsWdQ0bTouDCj/xmqTwPsBSbYSJglFNuZ1ldksrFi0jJhbOratzCu0R?=
 =?us-ascii?Q?kcAblyvqewx8LR36/978aNRdtT5AbJbSNanZ/JX5rgzxkfPM2S+Mc6HliNSX?=
 =?us-ascii?Q?N1UeHyIy/7vMfojbE7iW7QjZ8Bm//8O/v6XCBuq8wcd/2Qx5KebA3Y+ZWzNT?=
 =?us-ascii?Q?Rx7KnrX+kZ2X5fW7a6ucKkMv5aWhPrFvMkVAhlxq7Zfim3YE6YzJX67EUJHD?=
 =?us-ascii?Q?cy4cULwhAPikTafbev7ZP6jAvfoqYu8al290h9hBKfAt5/yLJ6JTOid5NV/Y?=
 =?us-ascii?Q?Ji4eNzHs+u6S+L5ECkIvIg2wnGSRGhyKhkRgYQiNeWF7xRz1dYU2nQymlTji?=
 =?us-ascii?Q?LAs4fZWsqNUyAaq8Xc4M39e29dxfjno6IK48WGFwcJvhreVUwgidpWkbgMkz?=
 =?us-ascii?Q?aWxQNnAuQeMaT7llrFDU3qgOjKoMjw0ancRxkxxHvGDXPc9JqFAUW6Hd5taP?=
 =?us-ascii?Q?BjIzZSRERIM1veW1DAbju+50H64i5EaXv6QmVALGJf4VEjum3eieykP2Z5Oz?=
 =?us-ascii?Q?NriX2iSf2MZYEhR7kxeUcTHnTb+t0NsjXUlkXLE6r4/jKYRRaT+XsPqA77xv?=
 =?us-ascii?Q?rt+WViNyYz0uO0Ito3XUHuiWAh5TCLM0By1ux+NGCSx42oNlRKuPH1yiblQ3?=
 =?us-ascii?Q?zm5ihdkSBELyuchtnXROiGVqLVwWKkn7/ApGL8ohZUXqiV+fd7MPhkhVYzx2?=
 =?us-ascii?Q?FJlLtOYpCJ0Nm05avfNvDDOB/SpbOZRqcyMniKiIKn7G5ad1JqctZeULivYD?=
 =?us-ascii?Q?83ip5JKUGYmbRYK7iCd1IzBTnTtZv4/oq2aPMbnL5+wDDPV7lOS0sBFobVx7?=
 =?us-ascii?Q?ymjgBBkyrrjOZj2HOR8zo4jEmgUR4L1a6x8/4O59t8J4l6cdD0VO/UayBOeQ?=
 =?us-ascii?Q?Og=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3e77c42-c144-4a44-15ea-08dbc4af7b65
X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB6331.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 07:56:57.3597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9uvvSteRdTqP21I5OhnVZWWXS7SyNvxvZo4ZEP+OV6DoIF9CaG7yZl+WmwVffZZHiv2jl5N51Z7Q8NeWGkoc5+IoAAZI2LU9l8YdBCYAudA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB10017
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 04 Oct 2023 00:57:15 -0700 (PDT)

Update transport release flow for broadcast source

---
 profiles/audio/transport.c | 65 ++++++++++++++++++++++----------------
 1 file changed, 38 insertions(+), 27 deletions(-)

diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
index 1e03b7b51..23ea267f6 100644
--- a/profiles/audio/transport.c
+++ b/profiles/audio/transport.c
@@ -606,11 +606,38 @@ static DBusMessage *try_acquire(DBusConnection *conn, DBusMessage *msg,
 	return NULL;
 }
 
+static void bap_stop_complete(struct bt_bap_stream *stream,
+					uint8_t code, uint8_t reason,
+					void *user_data)
+{
+	struct media_owner *owner = user_data;
+	struct media_request *req = owner->pending;
+	struct media_transport *transport = owner->transport;
+
+	/* Release always succeeds */
+	if (req) {
+		req->id = 0;
+		media_request_reply(req, 0);
+		media_owner_remove(owner);
+	}
+
+	transport_set_state(transport, TRANSPORT_STATE_IDLE);
+	media_transport_remove_owner(transport);
+}
+
+static void bap_disable_complete(struct bt_bap_stream *stream,
+					uint8_t code, uint8_t reason,
+					void *user_data)
+{
+	bap_stop_complete(stream, code, reason, user_data);
+}
+
 static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 					void *data)
 {
 	struct media_transport *transport = data;
 	struct media_owner *owner = transport->owner;
+	struct bap_transport *bap = transport->data;
 	const char *sender;
 	struct media_request *req;
 	guint id;
@@ -642,6 +669,11 @@ static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 	req = media_request_create(msg, id);
 	media_owner_add(owner, req);
 
+	if (bt_bap_stream_get_type(bap->stream) ==
+			BT_BAP_STREAM_TYPE_BCAST) {
+		bap_disable_complete(bap->stream, 0x00, 0x00, owner);
+	}
+
 	return NULL;
 }
 
@@ -1370,32 +1402,6 @@ static guint resume_bap(struct media_transport *transport,
 	return id;
 }
 
-static void bap_stop_complete(struct bt_bap_stream *stream,
-					uint8_t code, uint8_t reason,
-					void *user_data)
-{
-	struct media_owner *owner = user_data;
-	struct media_request *req = owner->pending;
-	struct media_transport *transport = owner->transport;
-
-	/* Release always succeeds */
-	if (req) {
-		req->id = 0;
-		media_request_reply(req, 0);
-		media_owner_remove(owner);
-	}
-
-	transport_set_state(transport, TRANSPORT_STATE_IDLE);
-	media_transport_remove_owner(transport);
-}
-
-static void bap_disable_complete(struct bt_bap_stream *stream,
-					uint8_t code, uint8_t reason,
-					void *user_data)
-{
-	bap_stop_complete(stream, code, reason, user_data);
-}
-
 static guint suspend_bap(struct media_transport *transport,
 				struct media_owner *owner)
 {
@@ -1499,9 +1505,14 @@ static void bap_state_changed(struct bt_bap_stream *stream, uint8_t old_state,
 			return;
 		break;
 	case BT_BAP_STREAM_STATE_STREAMING:
-		if (bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SOURCE)
+		if ((bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SOURCE) ||
+			(bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SINK))
 			bap_update_bcast_qos(transport);
 		break;
+	case BT_BAP_STREAM_STATE_RELEASING:
+		if (bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SINK)
+			return;
+		break;
 	}
 
 	io = bt_bap_stream_get_io(stream);
-- 
2.39.2