Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
From:   Mahesh Talewad <mahesh.talewad@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     luiz.dentz@gmail.com, devyani.godbole@nxp.com,
        nitin.jadhav@nxp.com, mahesh.talewad@nxp.com
Subject: [PATCH BlueZ v4 2/2] src/shared/micp.c :MICP-MICS implementation memory leak fix
Date:   Thu,  5 Oct 2023 15:15:44 +0300
Message-Id: <20231005121544.306495-3-mahesh.talewad@nxp.com>
In-Reply-To: <20231005121544.306495-1-mahesh.talewad@nxp.com>
References: <20231005121544.306495-1-mahesh.talewad@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bHs/uIgcJjzDBRHbJN2Zpdr/qBUAsbEU/Kh4qDaSNO1gT6/QR988J14B/mkt?=
 =?us-ascii?Q?WaZCexo42i8BwitPfYi5mHpcjA9HuxPVB3b8DHYpCHIwbWq8eVidfvffwTs9?=
 =?us-ascii?Q?hY159v8fLLjkveJdIScG0WE+ZgTuop7JPY39474JmzpQD8yhd9OciTGMNQuv?=
 =?us-ascii?Q?uNsAHQSKelthKLFwVeJ2bwGnh0JU+GHk5cVvHbYCjELMnBN8hHylg1m8Xx2W?=
 =?us-ascii?Q?zBKnb88nh99UzQIpordCpJnXuz/8jSm85JSNqtImz1EjQXnidMTSLUOas4Ab?=
 =?us-ascii?Q?dNIt1r2K/Yt+sSQh6pfMaLXftfeFRuOlXEGYbOVDVtE3iT4B/0DENTz68j2z?=
 =?us-ascii?Q?iJ5p+x0WwSKmuesHq1Q48RXB/ehuAoMUcXjZwyxBSC8ze2LRoEHu/Y6RpaYg?=
 =?us-ascii?Q?gem8XVwo8o216quup/bvRGZNrc2Z2vbgJ9LK4FIcPQ0yjuLLL0HGIjFPuT35?=
 =?us-ascii?Q?OeFj+cTiKXDPu8e576swxolOekWGroAmk3Pukja/aLm84cLfkh9uefF/Zkh4?=
 =?us-ascii?Q?i4qG/lJygrgGZmeaRUPDeuash0QRwQH4j2kPn/sFY24LIYj1JBN5pyh2FBHS?=
 =?us-ascii?Q?S4V2Wd9txzLYU8lixVwBKJDqF9OhmuskmVosr80R5aDA0Ab5fxfkNsE0IEai?=
 =?us-ascii?Q?RH65xfF85nhzAkwVGLB8AMDugXaT5PMOqZmdZ1K3ECZfv+gDzrCNC47uFmN9?=
 =?us-ascii?Q?Mt7bARAUBCD8PG0Su6/oAE3HXdtBtgrJGof8c3EgsSZJ4KItqimD7bTcOYr7?=
 =?us-ascii?Q?1R5QuWF5Rr+kMtP3zEEzkNWVCizNAYK5/Kp1kx5V3nPAxFqPdGCYpG16eUkG?=
 =?us-ascii?Q?aYKWb5nOUd3cFmIXkYSklOEZXuW/p8ro/7BhqAAedUjLNEbGxQ+8aDaNLPhq?=
 =?us-ascii?Q?jdq/cgWo2F3KPhJeFYu/sO2+favqKUQ+2ASHHogMkUlgeCmj6UjCrp34QUpi?=
 =?us-ascii?Q?HScG1pSg3OcQ9+eX7nMenog4t3rtFfgBqNyUPXdn+C8Uex92Pd22FUIgh8ON?=
 =?us-ascii?Q?NnjKNUuZMgeYsGPhVLoo4sHdpztii/lvLVfUnevxUwfWbkcVGxUiKzHI7+Wn?=
 =?us-ascii?Q?Avafo1RiCklZuxp6hO/pAqQebSmPV2h5goI9v7UriV09mY6EFdR0E+TElngW?=
 =?us-ascii?Q?dGpVTZPiPYqLnqqJgoMcr377Vr1NHNYSDCc9MX74MBHmrZkBQ4yzgJKTpXyy?=
 =?us-ascii?Q?sWzuXqvVbSQfwtq6R4hsaO8X5oC47+fMnnXdDopZvIBbVaLfEf6+Mu8OalVR?=
 =?us-ascii?Q?v6D6bDpyVAiENzG5oWjr6Sg+rEXahm3p0f4LFOONhDOiHuIOHnAR2jdjT4sH?=
 =?us-ascii?Q?J+dLHvHRyZURfH/0iEtwSL+jlXhRpDSWrhaWEMksI+b1vL9QDqyYZbH2bpqV?=
 =?us-ascii?Q?i4z3JSty5/B+HSS5EimWq1o+IalrGGjZkpx00qhH2I5HiBqTBpXLwpBA9H+W?=
 =?us-ascii?Q?fUyuy6r3mAc1Zs2YrZlvhqiVH6hti8grmTarwz/gCwJGrEce500s5hAxTDaS?=
 =?us-ascii?Q?qBAAltq/DI8G8aLjVCTavoErUO1BPzaXtUvoMUAGuc4vQa9Xtg0u80T4CFzJ?=
 =?us-ascii?Q?O/lgV3q9CsNez67WG6fnBtID1aAeUGFIv2gVIwfm/jZCqbWKul0NPaA7Qfi/?=
 =?us-ascii?Q?FQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a56c47dc-37d8-4936-7adf-08dbc59ce1ad
X-MS-Exchange-CrossTenant-AuthSource: AS1PR04MB9654.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2023 12:16:19.6258
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BZ0oBP1D5aP/1lb/lBKZTsFzQUT0ab/9o6QNyi/JocUcxwUec3KWlRRLmCKAXFtPziJQ4YmSV2QoKPvYrU6MNg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8928
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,T_SPF_PERMERROR,URIBL_BLOCKED
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 05 Oct 2023 09:06:12 -0700 (PDT)

- Fixed memory leak issue
---
 src/shared/micp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/shared/micp.c b/src/shared/micp.c
index 90d05b301..b82bd92de 100644
--- a/src/shared/micp.c
+++ b/src/shared/micp.c
@@ -138,6 +138,7 @@ void bt_micp_detach(struct bt_micp *micp)
 	if (!queue_remove(sessions, micp))
 		return;
 
+	bt_gatt_client_idle_unregister(micp->client, micp->idle_id);
 	bt_gatt_client_unref(micp->client);
 	micp->client = NULL;
 
@@ -175,6 +176,7 @@ static void micp_free(void *data)
 
 	micp_db_free(micp->rdb);
 
+	queue_destroy(micp->notify, free);
 	queue_destroy(micp->pending, NULL);
 	queue_destroy(micp->ready_cbs, micp_ready_free);
 
@@ -594,6 +596,7 @@ struct bt_micp *bt_micp_new(struct gatt_db *ldb, struct gatt_db *rdb)
 	micp->ldb = mdb;
 	micp->pending = queue_new();
 	micp->ready_cbs = queue_new();
+	micp->notify = queue_new();
 
 	if (!rdb)
 		goto done;
-- 
2.34.1