Received: by 2002:a05:7412:da14:b0:e2:908c:2ebd with SMTP id fe20csp2069189rdb; Mon, 9 Oct 2023 11:23:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwSSumfYI0SXh8uw+aqVPv4SwCugbCoUIqFTgTs7EwzK4kr12xUGapNTCtOX7ocli7Pv29 X-Received: by 2002:a17:902:da86:b0:1c7:3f5f:1b9f with SMTP id j6-20020a170902da8600b001c73f5f1b9fmr14974025plx.45.1696875821941; Mon, 09 Oct 2023 11:23:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696875821; cv=none; d=google.com; s=arc-20160816; b=fKBy0GHuWrjPlb7l/ISTsitvA8PEtMJBZZbVo1QUrXrur0ECNldmQpZs3LuBU12j3j 2V7WXG8hMZLY0ZFw1jrVn+8s5L3P25wG15SCf28/6yNY51A8AimRtSlVlGrJaS4aKHli d1yloUdMYx1t7Zsof7y2EHXSZjyeIDWn3Fe5kFuQtU2kOmhBrbTdxeNEzmEUlKojkyxU WWsq/dVcHx4JUKxkrUfzbdtndZujmTgJzTRKJmY365mkHvPvL1pBbulBhrLCgAnjb0dB mNz3vHwChLMSwKv+XrQB9Gk2nN8uCIsPFFqy0CMD276QEPpGnXoap1N8+z4RDaHJNqPg QuWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:date:references:in-reply-to :message-id:mime-version:user-agent:feedback-id:dkim-signature :dkim-signature; bh=Wcd9Ij4JYV1E+nR/hpGySlpt2XMckRY/pSxHN2nuT44=; fh=Z8+E5HyUX7I2rUt3XmkVDWN1S8tMfsyhQOZJZCwURAs=; b=IpzxvI1Q88fTgIovMmGd5HKpwXGWvYwK9ObKqa9xEuud0QZE+mJwpSEDERmBqz5HiU ep1xsU2SJPydDyR0NarlZZHqOejVOxUN8Ua5s5v15u3cS0R12haPVUCaksVJENPggRZ9 baJxL+wbK4Ui2cfTeJCYSXls2xrS9fkRmXXGQ7o4xdQFqXvZ0Rv1Z7Hpg06KFNzOH6sP OsPji87pNY1OHdzkeEfrOB7rGyHZC3FWlk6wUusnCqtFydg3zGHb0R574UHvSvGl+zla HAF25KC5QqfoqwXEHO8TklAT382MzBcvZYTc5z3Q4QYcSSFuqkckKPAFCdKiWXE+kqDG TbsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=XV7aUMVw; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="bFwMxcn/"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id o4-20020a17090323c400b001bdebddc2f7si6513773plh.257.2023.10.09.11.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 11:23:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@arndb.de header.s=fm2 header.b=XV7aUMVw; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="bFwMxcn/"; spf=pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id B7E26802E6FE; Mon, 9 Oct 2023 11:23:32 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345624AbjJISXb (ORCPT + 99 others); Mon, 9 Oct 2023 14:23:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346618AbjJISXb (ORCPT ); Mon, 9 Oct 2023 14:23:31 -0400 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 137129C; Mon, 9 Oct 2023 11:23:30 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7A83B5C02A5; Mon, 9 Oct 2023 14:23:29 -0400 (EDT) Received: from imap50 ([10.202.2.100]) by compute5.internal (MEProxy); Mon, 09 Oct 2023 14:23:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1696875809; x=1696962209; bh=Wc d9Ij4JYV1E+nR/hpGySlpt2XMckRY/pSxHN2nuT44=; b=XV7aUMVw6tBmZF3184 benoVGAqBsGo6v+7HlonfIiZ2GxFf+B7g/2BoXMSSxJxX1Yvb88PYiXT5YaD4yod wjnvP9vFBgO/REAxQc3h84AdLI351ANAvIlM59fYsk+8uLEAWze3aXTwUVZdJJQw FHJCONrZSeQnPABoXquUds7I+7OlWSnHjUetjPQNgIKT7vAjDuLO9oryuRtqpzDX gKX296v1suXSoXehtKhgs1JV7H0t6WVMbz4PRAwoSp/zSxmFhdps3nb/UsbY0xTC q8WRta6MXRTD/tO9huHomZj4jCa2Ig8YAIIy/c5h2F0lyoYTHMN9Z916aPjQhH/T AFZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1696875809; x=1696962209; bh=Wcd9Ij4JYV1E+ nR/hpGySlpt2XMckRY/pSxHN2nuT44=; b=bFwMxcn/u/mOSCI/OoRvcCkh7yPnT PEUWerddl5JyuFUlZuj8wKEfufOjYZXmVZBzpXnkP7aqabXUS/UnyIgO9oA9iwJJ wVYnUNF8EIReb2/VPhqb8S3iHcjMVXkMxK/laoO/ajSFqTyU1fJFbpTTfPvVbj1T ZsLwdBcafWXJ7vFw3/Yfy8rBieGi9JOrBZ7KIiVGdo8uVNhmczmuWsB0ZxYOFu9B MSJB5a1QhfioUudWn7yybpmgV3bPZRPcop8arFqsmN1JmwYNiAav/NnjthnvE1Uq 3uBjUds8dHkIU+Fw/i2GBKjWB8oHlFhRijfP6ZLqiRsLQwTYOagopq5Sw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrheefgdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepgeetiefhjedvhfeffffhvddvvdffgfetvdetiefghefhheduffeljeeuuddv lefgnecuffhomhgrihhnpehprghsthgvsghinhdrtghomhenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E93751700089; Mon, 9 Oct 2023 14:23:28 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-958-g1b1b911df8-fm-20230927.002-g1b1b911d MIME-Version: 1.0 Message-Id: <73f552a4-4ff5-441a-a624-ddc34365742f@app.fastmail.com> In-Reply-To: <202310090902.10ED782652@keescook> References: <20231009134826.1063869-1-arnd@kernel.org> <2abaad09-b6e0-4dd5-9796-939f20804865@app.fastmail.com> <202310090902.10ED782652@keescook> Date: Mon, 09 Oct 2023 20:23:08 +0200 From: "Arnd Bergmann" To: "Kees Cook" Cc: "Arnd Bergmann" , "Marcel Holtmann" , "Johan Hedberg" , "Luiz Augusto von Dentz" , "David S . Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Chun-Yi Lee" , "Luiz Augusto von Dentz" , stable@vger.kernel.org, "Iulia Tanasescu" , "Wenjia Zhang" , linux-bluetooth@vger.kernel.org, Netdev , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Bluetooth: mark bacmp() and bacpy() as __always_inline Content-Type: text/plain X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 09 Oct 2023 11:23:33 -0700 (PDT) X-Spam-Level: ** On Mon, Oct 9, 2023, at 18:02, Kees Cook wrote: > On Mon, Oct 09, 2023 at 05:36:55PM +0200, Arnd Bergmann wrote: >> On Mon, Oct 9, 2023, at 15:48, Arnd Bergmann wrote: >> >> Sorry, I have to retract this, something went wrong on my >> testing and I now see the same problem in some configs regardless >> of whether the patch is applied or not. > > Perhaps turn them into macros instead? I just tried that and still see the problem even with the macro, so whatever gcc is doing must be a different issue. Maybe it has correctly found a codepath that triggers this? If you are able to help debug the issue better, see these defconfigs for examples: https://pastebin.com/raw/pC8Lnrn2 https://pastebin.com/raw/yb965unC Arnd