Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, iulia.tanasescu@nxp.com
Subject: [PATCH v3 1/2] transport: Update transport release flow for bcast src
Date:   Tue, 10 Oct 2023 17:49:16 +0300
Message-Id: <20231010144917.4400-2-silviu.barbulescu@nxp.com>
In-Reply-To: <20231010144917.4400-1-silviu.barbulescu@nxp.com>
References: <20231010144917.4400-1-silviu.barbulescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?APLSy/cpazNwisUxbSb5nXeJ8AA7QrN7LjZlw2bZGXofBbxyJ9mroyrF+ZQm?=
 =?us-ascii?Q?zFAPa883lLU7Q5zHxPyFRfCT0EWZvVHCTx6ArIgBDNv3cc382BYn422B23oV?=
 =?us-ascii?Q?jgvYYADGxiRHBGPHNFIQRTWGIEXQkAo21Tp6eSSC/N5oTRGVlaOg65nCbLaS?=
 =?us-ascii?Q?hTeX6ftYZ7Jc/am7mbQ5T/hF2snfCgKL1K8K5XANn2QNJrrNFkTB2JdHSp89?=
 =?us-ascii?Q?ye93RJ4M0AkhirX7VHlJqHWb4mAhHoMLXRwV4h5kNZasf1tUFHqqkapPPAQg?=
 =?us-ascii?Q?l3LtnHMdpdivQo68u9mQvYvB8PwuYxM2hMgXwBvvl5UzfzJTZgi2Za0WnUEh?=
 =?us-ascii?Q?//xA2Pal31GTWzJvkw23bm9qSBhac/265xCbfzbYtC7L4noGNoVi2zSN/4FV?=
 =?us-ascii?Q?I+ehbaOrGQ7RVlPgaLAVktCRAzJCDiI+WFAowl347X3/jTg/X/Ol+2qMAwa0?=
 =?us-ascii?Q?RJIKBMSsGdlnh1kYnPU0P4n6WHfvHtZdua7yVR5ucRYweomALPAt+08VSHM6?=
 =?us-ascii?Q?vnQvjW6a9XuQ7Vly7hd3nZGUKiqwZkseyg8CNrwOwrLdgoeMIzusYYZpn3el?=
 =?us-ascii?Q?U6WOU6/obN5AN9irmRYTDzs2tMKCcKxViDhHDAumzzpe/DRZbrFJ5zXy9uOe?=
 =?us-ascii?Q?gjKyhwc58eFaUSYGXpnA9U5xrntWXIhPcopaXCCMbgeoai7/ziSeAnWrZ8Mb?=
 =?us-ascii?Q?1tJl8PQ+j+8l88cSuTzn788HG34aysePluumlqzK9v06sqIDjfCrof8AKxYo?=
 =?us-ascii?Q?xxhonTwavLDTLmnKAlm/umWo8PPIAoaewHkLrHdYd3bVt3AWF1l3pizuUrkk?=
 =?us-ascii?Q?FUB4i0qT05QchtH8OsbOxDTxbeqVGgRFLLj0iWUT2akl8hCg3ah6eg8e4RbY?=
 =?us-ascii?Q?Dc3b0gJHvnqpepMBRPd5HJADLXYQtitAo3xtEpluJK+vYGAhvWe6UNc4XMUV?=
 =?us-ascii?Q?feVvEx1+P/MOurn8hTUMhXun8xJ1O5leOKr7HgxydQtKucchFsUYj2UpsH0d?=
 =?us-ascii?Q?Td4nTnR8qeRK+45/WGut6svQ+1QYDNZRSzlXcGfNHoh17DDM9cbrzyKikkTq?=
 =?us-ascii?Q?qHuO8Uj4Ur8xcFj6lqz6+hbWtoufmWwQyUSSnKieSc/MwBUOhTsX1Jl+tj+c?=
 =?us-ascii?Q?G4+qAPaLvW9EQWX1bsTGS4YqsYCgOvcmmj3pkHs4LAA33XLjL8IPqZOEspBJ?=
 =?us-ascii?Q?ggIwmTDpJTqx+unxEniPe7f0urrVUUAINr3oCu5bVzFmWEbzESHK3nceZXDs?=
 =?us-ascii?Q?Ap+59zkRAJRja4cBU3svxNXZ7F2iPmyM7e7vMmh8nySQ9anWDumTmp08rYg7?=
 =?us-ascii?Q?tiz9S8m/0UQaVrLMw02qvf+gb70Jw7V4oxsQ82tkSQ8eDTOZyx83ibiaui5C?=
 =?us-ascii?Q?FhZh+3GijAwJPOMwxHDWdRCsnkWi4VrgFUzNNQOAbp4+cFgpRB1n2iC7Rw5i?=
 =?us-ascii?Q?wt/J7A7plVv8mnuvejkDVDmilCiGADOfZ1kX2OSAF86it6Crcl6J6BOSariH?=
 =?us-ascii?Q?cCeYckfFwmAhDJMphI01lCs1iaDlwnODcU8i4u33xPWdbvbg8DSNXGKY9d/J?=
 =?us-ascii?Q?tfjpOd5sotZcK8stpxRSnASmrcYuVjVK6otsxgFB8CoqlA1im63wAALCHkty?=
 =?us-ascii?Q?NA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2dc024cb-5d6c-4ea5-d596-08dbc9a0193a
X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB6331.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 14:49:26.0618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3UDPRdLCeo8SztVEoWiIni3G6zPlV23d54tK4Bcsipl8HW2vGTUTCvwXMdyUdln6rJxQM2uE/3TUyBhBwCEEE9Mrwkzn3HXgf6g6WaMVJEk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9220
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 10 Oct 2023 07:49:39 -0700 (PDT)
X-Spam-Level: **

Update transport release flow for broadcast source

---
 profiles/audio/transport.c | 65 ++++++++++++++++++++++----------------
 1 file changed, 38 insertions(+), 27 deletions(-)

diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
index 1e03b7b51..23ea267f6 100644
--- a/profiles/audio/transport.c
+++ b/profiles/audio/transport.c
@@ -606,11 +606,38 @@ static DBusMessage *try_acquire(DBusConnection *conn, DBusMessage *msg,
 	return NULL;
 }
 
+static void bap_stop_complete(struct bt_bap_stream *stream,
+					uint8_t code, uint8_t reason,
+					void *user_data)
+{
+	struct media_owner *owner = user_data;
+	struct media_request *req = owner->pending;
+	struct media_transport *transport = owner->transport;
+
+	/* Release always succeeds */
+	if (req) {
+		req->id = 0;
+		media_request_reply(req, 0);
+		media_owner_remove(owner);
+	}
+
+	transport_set_state(transport, TRANSPORT_STATE_IDLE);
+	media_transport_remove_owner(transport);
+}
+
+static void bap_disable_complete(struct bt_bap_stream *stream,
+					uint8_t code, uint8_t reason,
+					void *user_data)
+{
+	bap_stop_complete(stream, code, reason, user_data);
+}
+
 static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 					void *data)
 {
 	struct media_transport *transport = data;
 	struct media_owner *owner = transport->owner;
+	struct bap_transport *bap = transport->data;
 	const char *sender;
 	struct media_request *req;
 	guint id;
@@ -642,6 +669,11 @@ static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 	req = media_request_create(msg, id);
 	media_owner_add(owner, req);
 
+	if (bt_bap_stream_get_type(bap->stream) ==
+			BT_BAP_STREAM_TYPE_BCAST) {
+		bap_disable_complete(bap->stream, 0x00, 0x00, owner);
+	}
+
 	return NULL;
 }
 
@@ -1370,32 +1402,6 @@ static guint resume_bap(struct media_transport *transport,
 	return id;
 }
 
-static void bap_stop_complete(struct bt_bap_stream *stream,
-					uint8_t code, uint8_t reason,
-					void *user_data)
-{
-	struct media_owner *owner = user_data;
-	struct media_request *req = owner->pending;
-	struct media_transport *transport = owner->transport;
-
-	/* Release always succeeds */
-	if (req) {
-		req->id = 0;
-		media_request_reply(req, 0);
-		media_owner_remove(owner);
-	}
-
-	transport_set_state(transport, TRANSPORT_STATE_IDLE);
-	media_transport_remove_owner(transport);
-}
-
-static void bap_disable_complete(struct bt_bap_stream *stream,
-					uint8_t code, uint8_t reason,
-					void *user_data)
-{
-	bap_stop_complete(stream, code, reason, user_data);
-}
-
 static guint suspend_bap(struct media_transport *transport,
 				struct media_owner *owner)
 {
@@ -1499,9 +1505,14 @@ static void bap_state_changed(struct bt_bap_stream *stream, uint8_t old_state,
 			return;
 		break;
 	case BT_BAP_STREAM_STATE_STREAMING:
-		if (bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SOURCE)
+		if ((bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SOURCE) ||
+			(bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SINK))
 			bap_update_bcast_qos(transport);
 		break;
+	case BT_BAP_STREAM_STATE_RELEASING:
+		if (bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SINK)
+			return;
+		break;
 	}
 
 	io = bt_bap_stream_get_io(stream);
-- 
2.39.2