Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
From:   Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     luiz.dentz@gmail.com, claudia.rosu@nxp.com,
        mihai-octavian.urzica@nxp.com, silviu.barbulescu@nxp.com,
        vlad.pruteanu@nxp.com, andrei.istodorescu@nxp.com,
        iulia.tanasescu@nxp.com
Subject: [PATCH v3 1/2] transport: Update transport release flow for bcast src
Date:   Tue, 10 Oct 2023 17:52:41 +0300
Message-Id: <20231010145243.4441-2-silviu.barbulescu@nxp.com>
In-Reply-To: <20231010145243.4441-1-silviu.barbulescu@nxp.com>
References: <20231010145243.4441-1-silviu.barbulescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VyNcMyPGwMzymyngEB0UTVmQIxdz3SmsgN2CLPMTMhmUyEfSWsZgGjhRAuni?=
 =?us-ascii?Q?gF50dI029QfNRSBlMxvT3bUK4gCes3ttqIXjljVCxRhdZPbsCEKTPwU51C79?=
 =?us-ascii?Q?kaRHQmvQ2GaBz0umV2uuPEEhPtG84ExCePv8Xvrthv1P+RxIWmV0RdHFi6Vh?=
 =?us-ascii?Q?Qu2KthT1NQqjhve6ay9/dnmLKSKR6NFiLz3PrYCZA8jJaiwGIz086GvSzPXg?=
 =?us-ascii?Q?OHNGlBpl1D4Zn8Z2YjRMCrs56nfHJgqVSLa5JmE295ceoQIAyjkA4wTOVqkb?=
 =?us-ascii?Q?47NYRXdRwE8dxt2xzzDzKUCrm9HD6rFaPhCwFUvNvBvpkuqpSYi65JC3c0Nl?=
 =?us-ascii?Q?1VGDQroNLH9p80Vk7/dTHCYexYXZzE/HmFiWT79L2aifWyGnXp6zpb4pG4zD?=
 =?us-ascii?Q?Bhts/rJxg389eIk08/0fBQmdwoe8mMtNCaVS3o9aqBRs3XkPHfcbvDKQTzQD?=
 =?us-ascii?Q?uNOqnTKu9kLahNOULdtmpU8AKcletFRxX7Djwl0Uvq1i6pvGWGnmoxfkwXPA?=
 =?us-ascii?Q?xF58ib6w+iZtuhINJF339o2Xk74WgHR3e9evXhOSJxufItLwo2BLaXBLp88S?=
 =?us-ascii?Q?EDPENmO7m/otKc/9cAsg05WA4xv6yRbWteLX/LQxPk1aW6vAmhYcF+hfhKJA?=
 =?us-ascii?Q?DdxQBgfnvIcaD6RN2HV81Et7Yxbi+IbWlBB8iYf/dcFLsAqkCsMR+dVW84cW?=
 =?us-ascii?Q?QmmrFUSSUDF6YBW2/VBX83V9Kcjf6ytqdXsUgN0zVWwVo+vV5eFpSSHkj9VN?=
 =?us-ascii?Q?q0StUbO1Cn+gYDB3N2lHCx6ZxrszdzKFIuATpTrLf3QQzvO5HWtFvQAajeyW?=
 =?us-ascii?Q?Pu7flI9hUf1m/mbITzJ6Z07i96FjP01efbxRGutbQOvIg+nHsB9gMREDnC9u?=
 =?us-ascii?Q?5R8tsIP8GKyN2URnOC+W5hn1GYYiLyUnYx7g/Jl57SCxQdqAaNHY7bXWIMBL?=
 =?us-ascii?Q?XJhfVfifD4Lg0SgtxPQvBe5+kCWejqWopF2qFbTKjKNc5D3wOk91Ih+xsYZT?=
 =?us-ascii?Q?6SyJ44hhOjMWNzR30htkfvuOX0ZPgwYwrLnboj1VaPXSWL9kQywsIyqAYuX3?=
 =?us-ascii?Q?hhGrfI9bKx7R/mt06kbmT1DFLEjCbShHsaEJviPsPPWL9H7mredX5nPO4KpY?=
 =?us-ascii?Q?ApScWHZslJg34TNi6htx/zqLS2jC+WxswODmHY/pcGiUix69GCz38lY1pKGZ?=
 =?us-ascii?Q?tiX4YFtW9llxnCZodnZGXocS7sPTSukqTcqf94gg2k3OZiYNFD5A9PMGHCwO?=
 =?us-ascii?Q?p4uH9AsAA45A2KJk5v6h3WH1RLIe7L82eqd+Nwp6RViTKnONh4EuNM7SWSL7?=
 =?us-ascii?Q?/7NZ7RBzCzWg75Zzwgw95I+R99QUMz94I2b7AbzbiTppcMnbYs4iebSQAwzc?=
 =?us-ascii?Q?uLTlO3amRZWfd5FHbFWcCfHF+vTNL5hXEnqfeVAvpWhQ2DZV4azAosSNWIB6?=
 =?us-ascii?Q?cIOz7bs0KoEA/QBLr7E3IBNKYYnFzVHaLaxgezAPu0VtIQ9YIq3fxX+fFDH3?=
 =?us-ascii?Q?cCPIL0I/nvx6yhrpzLnYcs8q9foIXUBwDD6Q/TwJToTtZ7TadY0XdCJN8sFK?=
 =?us-ascii?Q?9RnkkFIaMC8M+jBoSTN5TeRXYsrLnLB88Wa8CQ4dX5jqNj5lNdI0ZM/PXk7C?=
 =?us-ascii?Q?BA=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a0db67a-6a4e-4004-e1f2-08dbc9a0937e
X-MS-Exchange-CrossTenant-AuthSource: DBBPR04MB6331.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2023 14:52:51.1081
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0ADeGQRxjNsEn6fUZ0xC33CGQLsNU2Tmq6/e8/xZEP3heWab3vxm6D383Bg2KDwyCVe/u+0hfJ7tLi+abY9wHco9ZwyM54tPwQs+eJf0ju8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9792
X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 10 Oct 2023 07:53:21 -0700 (PDT)
X-Spam-Level: **

Update transport release flow for broadcast source

---
 profiles/audio/transport.c | 65 ++++++++++++++++++++++----------------
 1 file changed, 38 insertions(+), 27 deletions(-)

diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
index 1e03b7b51..23ea267f6 100644
--- a/profiles/audio/transport.c
+++ b/profiles/audio/transport.c
@@ -606,11 +606,38 @@ static DBusMessage *try_acquire(DBusConnection *conn, DBusMessage *msg,
 	return NULL;
 }
 
+static void bap_stop_complete(struct bt_bap_stream *stream,
+					uint8_t code, uint8_t reason,
+					void *user_data)
+{
+	struct media_owner *owner = user_data;
+	struct media_request *req = owner->pending;
+	struct media_transport *transport = owner->transport;
+
+	/* Release always succeeds */
+	if (req) {
+		req->id = 0;
+		media_request_reply(req, 0);
+		media_owner_remove(owner);
+	}
+
+	transport_set_state(transport, TRANSPORT_STATE_IDLE);
+	media_transport_remove_owner(transport);
+}
+
+static void bap_disable_complete(struct bt_bap_stream *stream,
+					uint8_t code, uint8_t reason,
+					void *user_data)
+{
+	bap_stop_complete(stream, code, reason, user_data);
+}
+
 static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 					void *data)
 {
 	struct media_transport *transport = data;
 	struct media_owner *owner = transport->owner;
+	struct bap_transport *bap = transport->data;
 	const char *sender;
 	struct media_request *req;
 	guint id;
@@ -642,6 +669,11 @@ static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 	req = media_request_create(msg, id);
 	media_owner_add(owner, req);
 
+	if (bt_bap_stream_get_type(bap->stream) ==
+			BT_BAP_STREAM_TYPE_BCAST) {
+		bap_disable_complete(bap->stream, 0x00, 0x00, owner);
+	}
+
 	return NULL;
 }
 
@@ -1370,32 +1402,6 @@ static guint resume_bap(struct media_transport *transport,
 	return id;
 }
 
-static void bap_stop_complete(struct bt_bap_stream *stream,
-					uint8_t code, uint8_t reason,
-					void *user_data)
-{
-	struct media_owner *owner = user_data;
-	struct media_request *req = owner->pending;
-	struct media_transport *transport = owner->transport;
-
-	/* Release always succeeds */
-	if (req) {
-		req->id = 0;
-		media_request_reply(req, 0);
-		media_owner_remove(owner);
-	}
-
-	transport_set_state(transport, TRANSPORT_STATE_IDLE);
-	media_transport_remove_owner(transport);
-}
-
-static void bap_disable_complete(struct bt_bap_stream *stream,
-					uint8_t code, uint8_t reason,
-					void *user_data)
-{
-	bap_stop_complete(stream, code, reason, user_data);
-}
-
 static guint suspend_bap(struct media_transport *transport,
 				struct media_owner *owner)
 {
@@ -1499,9 +1505,14 @@ static void bap_state_changed(struct bt_bap_stream *stream, uint8_t old_state,
 			return;
 		break;
 	case BT_BAP_STREAM_STATE_STREAMING:
-		if (bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SOURCE)
+		if ((bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SOURCE) ||
+			(bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SINK))
 			bap_update_bcast_qos(transport);
 		break;
+	case BT_BAP_STREAM_STATE_RELEASING:
+		if (bt_bap_stream_io_dir(stream) == BT_BAP_BCAST_SINK)
+			return;
+		break;
 	}
 
 	io = bt_bap_stream_get_io(stream);
-- 
2.39.2