Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20231011191524.1042566-1-luiz.dentz@gmail.com> <20231013175443.5cb5c2ce@kernel.org>
In-Reply-To: <20231013175443.5cb5c2ce@kernel.org>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Fri, 13 Oct 2023 20:12:56 -0700
Message-ID: <CABBYNZ+A9Zk8HbQBPNXFLbaR_maCY7o5qHtx_MTJqhQ=LNBMPQ@mail.gmail.com>
Subject: Re: pull-request: bluetooth 2023-10-11
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     davem@davemloft.net, linux-bluetooth@vger.kernel.org,
        netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Jakub,

On Fri, Oct 13, 2023 at 5:54=E2=80=AFPM Jakub Kicinski <kuba@kernel.org> wr=
ote:
>
> On Wed, 11 Oct 2023 12:15:24 -0700 Luiz Augusto von Dentz wrote:
> >  - Fix race when opening vhci device
> >  - Avoid memcmp() out of bounds warning
> >  - Correctly bounds check and pad HCI_MON_NEW_INDEX name
> >  - Fix using memcmp when comparing keys
> >  - Ignore error return for hci_devcd_register() in btrtl
> >  - Always check if connection is alive before deleting
> >  - Fix a refcnt underflow problem for hci_conn
>
> Commit: fc11ae648f03 ("Bluetooth: hci_sock: Correctly bounds check and pa=
d HCI_MON_NEW_INDEX name")
>         Fixes tag: Fixes: 78480de55a96 ("Bluetooth: hci_sock: fix slab oo=
b read in create_monitor_event")
>         Has these problem(s):
>                 - Target SHA1 does not exist
>
> Commit: 6f0ff718ed67 ("Bluetooth: avoid memcmp() out of bounds warning")
>         Fixes tag: Fixes: d70e44fef8621 ("Bluetooth: Reject connection wi=
th the device which has same BD_ADDR")
>         Has these problem(s):
>                 - Target SHA1 does not exist
>
> Commit: b03f32b195df ("Bluetooth: hci_event: Fix coding style")
>         Fixes tag: Fixes: d70e44fef862 ("Bluetooth: Reject connection wit=
h the device which has same BD_ADDR")
>         Has these problem(s):
>                 - Target SHA1 does not exist
>
> Commit: a9500f272b3b ("Bluetooth: hci_event: Fix using memcmp when compar=
ing keys")
>         Fixes tag: Fixes: fe7a9da4fa54 ("Bluetooth: hci_event: Ignore NUL=
L link key")
>         Has these problem(s):
>                 - Target SHA1 does not exist
>
> :(

Not sure what I'm doing wrong, because verify_fixes.sh doesn't
actually warn these for me, or perhaps it needs to be used in a clean
tree/new clone since it may match commit ids of different
branchs/remotes? Anyway, I'm preparing a new pull-request.

--=20
Luiz Augusto von Dentz