Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     claudia.rosu@nxp.com, mihai-octavian.urzica@nxp.com,
        silviu.barbulescu@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, luiz.dentz@gmail.com,
        Iulia Tanasescu <iulia.tanasescu@nxp.com>
Subject: [PATCH BlueZ 1/1] iso-tester: Add test for bcast receiver PA bind
Date:   Mon, 16 Oct 2023 18:47:49 +0300
Message-Id: <20231016154749.3016-2-iulia.tanasescu@nxp.com>
In-Reply-To: <20231016154749.3016-1-iulia.tanasescu@nxp.com>
References: <20231016154749.3016-1-iulia.tanasescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zlr0lhFPwTgFVelXw/CGQ4JpN3lcQgYnJYktBl3eaA5yLT+x+dItKkT76wBW?=
 =?us-ascii?Q?REwRGd+0kzMRfNiRK6tWFZCUUx7wI3o0mq7nO2woAmkQRcm9ZzO9zVmx262t?=
 =?us-ascii?Q?OeROnkZq8Tz6XWc4qGALdbMYgZCGKvp9h27MjxeeYtLlV/RoMTnKwRzMP/5r?=
 =?us-ascii?Q?nJMDX4mg5OBbxE3RZjyNdudn2bcBDXgfwJmYCy+voTf3ljfwdl0xf+Z0ePAp?=
 =?us-ascii?Q?ldeBAsic3E4M19yn8Ix61eIVv0u5uOrw1yQ1dvYpVkjUZb8iBXV+THoX8fcg?=
 =?us-ascii?Q?hnzO+mHAJlzjIadHcWnjTi7M5Z493Rw7Vdi1CDIZgre7FrKhTRiy/S0JFzh3?=
 =?us-ascii?Q?+iiCMpQKztzYpsXAwdQ+XC21DH2mPq4qgkPxUv9P/IIW4L1n61DvcrYmulhy?=
 =?us-ascii?Q?ZKJ+/cVhdmOQhoablApdqPjc+DM7ru9tPCpkV1pCJk39N7oBa34Y2Chlzxvz?=
 =?us-ascii?Q?7ouY63CfNmvmW1n0sFYD4IkSM/M0ZfaJNv9YUzN/8wWp81QYBXypCh96Aivt?=
 =?us-ascii?Q?Qg+3j1idBjq/rG6EGWTHWjc251hM7nOBGhdjkDV11AV9NU58CFgsfoFmdYz7?=
 =?us-ascii?Q?hJrn4QBtZz7S2I2jQeA6CdROGIq0/8gysEFhEJRBESZND/+I07t4nwYryrY+?=
 =?us-ascii?Q?z+7PbbF/tAYS4UXSLduOGqyITjbnKENwsjvkAj+ob0s0kD/x/KsM0RXJs+Na?=
 =?us-ascii?Q?qFix5vycP634dbP6zG2M054NmjBFy9kSvK2zGcMr7es22KIR39xQbhSMcMbO?=
 =?us-ascii?Q?ap41ghZi/VPjyiC2W00dWSPCd/SWZ2RY62jw+KOLMQS2VFYs8OKmJ8/2xb0X?=
 =?us-ascii?Q?4FLu1naeNOiedl+tS1W6qBQXnaKnY2S42bGANw6Qu+9rndSaOpI0gv8oqFwH?=
 =?us-ascii?Q?6MyXWFFNHSwwrtGJp3+0t/5LumhtA5Fk/sZMYKQ6TAt6DucRhbB9Gd0PiLTX?=
 =?us-ascii?Q?+pXRLbRwspPwVLr+4CyXpNNCjQUes2FhexFy263KY7PRZ+3a5qhBhAz77xgM?=
 =?us-ascii?Q?r4iMIJ2fsdfdORZ71TzFXRLoDGKUqGJOXM3P/cFxAJKzcRMoAPKBHYEccceV?=
 =?us-ascii?Q?z+3GM4gEah6PMsQe9etKn1TMOO8nu0KxnUECYxeAWm1q9umwBFyw+AckfyPC?=
 =?us-ascii?Q?hzRPycgIPfmJWt8jFoJhqCuLquU91PZymO3x2i5YsFYi6WV9Amw8Vc34EJwq?=
 =?us-ascii?Q?N6pGtvk8VtKpRUf8EjJigwHoMoRiUL89Gh24SLqWWrbS82N1veFxrUMmQ29/?=
 =?us-ascii?Q?oSjSs6B5FYU1k5FPhFuOIIwAK+20pjo+0HcqRg5tUZAd+ZMUiPScoumQW7hE?=
 =?us-ascii?Q?GXdWEf1hXYikszVbEFLtYVudbLNoN/5H4EuUCmZtpP8XkBMjjkpeNwR8w/1k?=
 =?us-ascii?Q?ffqxQHhvUh0k7P67J5SISfrVRDT/Iq87hIQ4jz/IE9A7FIrwITnt7LvNlVEn?=
 =?us-ascii?Q?AqvOOCofYjz7qJvX7j7PCiCTkccNTP4wHIlevIVEZ95EUiK0cEsHkpLhw26h?=
 =?us-ascii?Q?IDGx/JQ1XDPkjCKMUQzkBnpZZbvZn1zRlpr/X8HOwqo66M/BjpzB5iMX0qbU?=
 =?us-ascii?Q?VY7CJQ7Rj4pksXam9gbqgrsKH04fW88QU/CO50yJvEDPRMkcN8ZT9QVK4khL?=
 =?us-ascii?Q?Xw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 499f6747-40fe-4d4e-359c-08dbce5f4658
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:48:00.1910
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LoeUyYLUIL9EdhFWrarzUPRu2REOT+JlTRAT87nQRx1UZ8Zpz0xA0nFfeHeD1JCQMZ8se/HBzudXXIhQX63fCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7423
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 16 Oct 2023 08:48:16 -0700 (PDT)

This adds a test for binding a Broadcast Receiver to a number of
BISes after PA sync has been established

---
 tools/iso-tester.c | 70 +++++++++++++++++++++++++++++++++-------------
 1 file changed, 51 insertions(+), 19 deletions(-)

diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index 1337229e1..ae98af775 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -412,7 +412,8 @@ struct iso_client_data {
 	uint8_t pkt_status;
 	const uint8_t *base;
 	size_t base_len;
-	bool bcast_defer_accept;
+	bool listen_bind;
+	bool pa_bind;
 };
 
 static void mgmt_debug(const char *str, void *user_data)
@@ -1143,7 +1144,7 @@ static const struct iso_client_data bcast_16_2_1_recv_defer = {
 	.recv = &send_16_2_1,
 	.bcast = true,
 	.server = true,
-	.bcast_defer_accept = true,
+	.listen_bind = true,
 };
 
 static const struct iso_client_data bcast_16_2_1_recv_defer_no_bis = {
@@ -1152,7 +1153,15 @@ static const struct iso_client_data bcast_16_2_1_recv_defer_no_bis = {
 	.defer = true,
 	.bcast = true,
 	.server = true,
-	.bcast_defer_accept = false,
+};
+
+static const struct iso_client_data bcast_16_2_1_recv_defer_pa_bind = {
+	.qos = QOS_IN_16_2_1,
+	.expect_err = 0,
+	.defer = true,
+	.bcast = true,
+	.server = true,
+	.pa_bind = true,
 };
 
 static const struct iso_client_data bcast_ac_12 = {
@@ -1996,6 +2005,7 @@ static gboolean iso_connect(GIOChannel *io, GIOCondition cond,
 	if (err < 0) {
 		tester_warn("Can't get socket option : %s (%d)",
 							strerror(errno), errno);
+		data->step = 0;
 		tester_test_failed();
 		return FALSE;
 	}
@@ -2008,6 +2018,7 @@ static gboolean iso_connect(GIOChannel *io, GIOCondition cond,
 
 	if (!ret) {
 		tester_warn("Unexpected QoS parameter");
+		data->step = 0;
 		tester_test_failed();
 		return FALSE;
 	}
@@ -2028,6 +2039,7 @@ static gboolean iso_connect(GIOChannel *io, GIOCondition cond,
 		tester_warn("Expect error: %s (%d) != %s (%d)",
 				strerror(-isodata->expect_err),
 				-isodata->expect_err, strerror(-err), -err);
+		data->step = 0;
 		tester_test_failed();
 	} else {
 		data->step--;
@@ -2279,7 +2291,7 @@ static int listen_iso_sock(struct test_data *data)
 		bacpy(&addr->iso_bc->bc_bdaddr, (void *) dst);
 		addr->iso_bc->bc_bdaddr_type = BDADDR_LE_PUBLIC;
 
-		if (!isodata->defer || isodata->bcast_defer_accept) {
+		if (!isodata->defer || isodata->listen_bind) {
 			addr->iso_bc->bc_num_bis = 1;
 			addr->iso_bc->bc_bis[0] = 1;
 		}
@@ -2382,9 +2394,28 @@ static bool iso_defer_accept(struct test_data *data, GIOChannel *io)
 	char c;
 	struct pollfd pfd;
 	const struct iso_client_data *isodata = data->test_data;
+	struct sockaddr_iso *addr = NULL;
 
 	sk = g_io_channel_unix_get_fd(io);
 
+	if (isodata->pa_bind) {
+		addr = malloc(sizeof(*addr) + sizeof(*addr->iso_bc));
+		memset(addr, 0, sizeof(*addr) + sizeof(*addr->iso_bc));
+		addr->iso_family = AF_BLUETOOTH;
+
+		addr->iso_bc->bc_num_bis = 1;
+		addr->iso_bc->bc_bis[0] = 1;
+
+		if (bind(sk, (struct sockaddr *) addr, sizeof(*addr) +
+						sizeof(*addr->iso_bc)) < 0) {
+			tester_warn("bind: %s (%d)", strerror(errno), errno);
+			free(addr);
+			return false;
+		}
+
+		free(addr);
+	}
+
 	memset(&pfd, 0, sizeof(pfd));
 	pfd.fd = sk;
 	pfd.events = POLLOUT;
@@ -2405,14 +2436,12 @@ static bool iso_defer_accept(struct test_data *data, GIOChannel *io)
 
 	data->io = io;
 
-	if (isodata->bcast) {
+	if (isodata->bcast)
 		data->io_id[0] = g_io_add_watch(io, G_IO_IN,
 					iso_accept_cb, NULL);
-		data->step++;
-	} else {
+	else
 		data->io_id[0] = g_io_add_watch(io, G_IO_OUT,
 					iso_connect_cb, NULL);
-	}
 
 	return true;
 }
@@ -2445,20 +2474,10 @@ static gboolean iso_accept_cb(GIOChannel *io, GIOCondition cond,
 		}
 
 		if (isodata->bcast) {
-			if (data->step > 1)
-				data->step--;
-			else
-				data->step++;
-
 			iso_connect(io, cond, user_data);
 
 			if (!data->step)
 				return false;
-
-			if (!isodata->bcast_defer_accept) {
-				tester_test_passed();
-				return false;
-			}
 		}
 
 		if (!iso_defer_accept(data, io)) {
@@ -2746,6 +2765,15 @@ static void test_bcast_recv(const void *test_data)
 	setup_listen(data, 0, iso_accept_cb);
 }
 
+static void test_bcast_recv_defer(const void *test_data)
+{
+	struct test_data *data = tester_get_data();
+
+	data->step = 1;
+
+	setup_listen(data, 0, iso_accept_cb);
+}
+
 static void test_connect2_suspend(const void *test_data)
 {
 	test_connect2(test_data);
@@ -3065,11 +3093,15 @@ int main(int argc, char *argv[])
 	test_iso("ISO Broadcaster Receiver Defer - Success",
 						&bcast_16_2_1_recv_defer,
 						setup_powered,
-						test_bcast_recv);
+						test_bcast_recv_defer);
 	test_iso("ISO Broadcaster Receiver Defer No BIS - Success",
 						&bcast_16_2_1_recv_defer_no_bis,
 						setup_powered,
 						test_bcast_recv);
+	test_iso("ISO Broadcaster Receiver Defer PA Bind - Success",
+					&bcast_16_2_1_recv_defer_pa_bind,
+					setup_powered,
+					test_bcast_recv_defer);
 
 	test_iso("ISO Broadcaster AC 12 - Success", &bcast_ac_12, setup_powered,
 							test_bcast);
-- 
2.39.2