Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Marcel Ziswiler <marcel@ziswiler.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     Marcel Holtmann <marcel@holtmann.org>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        linux-kernel@vger.kernel.org,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>
Subject: [PATCH] Bluetooth: hci_sync: Fix Opcode prints in bt_dev_dbg/err
Date:   Wed, 18 Oct 2023 16:47:35 +0200
Message-Id: <20231018144735.33085-1-marcel@ziswiler.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
UI-OutboundReport: notjunk:1;M01:P0:i37tXkAfYkU=;H5zXuRURrCGlWwYeSx0YbqMTSod
 Qgv6ir+k0/lTpHWMGiHA8zZvxkDTj/GrwcGQG/l4MuOdM+nvQEgdrHwFJcAXAGdrdil2PDZD4
 hKenvAlpTY8e0x5rtGb8j1zgW5sPfwfPoQx+j0WVlIp4cWgtmCtQHhVdw76XmERfY2LGMG/I9
 3NEql875tGwLCxxXt3GojURPFxxh6yHv0vJ3Yi7cT3k0784UPxihUWrE1FglCD8M+QogGGGR2
 FU3WtrSRnhPEs5MwKPfkaJ0OzwDxhF1DeCA+Wy3Yf6Ky1mSjbjbYI90aCfxo4P3x8g0ZYHLdX
 aYV2iVp1LG84XDZXgXN8hDrVVKGsiqJ05naJ6IfVw5fCPDKj+gG8VqHiU9Ke/yxCjbIhhE+TF
 qJmYXNMI+kli57LLGPYn1jKrSQtqQpHnkF1y/n/NgFTq2VWWE3XvAC+ukklokQ9X/DHj2k8K9
 1zoLp94oEHN5nYil7ZEepSr/3oDMUpMctHgHqltPprotbpAqxx4Xji1gAURB+hStmgylqqJLK
 MSgPj4ZcAcFo0PywUmvEklBr810sJ71QcmnRjhMPXY65iRSjxxNmtUtu6nM6tdA/YDEDWnIoF
 HAZ66SNdx8QIKsI7ydICEtQzpSY6IrGksJQyxk3H9iBNbol/Fmce6bC/LxK/AYfGR5nMYhXoK
 Ad49AhUcRfWee6wi1dESSdnfR/uemwlxugv8DvEREKlg25/5BSEM6gDZWH9cfRz7NLuFelyPZ
 F2Hhk+PVtj68uT9opZ8vRsr7pUYhQ7nL73ZYwHkNtyXzKJkiynzqgYgRWQtdDJJlm8BXVCSWU
 8QMLoOOAR9zMNB2tYwvVfmixmrl6u4mRYr/ke5N7Yb+3KGsyf9Q8Mu7oZAtey0na9M4LDzwpQ
 I4S6/DtgoSaE7MA==
Precedence: bulk

From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Printed Opcodes may be missing leading zeros:

	Bluetooth: hci0: Opcode 0x c03 failed: -110

Fix this by always printing leading zeros:

	Bluetooth: hci0: Opcode 0x0c03 failed: -110

Fixes: d0b137062b2d ("Bluetooth: hci_sync: Rework init stages")
Fixes: 6a98e3836fa2 ("Bluetooth: Add helper for serialized HCI command execution")

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

 net/bluetooth/hci_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index d06e07a0ea5a..2c782b6a274d 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -152,7 +152,7 @@ struct sk_buff *__hci_cmd_sync_sk(struct hci_dev *hdev, u16 opcode, u32 plen,
 	struct sk_buff *skb;
 	int err = 0;
 
-	bt_dev_dbg(hdev, "Opcode 0x%4x", opcode);
+	bt_dev_dbg(hdev, "Opcode 0x%4.4x", opcode);
 
 	hci_req_init(&req, hdev);
 
@@ -248,7 +248,7 @@ int __hci_cmd_sync_status_sk(struct hci_dev *hdev, u16 opcode, u32 plen,
 	skb = __hci_cmd_sync_sk(hdev, opcode, plen, param, event, timeout, sk);
 	if (IS_ERR(skb)) {
 		if (!event)
-			bt_dev_err(hdev, "Opcode 0x%4x failed: %ld", opcode,
+			bt_dev_err(hdev, "Opcode 0x%4.4x failed: %ld", opcode,
 				   PTR_ERR(skb));
 		return PTR_ERR(skb);
 	}
-- 
2.36.1