Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>
To:     Marcel Ziswiler <marcel@ziswiler.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
CC:     Sherry Sun <sherry.sun@nxp.com>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Amitkumar Karwar <amitkumar.karwar@nxp.com>,
        =?iso-8859-1?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Subject: RE: [PATCH v1 2/2] Bluetooth: btnxpuart: Fix nxp_setup
Thread-Topic: [PATCH v1 2/2] Bluetooth: btnxpuart: Fix nxp_setup
Thread-Index: AQHaAdfPhxwnTSjaME+BxwuoDPsj6w==
Date:   Wed, 18 Oct 2023 15:28:57 +0000
Message-ID: <AM9PR04MB860351E818A6DD715A7F88FDE7D5A@AM9PR04MB8603.eurprd04.prod.outlook.com>
References: <20231018145540.34014-1-marcel@ziswiler.com>
 <20231018145540.34014-3-marcel@ziswiler.com>
In-Reply-To: <20231018145540.34014-3-marcel@ziswiler.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?CqTUmwK7KCqNK//I2OqlAon6rm/xf8ThJu8ZAMWLfKUTLxQLCcme0uOmQx?=
 =?iso-8859-1?Q?U1uhXQicH0BuitNlhJXuOSRTBbtz7SsJBnznPMfcV4+Ax/gb7mmWqrO1+P?=
 =?iso-8859-1?Q?01MUs0ja3OUQ9KUwOk00W166IOEwEdGGwFQUwpGrq2pvMRaEXvABGibU2t?=
 =?iso-8859-1?Q?oglqooWU6tIbDMh0/e6nFJbwNE6JHLyRaHvrFYDY7OlMk0ntoj05PoBcXf?=
 =?iso-8859-1?Q?Fj0YC1PIrkD2hgo9vZynXdOOErz1A+X16ZQE7l+AlJxds437UbNNeDTHnJ?=
 =?iso-8859-1?Q?0j1m/Crmeuq8E/qGz340kO35Bxu5JVnKYiS0jaoGaavNpmJIYLhVbktJDp?=
 =?iso-8859-1?Q?hM4yscmIk+uRekkOs5Nf86hTaTRWXlkmIl6xFs9Eh2bIg1ujpuPp4RQP0h?=
 =?iso-8859-1?Q?0JUrnheRAuyM3Pv4oTpAZYkNN3yZDqwjQQQFPpKX5XxwsGAl1Yy3r6q/GI?=
 =?iso-8859-1?Q?NfEvThLt1Jl4nw0tCWDNESOWvCn9H726fzXdu5eaST5TJtmEtM5xhWqVcx?=
 =?iso-8859-1?Q?0WCCkFtK2ltA5W75giySlleX8p0nbeboiXxmai46p1M3FZNEPPWk26D20z?=
 =?iso-8859-1?Q?tQVeIAVfpDX5nLNRVtItrtbBT13cOaiQolnoKf9ZXCm5fZ4pIP1D4KNl3t?=
 =?iso-8859-1?Q?Y22ZzcwNl2TeI9vqF3NPq/2eGvoAuuOj18sXAEP3gtOisSChtqy3u0sX2l?=
 =?iso-8859-1?Q?rW0Szt2gGfD/Qc6qJ1viQLu8mA7M7DqkfnFjdEW3hC9cz9Fe/YUbjNSYhh?=
 =?iso-8859-1?Q?4Xh+93WWpm/tNV70dF2IYGwGtjjafN4NrbcLNRQqRwkpka1h1CtZB1ztPV?=
 =?iso-8859-1?Q?PEjE71mK27H/WX66NQLOAx8s3RSTnKsfi/M+olpIa/oWEfkYLdltEekGDB?=
 =?iso-8859-1?Q?nmxQTKwIMvHtH4vZAyLw/9KjKFYP4qKwPFkcsCMOxZrx9CLRRfHOnHGgPM?=
 =?iso-8859-1?Q?yvzm7zl1nNOW+yaqlMMvKK9c05g7R6gJYGTKjK+ETrTfkfZwxUSrdRLMzo?=
 =?iso-8859-1?Q?OM2pMgH1cDUFiQ/RC/YSkXw3r8/sBitA0ygA6n0hYa8y7LXdKbuGE3A1D7?=
 =?iso-8859-1?Q?uFWmXdNNoo2u4ohrFtYi5gIeZWRmviutZsCyRC5GMYy9kp69lUik7u9yvk?=
 =?iso-8859-1?Q?YUIcJpR50AgRvB2k4ius9REm1O3dCURT8HCFB4K6wtUq+wrDJ0NaBWo47h?=
 =?iso-8859-1?Q?QlJ+hXqg/S39ch6bLPFPSZdWQt9//Q6GCSDJnQG5sbk21HpBq0eu75XSVq?=
 =?iso-8859-1?Q?R18vwlRKPuOC+KSF/U859Zd2O8LweYw4J9kPfpH5VYfr/P12nQWzjzDD9H?=
 =?iso-8859-1?Q?IURP3bDsOMItEYgoXa9+2RiqHeBSb6bAMaHd/uh7w0KlegoJzxULdQH24p?=
 =?iso-8859-1?Q?5anoD5sEFV/aM6nJYWu/eC8lb1C6zX/WM4XCNvaP1FstIm7RJJtccTSIA1?=
 =?iso-8859-1?Q?WyPW14KofB/tZvoXPBsHmbeUDlDJW4+uUDIXD9tZ8uEv9eleVnSktIxJjh?=
 =?iso-8859-1?Q?Gsvm210ObVULeZ/exJ/s5BHJdHUKY6bSXBzGRBfK8xYURJEdTlvAg9D1zF?=
 =?iso-8859-1?Q?I3SIYQU4yABtHnJEh9DrRWzRS2vrZDfSfew+IyeyUqV8RXEM8oE7S9S9+f?=
 =?iso-8859-1?Q?kMvfM1PXulPyRPLM0bIW9VnCWn6AKKQC3Q?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cf3213e-84d3-453a-c3b3-08dbcfeef256
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2023 15:28:57.7544
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FX7qb32o0+F23GsGRT53uqsYA3PlQQhrAqjLkTlLmYayiaRQLEcboa/FBX/f045YdK9d+z/Krbg4stjvmJjoBmCh6BqAT4iRkQu2y1eTgMg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB10041
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 18 Oct 2023 08:29:14 -0700 (PDT)

Hi Marcel,

Thank you for your patch. This change looks good to me.

I think the scenario you are testing/resolving is:
1) Load btnxpuart.ko first (which "may" load BT-only FW if chip is powered =
on)
2) Power cycle or power on chip
3) Load WLAN driver with combo FW
Right?

Thanks,
Neeraj

> From: Marcel Ziswiler <marcel@ziswiler.com>
> Sent: Wednesday, October 18, 2023 8:26 PM
> To: linux-bluetooth@vger.kernel.org
> Cc: Sherry Sun <sherry.sun@nxp.com>; Johan Hedberg
> <johan.hedberg@gmail.com>; Luiz Augusto von Dentz
> <luiz.dentz@gmail.com>; Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>;
> linux-kernel@vger.kernel.org; Marcel Holtmann <marcel@holtmann.org>;
> Marcel Ziswiler <marcel.ziswiler@toradex.com>; Amitkumar Karwar
> <amitkumar.karwar@nxp.com>; Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.co=
m>
> Subject: [PATCH v1 2/2] Bluetooth: btnxpuart: Fix nxp_setup
>=20
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>=20
> Unfortunately, nxp_setup() may inadvertently assume that the firmware is
> already running while the module is not even powered yet.
> Fix this by waiting up to 10 seconds for the CTS to go up as the combo
> firmware might be loaded by the Wi-Fi driver over SDIO (mwifiex_sdio).
>=20
> Fixes: 689ca16e5232 ("Bluetooth: NXP: Add protocol support for NXP
> Bluetooth chipsets")
>=20
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>=20
> ---
> This is what may happen without this fix:
> [  284.588177] Bluetooth: hci0: Opcode 0x0c03 failed: -110 [  286.636167]
> Bluetooth: hci0: Setting wake-up method failed (-110) Unfortunately, even
> re-loading the btnxpuart kernel module would not recover from this
> condition.
>=20
>  drivers/bluetooth/btnxpuart.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>=20
> diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.=
c
> index 9cb7529eef09..4b83a0aa3459 100644
> --- a/drivers/bluetooth/btnxpuart.c
> +++ b/drivers/bluetooth/btnxpuart.c
> @@ -1021,6 +1021,16 @@ static int nxp_setup(struct hci_dev *hdev)
>                 if (err < 0)
>                         return err;
>         } else {
> +               /* The combo firmware might be loaded by the Wi-Fi driver=
 over
> SDIO (mwifiex_sdio).
> +                * We wait up to 10s for the CTS to go up. Afterwards, we=
 know that
> the firmware is
> +                * really ready.
> +                */
> +               err =3D serdev_device_wait_for_cts(nxpdev->serdev, true, =
10000);
> +               if (err) {
> +                       bt_dev_err(nxpdev->hdev, "Wait for CTS failed wit=
h %d", err);
> +                       return err;
> +               }
> +
>                 bt_dev_dbg(hdev, "FW already running.");
>                 clear_bit(BTNXPUART_FW_DOWNLOADING, &nxpdev->tx_state);
>         }
> --
> 2.36.1