Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>
To:     Marcel Ziswiler <marcel@ziswiler.com>,
        "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
CC:     Sherry Sun <sherry.sun@nxp.com>,
        Johan Hedberg <johan.hedberg@gmail.com>,
        Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Amitkumar Karwar <amitkumar.karwar@nxp.com>,
        =?iso-8859-1?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Subject: RE: [PATCH v1 1/2] Bluetooth: btnxpuart: Fix btnxpuart_close
Thread-Topic: [PATCH v1 1/2] Bluetooth: btnxpuart: Fix btnxpuart_close
Thread-Index: AQHaAdjuQ/qnXuu8r0O7wyQJSQHZ2A==
Date:   Wed, 18 Oct 2023 15:36:58 +0000
Message-ID: <AM9PR04MB8603471C0C4BF61CC3AA3BF5E7D5A@AM9PR04MB8603.eurprd04.prod.outlook.com>
References: <20231018145540.34014-1-marcel@ziswiler.com>
 <20231018145540.34014-2-marcel@ziswiler.com>
In-Reply-To: <20231018145540.34014-2-marcel@ziswiler.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?kQ0KgvV5+WGaFIN06F1no6C9LG3PdgoEYhRcH5sRYapI7a+s+Qje+nW77j?=
 =?iso-8859-1?Q?F3F9Doo4aQ7OSGbMilLja9ZOgJj6vpktOXyks1IOK3Q9Z+hgSu5vUp+vXz?=
 =?iso-8859-1?Q?SdYLojCWlMbPG3jxSElUnt+w9E4JVAH+cqFqSOCno2Rd39Js4w6uEhLH74?=
 =?iso-8859-1?Q?N9XjezgkaE400OcLnJX+bvjOzrhU+D8Dw1Vj8+FIKuZjebqdnS50vj7Tqc?=
 =?iso-8859-1?Q?dFWQO7zXqR0LqOTBbAPgt3DHVrqFCTAvaPk68yiw7QDQzFaDwXv+Zdqqr6?=
 =?iso-8859-1?Q?tFRQsXd5/NF7M2e2WtXzrEXDaWbUs5QC0fN6Xx5XthgHH74hgCca60Kex1?=
 =?iso-8859-1?Q?4kb9JH+D1DUy8bEQSLZwQesW7i4QhQnxwUVfqIL7JEY0NEmYUaDm808WqP?=
 =?iso-8859-1?Q?FQSDMKOjEgPKSPw5HOf1AKGBvIc/lw60v5nYeOZZY7Fl1q8MFa4p2ygmD5?=
 =?iso-8859-1?Q?/R6/aw7yiYptmOYjSkV3OEUa5YnumnoB8syRYYeCGroFBvn8zCcDINsI6z?=
 =?iso-8859-1?Q?k0Jx7ctNi5Rk66QGILxTvc9wKY1Zq/X9ZjyXn+S4ck1Rwt7eF7rItq4ZJh?=
 =?iso-8859-1?Q?X3jQS0AoEbGYYqeEvSReVlrQT3Phys8l5JScZYc4zCodk5TsYLsDHtE+yM?=
 =?iso-8859-1?Q?C+jiWcTxzOpyFKAyTaLjC3Nh1EFAXctxQ4NBC0CJoerGAprD42h+KpCw5A?=
 =?iso-8859-1?Q?PEdAuGonGNIl5n+1H6ZssuzQoz1xxZnBd5qp7Xlp3tHuL+q32N0IQfvDYy?=
 =?iso-8859-1?Q?CBzrQaW+sU/76vZh7BazLpY4zsxy7Tm7L1jR8AcEaUCBZrGszeFo/VD7yH?=
 =?iso-8859-1?Q?29b/g7PrbCe7em3x6oP/7ENBY+cCZSOJEE8Gg4g6QJmGE+N/ufJRqXKPFX?=
 =?iso-8859-1?Q?apvKM3B3meH0wu48CQVxzXblEk1AYzZ3ui+F25PJDy9TQ48u2Tl5/qNi/8?=
 =?iso-8859-1?Q?Hk5vQ3E64KMEekvPsZnU1e1SLZDoua19rxIk1FOv7H8GYvLqNcRxMzUncu?=
 =?iso-8859-1?Q?iJZvCaR6WbEhCP1kFpnC95EcQiDwBW8xpxMSMncTKF2CtFuP24mdRsjF/l?=
 =?iso-8859-1?Q?C6tIwgDgrjeSrv27t6pvUtWrjKIn4zUji/A/9aE7XyxSC88Ou9bjl3mBFi?=
 =?iso-8859-1?Q?h6F6riakUBqmT/4ay6DBmgGOME91hK4GAruz6jax63w4jFJpFOvVDxLIyX?=
 =?iso-8859-1?Q?XorKigoB4geeKFT8pdpMPDh88NV+TwANP++JrCGIeyS8anTxg5LSCfUwhM?=
 =?iso-8859-1?Q?uLcVQmfFw8h1vQ9eutZgbYL3fl1ktNabLp1/2/Ho8k4v0KTkbaD+kduAdq?=
 =?iso-8859-1?Q?zoeJwHU+NBXDqRftSrJoS0A1lv6gK7ttW6QFFa9HRDOrT0I8QUc12/70g5?=
 =?iso-8859-1?Q?lA8V7LXOLFXe/feuiTHi4nl3DfUJcX1v3AzQiGfmmZt3kgfJSu7lTO0wJ4?=
 =?iso-8859-1?Q?XXOOxfloDafvYAS7/+outilh9Ibf1HITevjI+mPbCSSm2xkP3MqGyLbt6v?=
 =?iso-8859-1?Q?Th3F9XJM4GKEPSnW8l9/6V9pqgaZCrcHW1RkpTbgjCIuCLdThI7E1EUwAl?=
 =?iso-8859-1?Q?ChBojaSeOY0jVQbkpC1TCVkEnC43nRCcexTlF+MwYNQ7Ksr0+NQQRHVKls?=
 =?iso-8859-1?Q?QFC8dlUZWzuHxF809zYSk8nCZrOwSJiX50rJmK4iWd1aPhUbIQNb03hg?=
 =?iso-8859-1?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8603.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ecdccc4d-924b-4ac8-5302-08dbcff010cc
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Oct 2023 15:36:58.3432
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nEUk6vSMifpsjXZJQksK2Pou7MzFvGqzUiVJeh/LfZ+cqytFpAMCB6gbotFVg4YofE18QKciztBiFwwVS0h4Xji3zEjFb06E2VkDkewQ+Ew=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7337
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 18 Oct 2023 08:37:05 -0700 (PDT)

Hi Marcel,

Thank you for your patch.

> From: Marcel Ziswiler <marcel@ziswiler.com>
> Sent: Wednesday, October 18, 2023 8:26 PM
> To: linux-bluetooth@vger.kernel.org
> Cc: Sherry Sun <sherry.sun@nxp.com>; Johan Hedberg
> <johan.hedberg@gmail.com>; Luiz Augusto von Dentz
> <luiz.dentz@gmail.com>; Neeraj sanjay kale <neeraj.sanjaykale@nxp.com>;
> linux-kernel@vger.kernel.org; Marcel Holtmann <marcel@holtmann.org>;
> Marcel Ziswiler <marcel.ziswiler@toradex.com>; Amitkumar Karwar
> <amitkumar.karwar@nxp.com>; Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.co=
m>
> Subject: [PATCH v1 1/2] Bluetooth: btnxpuart: Fix btnxpuart_close
>=20
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>=20
> Unfortunately, btnxpuart_close() may trigger a BUG: scheduling while atom=
ic.
> Fix this by properly purging the transmit queue and freeing the receive s=
kb.
>=20
> Fixes: 689ca16e5232 ("Bluetooth: NXP: Add protocol support for NXP
> Bluetooth chipsets")
>=20
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
>=20
>  drivers/bluetooth/btnxpuart.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.=
c
> index b7e66b7ac570..9cb7529eef09 100644
> --- a/drivers/bluetooth/btnxpuart.c
> +++ b/drivers/bluetooth/btnxpuart.c
> @@ -1234,6 +1234,9 @@ static int btnxpuart_close(struct hci_dev *hdev)
>=20
>         ps_wakeup(nxpdev);
>         serdev_device_close(nxpdev->serdev);
> +       skb_queue_purge(&nxpdev->txq);
> +       kfree_skb(nxpdev->rx_skb);
> +       nxpdev->rx_skb =3D NULL;
>         clear_bit(BTNXPUART_SERDEV_OPEN, &nxpdev->tx_state);
>         return 0;
>  }
This is already done in btnxpuart_flush(), which is called by hci_dev_close=
_sync(), before it calls btnxpuart_close().
Is btnxpuart_flush() not called during your testing?

Thanks,
Neeraj