Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <b934f6b3-ebce-4370-9a97-610fc2aa18fc@molgen.mpg.de>
Date:   Thu, 19 Oct 2023 10:06:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH BlueZ v1 1/1] gobex/gobex.c : Changed default obex timeout
Content-Language: en-US
To:     Purendra-Singh <purendra.singh@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org, devyani.godbole@nxp.com,
        nitin.jadhav@nxp.com, luiz.dentz@gmail.com
References: <20231019071651.4773-1-purendra.singh@nxp.com>
 <20231019071651.4773-2-purendra.singh@nxp.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20231019071651.4773-2-purendra.singh@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Purendra-Singh,


Thank you for your patch.

Am 19.10.23 um 09:16 schrieb Purendra-Singh:
> Description: File received status of some reference devices
> is delayed, that causes timeout and file transfer status error.

Some formal issues:

1.  Please remove the redundant *Description* at the beginning.
2.  Do you only have “one” name, or is the transcription(?) spelled 
without a hyphen/minus: Purendra Singh?
3.  Please be more specific in the commit messages summary/title. Maybe:

     > gobex: Increase default obex timeout from 10 ms to 500 ms

Most importantly, why did you pick 500 ms, and what reference device is 
it? (What chipset for example?)

> ---
>   gobex/gobex.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gobex/gobex.c b/gobex/gobex.c
> index e9b89cead..f0e1c2c83 100644
> --- a/gobex/gobex.c
> +++ b/gobex/gobex.c
> @@ -22,7 +22,7 @@
>   #define G_OBEX_MINIMUM_MTU	255
>   #define G_OBEX_MAXIMUM_MTU	65535
>   
> -#define G_OBEX_DEFAULT_TIMEOUT	10
> +#define G_OBEX_DEFAULT_TIMEOUT	500
>   #define G_OBEX_ABORT_TIMEOUT	5
>   
>   #define G_OBEX_OP_NONE		0xff


Kind regards,

Paul