Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <2a7c1af7-5477-4736-9eb0-3347672b4601@molgen.mpg.de>
Date:   Thu, 19 Oct 2023 12:31:03 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Bluetooth: btusb: Add return error code
Content-Language: en-US
To:     Youwan Wang <youwan@nfschina.com>
Cc:     marcel@holtmann.org, linux-bluetooth@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231019023953.218624-1-youwan@nfschina.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20231019023953.218624-1-youwan@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Youwan,


Thank you for your patch.

It’d be great, if you versioned your patches. For example:

     git format-patch -v3 …

Am 19.10.23 um 04:39 schrieb king:
> From: youwan Wang <youwan@nfschina.com>
> 
> Signed-off-by: youwan Wang <youwan@nfschina.com>

It’d be great if you started the first name with an uppercase letter too.

Despite patch diff stats being small and the patch probably trivial, 
it’s common practice to state the motivation for the change nevertheless 
in the commit message body.

> ---
>   drivers/bluetooth/btusb.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index b8e9de887b5d..ec6bdc9687b1 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2826,8 +2826,10 @@ static int btusb_mtk_hci_wmt_sync(struct hci_dev *hdev,
>   		goto err_free_wc;
>   	}
>   
> -	if (data->evt_skb == NULL)
> +	if (data->evt_skb == NULL) {
> +		err = -ENOBUFS;
>   		goto err_free_wc;
> +	}
>   
>   	/* Parse and handle the return WMT event */
>   	wmt_evt = (struct btmtk_hci_wmt_evt *)data->evt_skb->data;


Kind regards,

Paul