Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <4cf2cb28-b334-487b-96d6-6318961035e1@molgen.mpg.de>
Date:   Fri, 20 Oct 2023 11:44:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH BlueZ v2 1/1] gobex/gobex.c : Increase default obex
 timeout from 10 sec to 500 sec
Content-Language: en-US
To:     Purendra Singh <purendra.singh@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org, devyani.godbole@nxp.com,
        nitin.jadhav@nxp.com, luiz.dentz@gmail.com
References: <20231020093716.9654-1-purendra.singh@nxp.com>
 <20231020093716.9654-2-purendra.singh@nxp.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20231020093716.9654-2-purendra.singh@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Purendra,


Thank you for sending version 2. (No space is necessary in the prefix 
before the colon.)


Am 20.10.23 um 11:37 schrieb Purendra Singh:
> This issue is observed when multiple profiles are active from
> multiple connected devices: A2DP + HID + OBex File transfer
> 
> File received status of some reference devices is delayed,
> that causes timeout and file transfer status error (Variation
> of timeout is between ~100 seconds to ~450 seconds).
> 
> We tested with Motorola Edge, Samsung M33, OnePlus 6T.
> 
> Experimentaly we increased the timeout and at 500 seconds no issue was

Experimentally

> observed.

Oh, it’s really seconds. Isn’t greater than 8 minute timeout *not* very 
user friendly?

> ---
>   gobex/gobex.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gobex/gobex.c b/gobex/gobex.c
> index e9b89cead..f0e1c2c83 100644
> --- a/gobex/gobex.c
> +++ b/gobex/gobex.c
> @@ -22,7 +22,7 @@
>   #define G_OBEX_MINIMUM_MTU	255
>   #define G_OBEX_MAXIMUM_MTU	65535
>   
> -#define G_OBEX_DEFAULT_TIMEOUT	10
> +#define G_OBEX_DEFAULT_TIMEOUT	500
>   #define G_OBEX_ABORT_TIMEOUT	5
>   
>   #define G_OBEX_OP_NONE		0xff


Kind regards,

Paul