Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   Iulia Tanasescu <iulia.tanasescu@nxp.com>
To:     luiz.dentz@gmail.com
Cc:     andrei.istodorescu@nxp.com, claudia.rosu@nxp.com,
        iulia.tanasescu@nxp.com, linux-bluetooth@vger.kernel.org,
        mihai-octavian.urzica@nxp.com, silviu.barbulescu@nxp.com,
        vlad.pruteanu@nxp.com
Subject: Re: [PATCH BlueZ 1/4] btio: Handle closed channel in server_cb
Date:   Wed, 25 Oct 2023 17:55:26 +0300
Message-Id: <20231025145526.3027-1-iulia.tanasescu@nxp.com>
In-Reply-To: <CABBYNZJ21w6h_hvBWsEwwDTevYqiZqY7oOOf8oEXDRmDPxmHYA@mail.gmail.com>
References: <CABBYNZJ21w6h_hvBWsEwwDTevYqiZqY7oOOf8oEXDRmDPxmHYA@mail.gmail.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?elRxrohS2qdoIQlRK3gdV6SViy3qhIELO/HdJSvivvd3FP9XSjcDE1v9LVzz?=
 =?us-ascii?Q?1T6xz6cHKI9v+jE4339pNTjUEEZDnyUIYvWTizfqCeFNv6EYdcIYrMapNo4v?=
 =?us-ascii?Q?2Jqo+N35MnSJz3MyH7tQqhfin133uPHKReF2vJJRizEJHJqqfz7SuSBBlptm?=
 =?us-ascii?Q?4e/fLYa26/nTNHmR3s5wLCBt2vPrstORCWitSk5PvSx8peEyrSp1AWkeik6l?=
 =?us-ascii?Q?k46RhLnZs3lGZ0APtOPHvH9IgD6v3kdmjM1xv7rgKCIIlN/oZxJEEQxP1Lz2?=
 =?us-ascii?Q?Q/X5QOYs7SRhJP7l38oBRN9kk/EeZ055xpOxCyzjsq5YVRFknD5PVLV13Ilq?=
 =?us-ascii?Q?QqugZutOCjJQOFFbtSeQ8nIsC1dBhnRDIoaDjw3B7i7bR7jTGoBOsUc4Y1CK?=
 =?us-ascii?Q?G3HDKUKZ6piziz0Q77IpO/KGtI1ksssYiLS45ksENxJTCdzff5H3psqr+dcY?=
 =?us-ascii?Q?Z0ECO+OYRIOuWrnsC7g3z30xLxz2wYuzIMNNt5GkllOr7vnMLmKkdJDVybxF?=
 =?us-ascii?Q?w+ASbHg7N8l0LW2HzjtVchDeO2MJ8FXSYF6Z6EIl8aD1nAv1EdxahhGuQXj4?=
 =?us-ascii?Q?LCsxx1S++cvyRmQC3sje+MpmQOuCmZUYrmxcVfgUA0f7giD/oMR0iBmmT1FG?=
 =?us-ascii?Q?HHwIUx/SM0gU+lO5T2OCGL9LzY2ldIvCZ0KteQ4DDLVkYqHirG+1Qd0Lzqs4?=
 =?us-ascii?Q?OVtyEgqWTdO7PjSoG1d2YdkAJgnU20Dj9fySf0shOTzUSwwn/xeIjfumU9cc?=
 =?us-ascii?Q?T9Fpy2SxXnyT2A/oW7kCRUhEQrU5jQORn9RG6NjX90vhLi5JgAFx/NX6ys9G?=
 =?us-ascii?Q?iZ3T/3dwl1gKI4ZruHzyAmQRQJW4Ou7Z/zrSAFATcCh8xHKSuwTcW3dnw6UT?=
 =?us-ascii?Q?kZlomldcWhdXCwfCNslInHK4SJtZL5gyrWEo2sWfANO/hu8qMWj/bMtuQbcW?=
 =?us-ascii?Q?azSt53pTLqN/1/RmRlimOKvGOp1KJdfQqHH9xdwIRFawSpjI9c/7q+ox3bdL?=
 =?us-ascii?Q?Dshl3M550lmyBaXrm7lxDd/UehY0XNPBYS4SNiR1CGdxBgnvs5Lv4du0A1ng?=
 =?us-ascii?Q?Gw9u4CuxrhYmfEQLubwwcJjsYthVnQ1rjtzy15MCsQFO9xwul3B+RRjL0XAC?=
 =?us-ascii?Q?/NdLWT8BmmPueJ0G0+a0UPNv08oMhQzyek7oBGzwL9/6dffNcKfhsCe0I3JP?=
 =?us-ascii?Q?D0P93frG93hSDYRCOuCboQGys2AUScm6mFCl6/NrjTdjbsSNGxdCvDT82Cpk?=
 =?us-ascii?Q?rh78LnnYQqG39dj1pjpUPg64/m0waXGskbFgcFpmLhNB9dZwmRW5VXKXciVm?=
 =?us-ascii?Q?B+e7jy7o/TbEYX+9zw5P3xFZv8DMTLTYK4XQQ/0HP/QEbr5GsYg9tOQrlxav?=
 =?us-ascii?Q?B9ZlQN97L1AaZmz+P+QeN0kpdKGFii0qyIUEykgtBvNkuRLIJQYWp3fi1rA9?=
 =?us-ascii?Q?5824+m7AE2SFIqMgTtLC5IK1/QRHicrkdOx9rqjnA0g+r+H9H+hcwGiernk/?=
 =?us-ascii?Q?ZGwSgXyUTLALxRF5Csd74vDtVCqqvxKgrJm1LjYXuFb607HKpRI/FAyENQLl?=
 =?us-ascii?Q?Lr4lrfmt1SSjNFYXj+nYEFi/3kohQDgKa+4lp8kHyNp8MBpDEY9nWy5t+7T9?=
 =?us-ascii?Q?7Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fe540ba-5492-43da-c019-08dbd56a6d70
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8898.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 14:55:28.3570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2RnZ3H0n6ssgMUwlBlQftli141LHivdsME3NZXGbRX8Rv3kCOWBmVZVqv/TgydJ3qD/fDO8R4fvdP0t2Yplf7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7614
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-bluetooth.vger.kernel.org>
X-Mailing-List: linux-bluetooth@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 25 Oct 2023 07:55:35 -0700 (PDT)

Hi Luiz,

> -----Original Message-----
> From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Sent: Monday, October 16, 2023 8:01 PM
> To: Iulia Tanasescu <iulia.tanasescu@nxp.com>
> Cc: linux-bluetooth@vger.kernel.org; Claudia Cristina Draghicescu
> <claudia.rosu@nxp.com>; Mihai-Octavian Urzica <mihai-
> octavian.urzica@nxp.com>; Silviu Florian Barbulescu
> <silviu.barbulescu@nxp.com>; Vlad Pruteanu <vlad.pruteanu@nxp.com>;
> Andrei Istodorescu <andrei.istodorescu@nxp.com>
> Subject: Re: [PATCH BlueZ 1/4] btio: Handle closed channel in server_cb
> 
> Hi Iulia,
> 
> On Mon, Oct 16, 2023 at 8:49 AM Iulia Tanasescu <iulia.tanasescu@nxp.com>
> wrote:
> >
> > This handles G_IO_ERR and G_IO_HUP conditions in server_cb
> >
> > ---
> >  btio/btio.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/btio/btio.c b/btio/btio.c index d45b8240d..c63a6d1df
> > 100644
> > --- a/btio/btio.c
> > +++ b/btio/btio.c
> > @@ -247,7 +247,8 @@ static gboolean server_cb(GIOChannel *io,
> GIOCondition cond,
> >         GIOChannel *cli_io;
> >
> >         /* If the user closed the server */
> > -       if ((cond & G_IO_NVAL) || check_nval(io))
> > +       if ((cond & (G_IO_NVAL | G_IO_ERR | G_IO_HUP)) ||
> > +                       check_nval(io))
> 
> I believe this was done on purpose to only check for NVAL, the other
> conditions shall probably be notified back via callback so it can process the
> error reported.
> 

It seems that server_cb is supposed to accept an incoming connection on
server io and pass the child io through the confirm or connect callbacks.
But if the condition is G_IO_HUP for example, we shouldn't get to the point
of calling accept.

> >                 return FALSE;
> >
> >         srv_sock = g_io_channel_unix_get_fd(io);
> > --
> > 2.39.2
> >
> 
> 
> --
> Luiz Augusto von Dentz

Regards,
Iulia