Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
MIME-Version: 1.0
References: <20231026145047.4637-1-silviu.barbulescu@nxp.com>
In-Reply-To: <20231026145047.4637-1-silviu.barbulescu@nxp.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Thu, 26 Oct 2023 14:32:01 -0700
Message-ID: <CABBYNZ+nFSYXca2izExm0c=-ao2K211O50GzS2EQhZCRHzUHrA@mail.gmail.com>
Subject: Re: [PATCH 0/6] Add support for multiple BISes
To:     Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>
Cc:     linux-bluetooth@vger.kernel.org, claudia.rosu@nxp.com,
        mihai-octavian.urzica@nxp.com, vlad.pruteanu@nxp.com,
        andrei.istodorescu@nxp.com, iulia.tanasescu@nxp.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Silviu,

On Thu, Oct 26, 2023 at 7:51=E2=80=AFAM Silviu Florian Barbulescu
<silviu.barbulescu@nxp.com> wrote:
>
> Add support for multiple BIS-es
> How to configure multiple BIS-es:
> In main.conf set the number of required BISes in NumberOfBISes field of
> the newly added Bcast section.
> In the base_lc3_48_4_1 struct set the configuration for the base
> Continue with the registering endpoint for the broadcast source
> endpoint.register 00001852-0000-1000-8000-00805f9b34fb 0x06
> Use the endpoint.config command to set the BIS codec configuration by
> specifying the BIS when prompted by the command
> endpoint.config /org/bluez/hci0/pac_bcast0 /local/endpoint/ep0 48_4_1
> [/local/endpoint/ep0] BIG (value): 0
> [/local/endpoint/ep0] BIS (value): 1
> Use this endpoint config command to configure all the BISes
> After all BISes are configured, use the transports to send data

Don't think it is a good idea to use main.conf for entering this, in
fact I think we should get rid of BIS and instead have it as number of
BIS because we no longer use the BIS ID as Adv Set ID, or perhaps we
can use the max transport as number of BIS since each BIS shall have a
correspondent transport/socket, either way it shall be the upper layer
that defines how many BIS to configure.

>
> Claudia Draghicescu (2):
>   bap: Fix source+sink endpoint registration
>   bap: Fix source+sink endpoint registration
>
> Silviu Florian Barbulescu (4):
>   src: Add support for defining the number of BISes in the main.conf
>   Add support for multiple BISes
>   profiles/audio/transport.c: Add support for multiple BISes
>   client/player.c: Add support for multiple BISes
>
>  btio/btio.c                |   4 +-
>  client/player.c            |  57 ++++-
>  profiles/audio/bap.c       | 483 +++++++++++++++++++++++++------------
>  profiles/audio/media.c     |   3 +-
>  profiles/audio/transport.c |  49 ++--
>  src/btd.h                  |   6 +
>  src/main.c                 |  10 +
>  src/main.conf              |   8 +
>  src/shared/bap.c           | 254 ++++++++++++++-----
>  src/shared/bap.h           |  39 ++-
>  unit/test-bap.c            |  12 +-
>  11 files changed, 678 insertions(+), 247 deletions(-)
>
>
> base-commit: 00fdb61d56161f523e975b4c044030f4b40abb6d
> --
> 2.39.2
>


--=20
Luiz Augusto von Dentz