Received-SPF: pass (google.com: domain of linux-bluetooth-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <1699251565-28759-1-git-send-email-quic_zijuhu@quicinc.com>
In-Reply-To: <1699251565-28759-1-git-send-email-quic_zijuhu@quicinc.com>
From:   Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date:   Mon, 6 Nov 2023 11:16:02 -0500
Message-ID: <CABBYNZK6UNm9SWhmJtvp-bzObTk-UR7GhK2U16ffFEe-bdpOoA@mail.gmail.com>
Subject: Re: [PATCH v1 0/2] Bluetooth: Support SCO offload for QCA2066
To:     Zijun Hu <quic_zijuhu@quicinc.com>
Cc:     marcel@holtmann.org, johan.hedberg@gmail.com,
        linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Mon, Nov 6, 2023 at 1:19=E2=80=AFAM Zijun Hu <quic_zijuhu@quicinc.com> w=
rote:
>
> This patch series are to support SCO offload for QCA2066, ALL BTHOST
> needs to do is specifying both Input_Data_Path and Output_Data_Path
> as 0x01 for HCI_Enhanced_Setup_Synchronous_Connection, does NOT need
> to configure data path by HCI_Configure_Data_Path at all.

This part it doesn't need to use HCI_Configure_Data_Path seems to be
non-standard, if so it needs to be handled by the driver, also it is
probably a good idea to explain how it works, what are the commands
used and the result traffic using btmon to collect the HCI trace.

> Zijun Hu (2):
>   Bluetooth: hci_conn: Check non NULL before calling
>     hdev->get_codec_config_data()
>   Bluetooth: qca: Support SCO offload for QCA2066
>
>  drivers/bluetooth/hci_qca.c | 19 +++++++++++++++++++
>  net/bluetooth/hci_conn.c    |  2 +-
>  2 files changed, 20 insertions(+), 1 deletion(-)
>
> --
> The Qualcomm Innovation Center
>


--=20
Luiz Augusto von Dentz