Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3332115rdh; Mon, 27 Nov 2023 11:23:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFoqQ9T/iHMmDizQU6sH4a3Hds/j5GPirr8wyxh73+onCiHE2GjtrAbS/Z/7TnhtlRGzgEh X-Received: by 2002:a05:6a21:6d88:b0:186:7eaf:7176 with SMTP id wl8-20020a056a216d8800b001867eaf7176mr14074793pzb.59.1701113008125; Mon, 27 Nov 2023 11:23:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701113008; cv=none; d=google.com; s=arc-20160816; b=WNmK1AsVUxl14PL7hIiMCgu9qZtzMJYxI/JRX9tHtnUf2OoOX06MFS+xJcbOyzBsFA jhWDMXlB9k3PBua6DnVjjfw5T6akpLc1KsUEDQ8mWcy9JcZcBSWt0HkiSn7v+oCwG9vT BDx1N5IZD9E6kJxI7Q9GPAnFHGNc8OBPqpyJBoNeT3+ILAQACHYwuU1vLVyABvQ8d15g BNvgkvfaQQeCtm4YWQjnFxiDnpX0JwtRdRIPuT4tYCjv1ectkJxKK2JIHZYFYC7FEZY3 Du0VjttVC3TAD9TEzO64rYwRtXSYampxZ1ZzM3xi6WClByqsVb36E6wDPySRjOGc+elv jotA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=exq4LVwpbJjU/dctBbOVPn9o5GckNL2iXNCjM5rt1yQ=; fh=Pfu6VUo0ONDfUIQRoVK1vzWh/7ZgfW19QwYrOCsqVFA=; b=qI4yeuNlpF3I8NoyeVfMzpTl88qMgTmtsyhhKkuVIQGHImUOfAQdcRIoVaS7SYQMO3 VNosTJLNROWMFW290e40KJExhJFLwCZ6DqqXT7K88XjyQa7xB3VkGGRdOl7iQ39+LU14 i6F90ezrxmM9kHvw22RHTpf4wDEIPArhsUJF5VXMMIZ0r5aPxwpHPz2HUqccGq9ztpkO kLZH65J/scUsOVyfH/ZDBiEyjx1H9ypAhvdw7OWpwOzgyeQWBnlhaKtGp2U1wi+0O4LI /6aiFq/yADDZczmSOjROxUYgW/8+54wToRRQ0hd1Yu3osbGVq4f108Ki/5QGnX8OVRjA JyWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth+bounces-248-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-248-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id s10-20020a65690a000000b005c200b11ba7si10398463pgq.763.2023.11.27.11.23.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 11:23:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-248-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth+bounces-248-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-248-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1A772281A52 for ; Mon, 27 Nov 2023 19:23:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 311273EA83; Mon, 27 Nov 2023 19:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none X-Original-To: linux-bluetooth@vger.kernel.org Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21133D5A; Mon, 27 Nov 2023 11:23:20 -0800 (PST) Received: from francesco-nb.int.toradex.com (31-10-206-125.static.upc.ch [31.10.206.125]) by mail11.truemail.it (Postfix) with ESMTPA id 32EDF206D2; Mon, 27 Nov 2023 20:23:18 +0100 (CET) Date: Mon, 27 Nov 2023 20:23:14 +0100 From: Francesco Dolcini To: Jiri Slaby Cc: Francesco Dolcini , Sean Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Matthias Brugger , AngeloGioacchino Del Regno , Amitkumar Karwar , Neeraj Kale , Francesco Dolcini , linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v1 0/3] Bluetooth: fix recv_buf() return value Message-ID: References: <20231127191409.151254-1-francesco@dolcini.it> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231127191409.151254-1-francesco@dolcini.it> Hello Jiri, On Mon, Nov 27, 2023 at 08:14:05PM +0100, Francesco Dolcini wrote: > From: Francesco Dolcini > > Serdev recv_buf() callback is supposed to return the amount of bytes > consumed, therefore an int in between 0 and count. I have also a patch ready to convert the return value of serdev recv_buf() from int to size_t. I would be inclined to wait for this series to go though first, given that these are fixes, while the change from int to size_t is just a cleanup to prevent future mistakes. Do you agree of would you do it differently? Francesco