Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp3617994rdh; Mon, 27 Nov 2023 21:18:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQN/q5Cbzshlznd4vpJZmngW5sQVh3LtsmSStbMISwUH+v7zFlv9KjW9/ut3dpozP+Ew57 X-Received: by 2002:a05:6a20:9c93:b0:18b:281e:51ba with SMTP id mj19-20020a056a209c9300b0018b281e51bamr14823232pzb.11.1701148691538; Mon, 27 Nov 2023 21:18:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701148691; cv=none; d=google.com; s=arc-20160816; b=Z7cLeYh3lNplT14Zwumtl/DJQq98JStSnYsUsGFtEX5UcM0JOllpQyE0p4oCo7780q 3pX0JHpmdIEWVTLxeQI5dFVT0Ps+80iY3ObC8NCukhluV7dD5btoS6XSB52qErQ5WyTv v1P9jRabxzC8Er+ozr2Fer2oqQ584EbU+gyUnJ9udOLdpLZ9rJ0/XdQ3LRXBM1g1OMIm zZza1MHruVLQJP3BoOLq9y44my03W1L/5TABxi+Q0g+thI8uZYYL2wQyD2N+dBM/uVZR AOEKn3WfY2zqhuhdSVaVSIRDdlNmTXWSqgmmfld0YmYjmmMpwQvUMiMA+lLyBspNRv2O tM9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id; bh=SKeicnPR0lJ4OWc/qdP0Ppo8oLduWAkxTgoi6LPMexw=; fh=JS0sTaNk0KT7I7SZKG0UJ0CkXcNfE3zsUdCp+TGKwnk=; b=jXjg6r/TUw9I0QNp9iZk1BSf69uO0/q1SLubThLpxItEouwLVTcx67WUHVl6+ByMGq qbwVXjxsfXfBqe/+2LPmCIGCOBvDvvLRqAQesjZ/UWovKoqITH40mZ6iuq+Tqv/H1akO kGOAFOBCceJcEw4s1tJysbVueP80JmEz2vaFEWDqJTVs/qvfA6OGZ0ciFJIhMy+wl+KK iRZYj0/kW0TqgVQEvVqV9iHWl/80lExc5OVHUcn5ShbaDAqnoNpG+rzTNfNYCbVKawb/ KJmVcQtAjvDFt2WNMWU8v+opNs2E6z4bM5lE/nzQTISOf0YzUGmNCyTfcqQLXffbu4MT gwdA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth+bounces-258-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-258-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id u11-20020a17090341cb00b001cfdbd5fe0bsi2507280ple.551.2023.11.27.21.18.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 21:18:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-258-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth+bounces-258-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-258-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 0EE03B2118E for ; Tue, 28 Nov 2023 05:18:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 81E57101E5; Tue, 28 Nov 2023 05:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none X-Original-To: linux-bluetooth@vger.kernel.org Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B9DA194; Mon, 27 Nov 2023 21:17:55 -0800 (PST) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-54a945861c6so6913379a12.3; Mon, 27 Nov 2023 21:17:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701148673; x=1701753473; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SKeicnPR0lJ4OWc/qdP0Ppo8oLduWAkxTgoi6LPMexw=; b=pkFmzl5zOpjCDajgWQy1OLDxMU2qHkYFWoFUUz5uKDlwyBo/8DX8E7L4Q3zYqhNQi7 O9+ntpkrot436hN+HClekLc1HHWMZgmVxlMTan+2r9nXKDwym3ZtoVn8pq03B3O36h7b cds/h4KD1nZeEvgsLQh8TqX31cwxEKY36wKBwWMo7EGvIZWJXI6nZy8UjEnTAIfKnGqZ 1kBEPZlZhxmTmB6kXB2+7mRivVVkLXRF7OgL2Q72C51nw8Z50lPSw/oLmEiQ8BjBkbOr MgMhVJQ3ybBsdkR8i2r8Aw6Jj7ArR6f3D3Aj9Ir/gNof8+AENSSpmQ6dUT+D6HP/lizs wnUg== X-Gm-Message-State: AOJu0Yx0b68JZHsBvuJaAaHKEnGMGMC6BHvj5VOwXCfZVKrxkvb2PpaD t8l5NhWFmhI3yRC7XaeVsrA= X-Received: by 2002:aa7:c551:0:b0:54a:ed3c:f4f3 with SMTP id s17-20020aa7c551000000b0054aed3cf4f3mr9448861edr.25.1701148673468; Mon, 27 Nov 2023 21:17:53 -0800 (PST) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id x21-20020a05640226d500b0054b2bc67225sm3309195edd.10.2023.11.27.21.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Nov 2023 21:17:53 -0800 (PST) Message-ID: Date: Tue, 28 Nov 2023 06:17:51 +0100 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/3] Bluetooth: fix recv_buf() return value To: Francesco Dolcini Cc: Sean Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Matthias Brugger , AngeloGioacchino Del Regno , Amitkumar Karwar , Neeraj Kale , Francesco Dolcini , linux-bluetooth@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org References: <20231127191409.151254-1-francesco@dolcini.it> Content-Language: en-US From: Jiri Slaby Autocrypt: addr=jirislaby@kernel.org; keydata= xsFNBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABzSFKaXJpIFNsYWJ5 IDxqaXJpc2xhYnlAa2VybmVsLm9yZz7CwXcEEwEIACEFAlW3RUwCGwMFCwkIBwIGFQgJCgsC BBYCAwECHgECF4AACgkQvSWxBAa0cEnVTg//TQpdIAr8Tn0VAeUjdVIH9XCFw+cPSU+zMSCH eCZoA/N6gitEcnvHoFVVM7b3hK2HgoFUNbmYC0RdcSc80pOF5gCnACSP9XWHGWzeKCARRcQR 4s5YD8I4VV5hqXcKo2DFAtIOVbHDW+0okOzcecdasCakUTr7s2fXz97uuoc2gIBB7bmHUGAH XQXHvdnCLjDjR+eJN+zrtbqZKYSfj89s/ZHn5Slug6w8qOPT1sVNGG+eWPlc5s7XYhT9z66E l5C0rG35JE4PhC+tl7BaE5IwjJlBMHf/cMJxNHAYoQ1hWQCKOfMDQ6bsEr++kGUCbHkrEFwD UVA72iLnnnlZCMevwE4hc0zVhseWhPc/KMYObU1sDGqaCesRLkE3tiE7X2cikmj/qH0CoMWe gjnwnQ2qVJcaPSzJ4QITvchEQ+tbuVAyvn9H+9MkdT7b7b2OaqYsUP8rn/2k1Td5zknUz7iF oJ0Z9wPTl6tDfF8phaMIPISYrhceVOIoL+rWfaikhBulZTIT5ihieY9nQOw6vhOfWkYvv0Dl o4GRnb2ybPQpfEs7WtetOsUgiUbfljTgILFw3CsPW8JESOGQc0Pv8ieznIighqPPFz9g+zSu Ss/rpcsqag5n9rQp/H3WW5zKUpeYcKGaPDp/vSUovMcjp8USIhzBBrmI7UWAtuedG9prjqfO wU0ETpLnhgEQAM+cDWLL+Wvc9cLhA2OXZ/gMmu7NbYKjfth1UyOuBd5emIO+d4RfFM02XFTI t4MxwhAryhsKQQcA4iQNldkbyeviYrPKWjLTjRXT5cD2lpWzr+Jx7mX7InV5JOz1Qq+P+nJW YIBjUKhI03ux89p58CYil24Zpyn2F5cX7U+inY8lJIBwLPBnc9Z0An/DVnUOD+0wIcYVnZAK DiIXODkGqTg3fhZwbbi+KAhtHPFM2fGw2VTUf62IHzV+eBSnamzPOBc1XsJYKRo3FHNeLuS8 f4wUe7bWb9O66PPFK/RkeqNX6akkFBf9VfrZ1rTEKAyJ2uqf1EI1olYnENk4+00IBa+BavGQ 8UW9dGW3nbPrfuOV5UUvbnsSQwj67pSdrBQqilr5N/5H9z7VCDQ0dhuJNtvDSlTf2iUFBqgk 3smln31PUYiVPrMP0V4ja0i9qtO/TB01rTfTyXTRtqz53qO5dGsYiliJO5aUmh8swVpotgK4 /57h3zGsaXO9PGgnnAdqeKVITaFTLY1ISg+Ptb4KoliiOjrBMmQUSJVtkUXMrCMCeuPDGHo7 39Xc75lcHlGuM3yEB//htKjyprbLeLf1y4xPyTeeF5zg/0ztRZNKZicgEmxyUNBHHnBKHQxz 1j+mzH0HjZZtXjGu2KLJ18G07q0fpz2ZPk2D53Ww39VNI/J9ABEBAAHCwV8EGAECAAkFAk6S 54YCGwwACgkQvSWxBAa0cEk3tRAAgO+DFpbyIa4RlnfpcW17AfnpZi9VR5+zr496n2jH/1ld wRO/S+QNSA8qdABqMb9WI4BNaoANgcg0AS429Mq0taaWKkAjkkGAT7mD1Q5PiLr06Y/+Kzdr 90eUVneqM2TUQQbK+Kh7JwmGVrRGNqQrDk+gRNvKnGwFNeTkTKtJ0P8jYd7P1gZb9Fwj9YLx jhn/sVIhNmEBLBoI7PL+9fbILqJPHgAwW35rpnq4f/EYTykbk1sa13Tav6btJ+4QOgbcezWI wZ5w/JVfEJW9JXp3BFAVzRQ5nVrrLDAJZ8Y5ioWcm99JtSIIxXxt9FJaGc1Bgsi5K/+dyTKL wLMJgiBzbVx8G+fCJJ9YtlNOPWhbKPlrQ8+AY52Aagi9WNhe6XfJdh5g6ptiOILm330mkR4g W6nEgZVyIyTq3ekOuruftWL99qpP5zi+eNrMmLRQx9iecDNgFr342R9bTDlb1TLuRb+/tJ98 f/bIWIr0cqQmqQ33FgRhrG1+Xml6UXyJ2jExmlO8JljuOGeXYh6ZkIEyzqzffzBLXZCujlYQ DFXpyMNVJ2ZwPmX2mWEoYuaBU0JN7wM+/zWgOf2zRwhEuD3A2cO2PxoiIfyUEfB9SSmffaK/ S4xXoB6wvGENZ85Hg37C7WDNdaAt6Xh2uQIly5grkgvWppkNy4ZHxE+jeNsU7tg= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 27. 11. 23, 20:23, Francesco Dolcini wrote: > On Mon, Nov 27, 2023 at 08:14:05PM +0100, Francesco Dolcini wrote: >> From: Francesco Dolcini >> >> Serdev recv_buf() callback is supposed to return the amount of bytes >> consumed, therefore an int in between 0 and count. > > I have also a patch ready to convert the return value of serdev > recv_buf() from int to size_t. > > I would be inclined to wait for this series to go though first, given > that these are fixes, while the change from int to size_t is just a > cleanup to prevent future mistakes. Do you agree of would you do it > differently? Fine by me either way. You can include it in this series at the end. Fixes can be picked up by stable too, the rest would go to mainline only. thanks, -- js suse labs