Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp323081rdb; Thu, 30 Nov 2023 05:58:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2U5WcItCiKc483CoVE4se+M2Lsryjef63DWwQILFLVDmMu2DbZzbfYHiL6nxz6rNdjgF9 X-Received: by 2002:a05:6a20:7fa4:b0:18c:8afc:cdea with SMTP id d36-20020a056a207fa400b0018c8afccdeamr14795803pzj.41.1701352721447; Thu, 30 Nov 2023 05:58:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701352721; cv=none; d=google.com; s=arc-20160816; b=0NxE/tMxQS4RRvVVIRhVu95J2wWvpEG1OudWE3aT1lxYqtAu6cvPcskUyiaG0wL74w t/bT7WhbF9N8UIIE7JUYTS4yhVtM0FOgmRlVSwuDzNJdzVUe1GdTHJbGtXG1T1FyW14j 0ZzWlG6Q3BJGqmSmWKToUvdPAcP8pkaYeQdfF22AWr8zGQL2c3PFj0QA4bG1wvht9E9D WNTKK4y93GitWRgExs3iDhovObyNMk1Fu2Rdd7UYS4j/5gCn3G1g2cIeXr6bZxVEpqtO GYkjHiwLhRXZq12qySYAKXM6tHeVVvxnts6wrWGyJ3wbjpSz8gh1rgk+MnQW6a/e9MJM DwYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id; bh=TgNmkQj2lN4QRmXRkEZBqLHlc2JoLhl/C79r4kPGofU=; fh=QSFt6ZMbzk1CXATsWXm9wz0FWA1bp6NtcDQmbiTIJX8=; b=vlAC1exBi1Pi+edoWpg0ugJIn6H0C0FQY26qfC7T2ynQEoxCMtwb5fljC8a30zg5w/ E9cuskXOisu8cGk+vLvl/Tktgy0kwpnnqEa/1dHJ/31WTMTvQopHytOh84yJQi58igq3 qXJS3GC2nPkBd86Px+v3ijNBSIrKIZRpSZhu/kqTQIxa9s3rBrZATLFR6TZjnPFf3laF JrmZdb5HVyCPNaGNAyYDIPk5hlA78rKWCvQ0UopUBr1oSobDvN+JeNNYTfR3KcdIIGhr jHg0z6vk9afcKTWGnLcDG1AIG6SmW0BDmpUMy+XM9DCLZpZb/6ebE9wY22K9+u1V2dX+ GQQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth+bounces-310-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-310-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id o10-20020a1709026b0a00b001cfb4a3adb1si248009plk.623.2023.11.30.05.58.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 05:58:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-310-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth+bounces-310-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-310-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9E56C28215B for ; Thu, 30 Nov 2023 13:58:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B4D648786; Thu, 30 Nov 2023 13:58:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none X-Original-To: linux-bluetooth@vger.kernel.org Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3DDAB9 for ; Thu, 30 Nov 2023 05:58:33 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 2A3081C0008; Thu, 30 Nov 2023 13:58:32 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 2/2] Bluetooth: Fix bogus check for re-auth no supported with non-ssp From: Bastien Nocera To: Luiz Augusto von Dentz Cc: linux-bluetooth@vger.kernel.org, Marcel Holtmann Date: Thu, 30 Nov 2023 14:58:31 +0100 In-Reply-To: References: <20200520212015.626026-1-luiz.dentz@gmail.com> <20200520212015.626026-2-luiz.dentz@gmail.com> <68150dc3fd176000e7dc893536182b3cd3cb8947.camel@hadess.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 (3.50.1-1.fc39) Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-GND-Sasl: hadess@hadess.net On Thu, 2023-11-30 at 08:43 -0500, Luiz Augusto von Dentz wrote: > Hi Bastien, >=20 > On Thu, Nov 30, 2023 at 7:02=E2=80=AFAM Bastien Nocera > wrote: > >=20 > > On Wed, 2020-05-20 at 14:20 -0700, Luiz Augusto von Dentz wrote: > > > From: Luiz Augusto von Dentz > > >=20 > > > This reverts 19f8def031bfa50c579149b200bfeeb919727b27 > > > "Bluetooth: Fix auth_complete_evt for legacy units" which seems > > > to be > > > working around a bug on a broken controller rather then any > > > limitation > > > imposed by the Bluetooth spec, in fact if there ws not possible > > > to > > > re-auth the command shall fail not succeed. > > >=20 > > > Signed-off-by: Luiz Augusto von Dentz > >=20 > > Looks like this fell through the cracks, do you want me to rebase > > and > > re-send it? >=20 > Yeah, please resend so we get the CI to test it doesn't break > anything. Done. Cheers