Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-442-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <8ff48948-af4d-4bba-be38-891e89e25a92@molgen.mpg.de>
Date: Thu, 7 Dec 2023 20:29:49 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH BlueZ v1] client/player: Fix not prompting all parameter
 on endpoint.register
Content-Language: en-US
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
References: <20231207184723.3862261-1-luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20231207184723.3862261-1-luiz.dentz@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Dear Luiz,


Am 07.12.23 um 19:47 schrieb Luiz Augusto von Dentz:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> When Auto Accept is not enable not all parameters are requested.

enable*d*

> ---
>   client/player.c | 10 +++-------
>   1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/client/player.c b/client/player.c
> index 4673d2efece8..4d49602c70d7 100644
> --- a/client/player.c
> +++ b/client/player.c
> @@ -2813,17 +2813,13 @@ static void endpoint_auto_accept(const char *input, void *user_data)
>   		return;
>   	} else if (!strcasecmp(input, "n") || !strcasecmp(input, "no")) {
>   		ep->auto_accept = false;
> +		bt_shell_prompt_input(ep->path, "Max Transports (auto/value):",
> +						endpoint_max_transports, ep);
> +		return;
>   	} else {
>   		bt_shell_printf("Invalid input for Auto Accept\n");
>   		return bt_shell_noninteractive_quit(EXIT_FAILURE);
>   	}
> -
> -	if (ep->broadcast)
> -		bt_shell_prompt_input(ep->path, "BIG (auto/value):",
> -					endpoint_iso_group, ep);
> -	else
> -		bt_shell_prompt_input(ep->path, "CIG (auto/value):",
> -					endpoint_iso_group, ep);
>   }

Excuse my ignorance, but it’s not clear to me why *Max Transports* is 
now used instead of *BIG* or *CIG*, and what the code path is, that 
could not have led to one of the two prompts.

>   static void endpoint_set_metadata(const char *input, void *user_data)


Kind regards,

Paul