Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-580-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231213085011.1152912-1-frederic.danis@collabora.com>
In-Reply-To: <20231213085011.1152912-1-frederic.danis@collabora.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Wed, 13 Dec 2023 12:27:37 -0500
Message-ID: <CABBYNZK8u1iuHA8FRXO9HL-kbYrL8jngo=UJG71+HHXJuSNSFw@mail.gmail.com>
Subject: Re: [PATCH BlueZ] hog-lib: Fix HoG discovering characteristics order
To: =?UTF-8?B?RnLDqWTDqXJpYyBEYW5pcw==?= <frederic.danis@collabora.com>
Cc: linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Fr=C3=A9d=C3=A9ric,

On Wed, Dec 13, 2023 at 3:50=E2=80=AFAM Fr=C3=A9d=C3=A9ric Danis
<frederic.danis@collabora.com> wrote:
>
> PTS test HOGP/RH/HGRF/BV-01-I fails as inconclusive after waiting for
> second report map read request with message 'Please send ReadRequest to
> read Report Map characteristic with handle =3D 0x00E7'.
> Handle which has already been read, as it can be seen in btmon traces.
>
> This commit change the recursion order to read instance characteristics
> before recurring to next instances.
>
> Closes: https://github.com/bluez/bluez/issues/657
> ---
>  profiles/input/hog-lib.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c
> index 7ff1ede3d..db62a3c9f 100644
> --- a/profiles/input/hog-lib.c
> +++ b/profiles/input/hog-lib.c
> @@ -1780,12 +1780,6 @@ bool bt_hog_attach(struct bt_hog *hog, void *gatt)
>
>         queue_foreach(hog->bas, (void *) bt_bas_attach, gatt);
>
> -       for (l =3D hog->instances; l; l =3D l->next) {
> -               struct bt_hog *instance =3D l->data;
> -
> -               bt_hog_attach(instance, gatt);
> -       }
> -
>         if (!hog->uhid_created) {
>                 DBG("HoG discovering characteristics");
>                 if (hog->attr)
> @@ -1798,6 +1792,12 @@ bool bt_hog_attach(struct bt_hog *hog, void *gatt)
>                                         char_discovered_cb, hog);
>         }
>
> +       for (l =3D hog->instances; l; l =3D l->next) {
> +               struct bt_hog *instance =3D l->data;
> +
> +               bt_hog_attach(instance, gatt);
> +       }
> +
>         if (!hog->uhid_created)
>                 return true;

While I don't oppose this change, but this seems to be a limitation on
the PTS side which expects a certain order of the operation which
doesn't seem to be a requirement coming from the spec, so perhaps we
should file an issue to PTS.

> --
> 2.34.1
>
>


--=20
Luiz Augusto von Dentz