Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-586-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <08015729-1917-4d0f-be93-a26b5bd966ed@collabora.com>
Date: Thu, 14 Dec 2023 11:44:10 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH BlueZ] hog-lib: Fix HoG discovering characteristics order
Content-Language: en-US
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
References: <20231213085011.1152912-1-frederic.danis@collabora.com>
 <CABBYNZK8u1iuHA8FRXO9HL-kbYrL8jngo=UJG71+HHXJuSNSFw@mail.gmail.com>
From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Danis?= <frederic.danis@collabora.com>
In-Reply-To: <CABBYNZK8u1iuHA8FRXO9HL-kbYrL8jngo=UJG71+HHXJuSNSFw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Luiz,

On 13/12/2023 18:27, Luiz Augusto von Dentz wrote:
> Hi Frédéric,
>
> On Wed, Dec 13, 2023 at 3:50 AM Frédéric Danis
> <frederic.danis@collabora.com> wrote:
>> PTS test HOGP/RH/HGRF/BV-01-I fails as inconclusive after waiting for
>> second report map read request with message 'Please send ReadRequest to
>> read Report Map characteristic with handle = 0x00E7'.
>> Handle which has already been read, as it can be seen in btmon traces.
>>
>> This commit change the recursion order to read instance characteristics
>> before recurring to next instances.
>>
>> Closes: https://github.com/bluez/bluez/issues/657
>> ---
>>   profiles/input/hog-lib.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/profiles/input/hog-lib.c b/profiles/input/hog-lib.c
>> index 7ff1ede3d..db62a3c9f 100644
>> --- a/profiles/input/hog-lib.c
>> +++ b/profiles/input/hog-lib.c
>> @@ -1780,12 +1780,6 @@ bool bt_hog_attach(struct bt_hog *hog, void *gatt)
>>
>>          queue_foreach(hog->bas, (void *) bt_bas_attach, gatt);
>>
>> -       for (l = hog->instances; l; l = l->next) {
>> -               struct bt_hog *instance = l->data;
>> -
>> -               bt_hog_attach(instance, gatt);
>> -       }
>> -
>>          if (!hog->uhid_created) {
>>                  DBG("HoG discovering characteristics");
>>                  if (hog->attr)
>> @@ -1798,6 +1792,12 @@ bool bt_hog_attach(struct bt_hog *hog, void *gatt)
>>                                          char_discovered_cb, hog);
>>          }
>>
>> +       for (l = hog->instances; l; l = l->next) {
>> +               struct bt_hog *instance = l->data;
>> +
>> +               bt_hog_attach(instance, gatt);
>> +       }
>> +
>>          if (!hog->uhid_created)
>>                  return true;
> While I don't oppose this change, but this seems to be a limitation on
> the PTS side which expects a certain order of the operation which
> doesn't seem to be a requirement coming from the spec, so perhaps we
> should file an issue to PTS.

Yes, I opened an issue to PTS.
Let's see what they will reply.

Regards,

Fred

-- 

Frédéric Danis
Senior Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, United Kingdom
Registered in England & Wales, no. 5513718