Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-587-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Vinit Mehta <vinit.mehta@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: devyani.godbole@nxp.com,
	nitin.jadhav@nxp.com
Subject: [PATCH BlueZ v1 0/1] mgmt: Fix crash after pair command
Date: Thu, 14 Dec 2023 16:33:37 +0530
Message-ID: <20231214110339.1763-1-vinit.mehta@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?gtBmONeSRZQDHvAaYMyQKC2NaleqgFpOnGV72fZ4FpTK/Qdlz56ouRc9R30o?=
 =?us-ascii?Q?yQ/3NfrxuKU3q5qAPhABG78cW5n6UZaRgPdY8jTSCGHDXw9ylfljMOifu3sG?=
 =?us-ascii?Q?gbO83t8FCYSEC+GDEkApph3S8bbLvBq47O2DV9LGiba2HKiWwrjIclUIpiAE?=
 =?us-ascii?Q?YOWElnkp5OYsi6zNxEmPkesK68OFvbcwNo9rEnIEY/4JMvCFT06Xjfv88/11?=
 =?us-ascii?Q?7seYyRW2AsT6ckBMDvgKUcWfeSidZ6QySNKRox0RBcF1bh/L5BolcrpRISjS?=
 =?us-ascii?Q?9EBIg1SQtkhOwmidbhj7EcRMGgRO6mQ6vf3Ik+1eI50T8DR88bzzr/wTOc3Z?=
 =?us-ascii?Q?xPXX/0v9mR1yn2GmRthokddYl5R/EikIjoVWvWkYP6LyqKHhjrPQTOfYpL28?=
 =?us-ascii?Q?HSolkjKaZmYjfkFZT2vF2geI8nQYMrNOe87JDpi5wGeIhVsTZpf3LbzQGVHd?=
 =?us-ascii?Q?1UE3g7eIwHJZynmxca0ONM10Z4Z+JIcJFQVcrKGrEy5manLtG1QEhoFKsYRh?=
 =?us-ascii?Q?wme2mUw3VZlXTIdJTLCHj+p+AedhgAjTxJusxCo0zXO4awJ68751jgEgJXMo?=
 =?us-ascii?Q?gooNQtb3xZLZvtvFv4/j3RdgdKayaWB8p4J59udZGsPtc/e9zUSX8hMi8YuU?=
 =?us-ascii?Q?bHK/wllxkI+q4/QX8Nd7KT6vaAc6UsNDVH60htBj4WI2CZTrye1EQ4vY/b1u?=
 =?us-ascii?Q?ALuOD4TGa5DsrU8TRzOJQ7U8hS0Zp8OXzOnoTB+9noYxLzMChNwZaP1ceHrO?=
 =?us-ascii?Q?dI8u/WxhRpIv3FNAk22BcvxKduZPwPqEFyhpPJYnCGd5sfWt3XcwaZOXQQ6h?=
 =?us-ascii?Q?CSjU+WrOqG846HyQh/H61AbxVDEL+fOjbeYRSZr7Z/Zhf5ADZ0ofPVMgBclO?=
 =?us-ascii?Q?TCRH9ki38+MYM5TolED93mhWuDgFUEzvOYrQWlkWYaNIjomXNzWgSUZ3x9DA?=
 =?us-ascii?Q?wKVgkBD+nbB9UJxvWXpMw/71JPnaGlLQSb97Kd3smWk6UFG57q7cKrkmlafS?=
 =?us-ascii?Q?zvzaF7oyuuX4uTMQm7jSc4F/2lCNeZWKAXi2/UI7K0U+Q26HiUHxlCltas+E?=
 =?us-ascii?Q?DCFYPj6nDiWUzgN5smQqPYr2hOBXQWLkhSryl2ottbIYAU8fZKdZbFm/i50o?=
 =?us-ascii?Q?d6EoC0W2U10BKnwnF3hnwbg4nc8sIuPKJCU49K2sJvS4LkKj37q3Pqo6wd1U?=
 =?us-ascii?Q?4rfHlZK4IKdeFcDk7VF2Do5Te+O1NtjLk3lbIXqWSkxRY8fHfeAP9Gn+Uk6X?=
 =?us-ascii?Q?ASRMtwCyIL9K6mq9xPnH879/dF/TqkweKOEX0WYZ222H9VI0gaJzVU0rTSi0?=
 =?us-ascii?Q?HbRHJfeAc9mVo9rc0J7r4oxwcl2W/nxetXykvV5aEhd2bbWnBYIvvV9+P5d8?=
 =?us-ascii?Q?m7/CsCGMRCX1JP30HHAOyw9c0Q/s57vd47Pgunu0z6kFoDBa6vv/O96Knx2c?=
 =?us-ascii?Q?Rn7dONe3Pcw9i9jGQuNpaDSO/6kafQWTa4Ws7dbKkemKIE7796UPyzNuk8fr?=
 =?us-ascii?Q?rrk+ne2j5Fly+0JoKOrZ7j4CN7moVwx176ze8czzTXAXGTYpp8qusNy3DoGp?=
 =?us-ascii?Q?OhWkXo0Ybj+GrRwQTlbvukSFHI5lHN6o/rnH24dN?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b145efaf-e583-447c-ee39-08dbfc946961
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7709.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 11:04:15.9999
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZQFYSn1+3HkDw1Rw6hwBHCPDsiv8MRe/oPt85zzKDeGb1CcdsTYEb2CXMiBX2lXy1iMbJfs758hkI1wbBoVnUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB10042

Hello Maintainers

This patch fixes assertion in bluetoothctl client process

After pair command, if the user doesn't provide any input on bluetoothctl
CLI interface after receiving the prompt(yes/no), than subsequent CLI 
command will trigger a call to DBUS library function 
(dbus_message_get_no_reply) with a NULL message pointer which triggers
assertion in DBUS library causing the bluetoothctl process to crash. 
The change below will ensure in case if no input is given by the user, 
a conditional check is added to handle this scenario and a default 
character ('N') will be passed so as to avoid the assertion.

Thank you in advance for your review.

Warm Regards
Vinit Mehta

Vinit Mehta (1):
  mgmt: Fix crash after pair command

 client/mgmt.c | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

-- 
2.42.0.windows.2