Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-588-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Vinit Mehta <vinit.mehta@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: devyani.godbole@nxp.com,
	nitin.jadhav@nxp.com
Subject: [PATCH BlueZ v1 1/1] mgmt: Fix crash after pair command
Date: Thu, 14 Dec 2023 16:33:38 +0530
Message-ID: <20231214110339.1763-2-vinit.mehta@nxp.com>
In-Reply-To: <20231214110339.1763-1-vinit.mehta@nxp.com>
References: <20231214110339.1763-1-vinit.mehta@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?RrflxE+M50dQ3QW9dX4uLrj1ENCzYx8vSEGPAmS+pwHWvv6bJuQ7gAN72Wt7?=
 =?us-ascii?Q?x/QtphAdgIoYDGdLjzh0r/lLKjUiUGLfPQ47emCxJLRoHDcM+q80yWqIfTHt?=
 =?us-ascii?Q?cq8ihAp+0Z9YCfiIUSv8/63EaQOo3ZP+tPMPuB33jQXv5EmVOqJv3c5R7nmU?=
 =?us-ascii?Q?G56NGBA3KxuKYlBIfd5kIOPgMK6VEIIN/qk7SQ8G1qKBabN+osgkDyXk5DcC?=
 =?us-ascii?Q?lBYgEEWLTWpJh7k8idQNbkL6242c+mM/WoOj6Oh4/HvhejJxx7g381xRjXrR?=
 =?us-ascii?Q?VZgSQ6fhVHPmATKR+QELwkUFwYzaonuCo/0USS0oI62Ks9leEqp1oUJoi75P?=
 =?us-ascii?Q?UqyNMD4+atJAO4bWt+zHIoml1w4Bqqo8KokMSJa5GKpXBpJkWAs1YXEWL5jN?=
 =?us-ascii?Q?maJ7unmqF3wG/mnHy8VHEP+lxiTt2KUY931PwJ+QgS2QsGNLviiYk78PuL5V?=
 =?us-ascii?Q?IZ4ZEMn5wyoesgWbIOtgGXXpOqtkAl7Ii4U3O2VoyW0EAUPG4b2BvwZdiZFo?=
 =?us-ascii?Q?s2h9JXB+StEh5ewY7rIZXGCGALpjaIIzDETOqo0JebybVmB1H+uAMbyyoimr?=
 =?us-ascii?Q?WaBV3R9b5Zvx9NAt5YHcDEyVtrGLY6Mt2xMXIfS5imJjrzJqhV56TFYg+00Z?=
 =?us-ascii?Q?xqNtORQqWb24Se78Y/SvTmvG8W8KgnPkpmXfy7GD25f8kDk22+D6+b/5+lAQ?=
 =?us-ascii?Q?tsh+E5ONGaPg9+qtWXNbNZAya+EkKveKnRW39wlCQYC00Lx5vA1c9agiNHCY?=
 =?us-ascii?Q?TaTyo8vFZWKYlhjPJfAxiyKGE62OKZ8EjgPNxvTsEvpRj+HH2W0NIcN7bCYi?=
 =?us-ascii?Q?8kLqKY8qVUbf7yBqS7Lpja/kjmRw5l/F6t/Dk4FHsV/700SDQrg+IF2sC4Cz?=
 =?us-ascii?Q?vutKKcrgkYp40GctgekHSofYLGfMbpP9CqJZ/7c2yLg7KId+tEdy9lsfMH18?=
 =?us-ascii?Q?7Ih0sD14YMY972+/p0TIkCyyBFJAhtfbkXqBWzHcOyO9ojAXg8az+EfzzPAI?=
 =?us-ascii?Q?/c+slqYBmKOlMbUEYg5foHZ3KLTBnScl0JQXf92C7XbnVpGrA9oysCEZpAWd?=
 =?us-ascii?Q?gtKqPZbLqDQqv+5ZgPjVW/kPcuyboH0iqpYM/kodqzefxO61RBJl/xweJ5ev?=
 =?us-ascii?Q?423ge2j20gxiPHHQdRAVdT0/Ty2vIVEiGFNZkdI2COKgoJgQz7Dl8AmoFfXR?=
 =?us-ascii?Q?pWoqcwMKYw7c1l5gQ+ML3OjtXraAoNrkmn55TNDYUELtyR3p8Sn4hY7vlFAP?=
 =?us-ascii?Q?WnVCtYqYlt64d/mCMmeD0EMEJ8gV8tRtJUsC1EOGYj+NMYf+Nd6ixjNE3KIU?=
 =?us-ascii?Q?MLR1c0ZZJ3Fiw1/LeGZRQM24C06wdzMrx3TyyUeIMNTCKLXfg+oanEArPXpQ?=
 =?us-ascii?Q?pY4fzBtlQnXyVLjYadHSs95UsbCAr7ikBnlj6fD2eSalXOhgJ2/vRVCATESa?=
 =?us-ascii?Q?/CMi5fN5VyZZzdpm4itjmT1sjKUE66Qzwf7I+Antzx9BPcyXgy3TkwZwCJLk?=
 =?us-ascii?Q?FXIlmV3ILCurKC5mbYcSC+cAK9HkXZuMlv/GbA11Zo6RUt+ehzWr5de3yx6k?=
 =?us-ascii?Q?CFveX2DuB65VwEtQeSraD/nIDw87PtgDP8jbsuEM?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b119719-0bea-4c61-2c17-08dbfc946d12
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7709.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2023 11:04:22.0896
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c4d2duZPl2B+Hvly4M4ek4N0CyWwUan748HjgixRTeLyrPo1aOoBoMwGiOvNBebnOzijfzabqYW85k8fxzsyJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS5PR04MB10042

After pair command, if the user doesn't provide any input on bluetoothctl
CLI interface after receiving the prompt(yes/no) below crash is observed:

dbus[782]: arguments to dbus_message_get_no_reply() were incorrect,
assertion "message != NULL" failed in file
/usr/src/debug/dbus/1.14.10-r0/dbus/dbus-message.c line 3250.
This is normally a bug in some application using the D-Bus library.
/usr/lib/libc.so.6(+0x27534) [0xffffa1b67534]
/usr/lib/libc.so.6(__libc_start_main+0x9c) [0xffffa1b6760c]
bluetoothctl(+0x188f0) [0xaaaac9c088f0]
Aborted (core dumped)
---
 client/mgmt.c | 23 +++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

diff --git a/client/mgmt.c b/client/mgmt.c
index c056d018a..940e25f3c 100644
--- a/client/mgmt.c
+++ b/client/mgmt.c
@@ -54,6 +54,7 @@ static uint16_t mgmt_index = MGMT_INDEX_NONE;
 
 static bool discovery = false;
 static bool resolve_names = true;
+static const char *dummy_input = "N";
 
 static struct {
 	uint16_t index;
@@ -849,10 +850,28 @@ static void prompt_input(const char *input, void *user_data)
 								&prompt.addr);
 		break;
 	case MGMT_EV_USER_CONFIRM_REQUEST:
-		if (input[0] == 'y' || input[0] == 'Y')
-			mgmt_confirm_reply(prompt.index, &prompt.addr);
+		if(len)
+		{
+			if (input[0] == 'y' || input[0] == 'Y')
+				mgmt_confirm_reply(prompt.index, &prompt.addr);
+			else
+				mgmt_confirm_neg_reply(prompt.index, &prompt.addr);
+		}
 		else
+		{
+			/* After pair command, if the user doesn't provide any input on
+			 * bluetoothctl CLI interface after receiving the prompt(yes/no),
+			 * than subsequent CLI command will trigger a call to DBUS
+			 * library function (dbus_message_get_no_reply) with a NULL
+			 * message pointer which triggers assertion in DBUS library
+			 * causing the bluetoothctl process to crash. The change below
+			 * will ensure in case if no input is given by the user, a
+			 * conditional check is added to handle this scenario and a
+			 * default character ('N') will be passed so as to avoid the
+			 * assertion.*/
+			input = dummy_input;
 			mgmt_confirm_neg_reply(prompt.index, &prompt.addr);
+		}
 		break;
 	}
 }
-- 
2.42.0.windows.2