Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-646-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20231217135012.1476534-1-xiaokeqinhealth@126.com>
In-Reply-To: <20231217135012.1476534-1-xiaokeqinhealth@126.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Mon, 18 Dec 2023 12:18:44 -0500
Message-ID: <CABBYNZL=Vi6jaum5B5y8P2sLUF+FkcdTPJ-WU07GbG5B6YtHJw@mail.gmail.com>
Subject: Re: [PATCH BlueZ] adapter: Fix link key address type for old kernels
To: Xiao Yao <xiaokeqinhealth@126.com>
Cc: linux-bluetooth@vger.kernel.org, antiz@archlinux.org, 
	Xiao Yao <xiaoyao@rock-chips.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Xiao,

On Sun, Dec 17, 2023 at 11:21=E2=80=AFAM Xiao Yao <xiaokeqinhealth@126.com>=
 wrote:
>
> From: Xiao Yao <xiaoyao@rock-chips.com>
>
> Fixes: https://github.com/bluez/bluez/issues/686
>
> Signed-off-by: Xiao Yao <xiaoyao@rock-chips.com>
> ---
>  src/adapter.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index ee70b00d2..b4628a411 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -4347,7 +4347,17 @@ static void load_link_keys(struct btd_adapter *ada=
pter, GSList *keys,
>                 struct link_key_info *info =3D l->data;
>
>                 bacpy(&key->addr.bdaddr, &info->bdaddr);
> -               key->addr.type =3D info->bdaddr_type;
> +
> +               /*
> +                * According to the Bluetooth specification, the address
> +                * type of the link key is not fixed. However, the
> +                * load_link_keys function in the old kernel code require=
s
> +                * that the address type must be BREDR. Since the address
> +                * type is not actually used by the link key, to maintain
> +                * compatibility with older kernel versions, the addr.typ=
e
> +                * of the link key is set to BDADDR_BREDR.
> +                */
> +               key->addr.type =3D BDADDR_BREDR;

We probably want to find a way to detect if the kernel is capable of
handling the addr type or not, maybe attempt to load with it set and
in case it doesn't work then use BREDR.

>                 key->type =3D info->type;
>                 memcpy(key->val, info->key, 16);
>                 key->pin_len =3D info->pin_len;
> --
> 2.34.1
>
>


--=20
Luiz Augusto von Dentz