Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-659-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Vlad Pruteanu <vlad.pruteanu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	iulia.tanasescu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Vlad Pruteanu <vlad.pruteanu@nxp.com>
Subject: [PATCH 1/1] transport: Check if transport is bcast before it's cast to bap_transport
Date: Tue, 19 Dec 2023 14:49:16 +0200
Message-Id: <20231219124916.44173-2-vlad.pruteanu@nxp.com>
In-Reply-To: <20231219124916.44173-1-vlad.pruteanu@nxp.com>
References: <20231219124916.44173-1-vlad.pruteanu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?HqSKz7h8okUY4d4DR/63os7kPhHWGRxp/+R59JyR9aJ/3NEz5fCG0GWroRPO?=
 =?us-ascii?Q?YbCQIN3jOPymgP9PrPjbISEsWnVloI4e9AlvFznEqw2wQ+hboVPJkCr5GgA4?=
 =?us-ascii?Q?rnzOEK6GqGYT5TmgQVNC5qRxYSFD2G5++a2mqkYNPbM1eFU2Mmf+b3TF5353?=
 =?us-ascii?Q?R+qImOgR4U0MQi4Sii7D5Zgj+Bn8Z7g783JnhkXdKGuFWZcHS83P/YE5bJS4?=
 =?us-ascii?Q?wijacOILmZTGhwFRzCcc6DPsuyRFzEw6yv9kJiw0vlizYR3DXKvi1aKvprGs?=
 =?us-ascii?Q?RByr8IpnZKPeWS/blR3zE9vi83nVlE5OjI4zHCL/mecqeg8n7RjIkHhHjEXa?=
 =?us-ascii?Q?1vjUQXdfgKEmpH427eD0xaK3sOY+NWeNbR+Ewe13YnPihwu8oHF7KNcvVAki?=
 =?us-ascii?Q?cs5vGWnhq6DnrwOg6MXssNyOTd4QBk4OOlQufGFnTZ3Pdyil0zSmqnIRwfpM?=
 =?us-ascii?Q?0+MR30LYFFnuYLnU0yFTTYcM7UF/upYpDtNNwxGb5qTYOK6YAEeXJStsXlr3?=
 =?us-ascii?Q?47/vcaoP8L7aRMqquc83Oy+UrJ/BGHvn6+eQTDizh8nv3Xg+gdb5cCU0v0xr?=
 =?us-ascii?Q?EG6k8vVCZFnyTMsh7lkbs37fJPP4deF8Ktg/F9Dpp9G4U3hSxnkxEBmQeNri?=
 =?us-ascii?Q?wroieaRFFghKz2tppV+9I+s7g0OjDuAj4zi4knGJVpeWau8isf/cjVRTtSRq?=
 =?us-ascii?Q?IdBKdWqjZO0iuLDyG3heVeYTwdWa7c9tGidEQhghzDQox9k/Iq2/uMaWzrnD?=
 =?us-ascii?Q?v6oMwLhOFWM4Kj96VB41xg04KrS9vR6ISMVVL/CZ8CznwjtEZtQauveSxhyt?=
 =?us-ascii?Q?ZJJUxt/pTn9Jlvu7uSV/bRCOoqLzgi9uwP+2XpnaGVmhH/oJe7zYAc5Ay0Te?=
 =?us-ascii?Q?kGJAfzBw7P3XYdyHNXEs4l51IQFkVGa37J17pClLdJsr6CbD5jW6HhbGz6OF?=
 =?us-ascii?Q?QcA3GbK4b4wMYJXhM+q3LUl2pOxqG/GpZWCj3cYlRTWPv0ta9T/OpfqDZZD+?=
 =?us-ascii?Q?z/c/vP/ytFBWX5RS7co2/YxzDzo0CFbiMb+cDCFZwSJsNXNzNbIsAMtrt6Kx?=
 =?us-ascii?Q?2lkOoRHYMNyabDPhRSecyiinrZmZ8w1KaHcVo1CtGcRgLGxy1S7EIXvOxPrm?=
 =?us-ascii?Q?eaxHKQPlEdFg6GNZLkYNpGijbVXB8NdZ8Q/LiK0XA3EJmmC3Nd968CZKwnB7?=
 =?us-ascii?Q?gg251tFwhaBBuk34TCnoQ0GeG8iKipZWZcwDtCofmLi9M06xnxXLDjUGaDIe?=
 =?us-ascii?Q?GHM+3jxKaTWKebOu347VbIRoAkAkfZNLBHvbqrpRHQqG6H+UKROOd5xR2OHC?=
 =?us-ascii?Q?NZequJI3x0g4s4ofJLoL8XcWuAKjp+DQzZ5XqSs+QU07lFixrCIUPURRURfP?=
 =?us-ascii?Q?Eqyc+QQXYDTBpp3exqT9ggv8zVM0HYZ9UkKvyiFHEpoE3YZaFCaDtqfT/7BK?=
 =?us-ascii?Q?IGDYHXfd0uuOB38JCh9FDXd+iBAdJTFHbQBCDBkFiMLbejLPU24wg1aaCsiS?=
 =?us-ascii?Q?cMMOCyVlnvEl+NgGbvpATHnHDeSZNYym9xHQ+eeETAZEOBWXCQZ7WVfruCjU?=
 =?us-ascii?Q?fWNuPiKBjVFWs5sFpoSKbMjVmt9k0tOfx4nDn3t2?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f991a21-dde6-402a-0a5a-08dc0090fc39
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5214.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 12:49:48.8519
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EFRoHeFKNWHQn1Ercv/CVK0QOaybaDIiPMq4KZwkhvCHSB3WbLVVo7jlTDbMJza2L/p4LUU8+qVRiPytaJq/qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7110

Currently, when a transport is released it is cast to bap_transport without
checking if the transport is actually a broadcast one. Then, based on this
cast it is released. Problems may occur with transports that are not
broadcast, but are still cast to bap_transport. This commit fixes this
problem.
---
 profiles/audio/transport.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
index e2073451c..555da99a8 100644
--- a/profiles/audio/transport.c
+++ b/profiles/audio/transport.c
@@ -643,7 +643,6 @@ static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 {
 	struct media_transport *transport = data;
 	struct media_owner *owner = transport->owner;
-	struct bap_transport *bap = transport->data;
 	const char *sender;
 	struct media_request *req;
 	guint id;
@@ -675,9 +674,17 @@ static DBusMessage *release(DBusConnection *conn, DBusMessage *msg,
 	req = media_request_create(msg, id);
 	media_owner_add(owner, req);
 
-	if (bt_bap_stream_get_type(bap->stream) ==
-			BT_BAP_STREAM_TYPE_BCAST) {
-		bap_disable_complete(bap->stream, 0x00, 0x00, owner);
+	if (!strcmp(media_endpoint_get_uuid(transport->endpoint),
+					BAA_SERVICE_UUID)
+		|| !strcmp(media_endpoint_get_uuid(transport->endpoint),
+						BCAA_SERVICE_UUID)) {
+
+		struct bap_transport *bap = transport->data;
+
+		if (bt_bap_stream_get_type(bap->stream) ==
+				BT_BAP_STREAM_TYPE_BCAST) {
+			bap_disable_complete(bap->stream, 0x00, 0x00, owner);
+		}
 	}
 
 	return NULL;
-- 
2.39.2