Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-673-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Vlad Pruteanu <vlad.pruteanu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: claudia.rosu@nxp.com,
	mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	iulia.tanasescu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	Vlad Pruteanu <vlad.pruteanu@nxp.com>
Subject: [PATCH BlueZ 1/1] client/player: Allow the user to control BIG encryption
Date: Wed, 20 Dec 2023 12:21:19 +0200
Message-Id: <20231220102119.74090-2-vlad.pruteanu@nxp.com>
In-Reply-To: <20231220102119.74090-1-vlad.pruteanu@nxp.com>
References: <20231220102119.74090-1-vlad.pruteanu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?PlgvPQ8q2kY/Gs1TiTCrq+awVA5lKiHaiO1scDFggIZTW0GNDAMMJGoj7HQU?=
 =?us-ascii?Q?udv0K0onCFwL/yoff1KBXGs+Qpys3v5sd19AayMB3lwWcTuIKvAujn0sbJwA?=
 =?us-ascii?Q?QRO8iZalUeeMqtygdadO3hN4VjaPixzcFHi4uJAv54Zts/cfTSAfomdGyCuO?=
 =?us-ascii?Q?kc8TyxN54lb3ixzifdqYzhQGySEsItslJ0zHvM4J0wsYQsMDy6Ajjmq5VFSI?=
 =?us-ascii?Q?wXP9kDfeT8GrBC0wNVxAcdb+QIxXGHqVQmpaSxogvd6tdsoEYtgOSRTmzwq5?=
 =?us-ascii?Q?+vIm+uARdtfvLJvzvYw00wAkWebdlnIIwMb0tYtbW5sWqFD4P1boLs3Gzq15?=
 =?us-ascii?Q?dYYWCCCic53gUi4S8QpdBUwhT0lup04avUlJqB0fUuT8lCcS1hDYWMlLZ5ka?=
 =?us-ascii?Q?A2R9CAaKewtkELVb0o6JKfUrCdG6yP39qHPmtwNQQeR+eR/N5Hm/fld96/jL?=
 =?us-ascii?Q?VJJ8M7RbwAH9OI/L9ycursA0RrtHwmzSu8nXJlMCAP5GaWym6NXMZ6qw0NLa?=
 =?us-ascii?Q?2ymRi0rNPFZDbz0VRHEJb6e2uvy1x4KixvTX8vQwCMOv2JDMqDNgbjMuLX5X?=
 =?us-ascii?Q?F3qpBd4mYJhQuuvpogog3oW6bfI2Gn15G2FCFmjaNOCENqPXJtJXS+1iI5Id?=
 =?us-ascii?Q?7rqNrGQrSHph6cTcbmgO5Oi7KWCLzJkkZvfGeRVMljt9Bf12s6xlarKmo9tH?=
 =?us-ascii?Q?/CScuKd2sIVWPW+8UJQWMhDQqK7/SitbuAtZnSvqZu7z0GbhQTdizKkpaNwy?=
 =?us-ascii?Q?9Xr1Y/JCeMBzUonveOY/jXx8wpKq13U3rNDRiJ88dqjHwDyd+Jui57wjckzh?=
 =?us-ascii?Q?dg8Z/g0AJ3F97d5gtu0R6ZmSrWn0F7UUgQ1CtnjHKPX2TZNycuDzpoYZAL5g?=
 =?us-ascii?Q?hqbsrCSuTOFl+bQ5uPxpNBKlMKcHQGrwv4ke0OWqev0kjacOpb2Ld7hAFf+4?=
 =?us-ascii?Q?+ExSo8dV3aEAmGsKqgqbV+5IimZGNrkSD/8yIn5+j3jnCubv1oz/HhRIerNc?=
 =?us-ascii?Q?cF89SphEtYI1pVm+oOVq6+0ULnVRynoMNDe/ezR123qvNJdRkTHPejL5jgUf?=
 =?us-ascii?Q?CollftF/mUA3OPlcjoLNtAXDK6NLkJ8VD7yxD+teYkjsqw8un2gMoH+25y+w?=
 =?us-ascii?Q?5N3BbE7wu3ZtLvfQftyz1KFU5b6BMT0AL8UunRuoiDFRjlW05/GSlUks/hVp?=
 =?us-ascii?Q?rDXrOMOp36HMATqWcoD/AdgGoH6bhuLsfManbA0sIXCPgUMrz9Tlp3woPH9O?=
 =?us-ascii?Q?BGm4zKMw/z/arvH/4Mp7AXNPc/MAWWJtMDzPvojUi+IZLEgEmf93uIcs7YhN?=
 =?us-ascii?Q?6s4Ls69Zd7qb7uSwXGWWowW3OtBoWUk4I5WYscVMTHrUlFcOrR8ssxwMdpL8?=
 =?us-ascii?Q?fgJufRR0t6Dz+PPURnHvS+9do7mC+vV7pXWFsFDTGucmcFIrimNWnQ/G3fTc?=
 =?us-ascii?Q?633GGXWtY804YHt/uWUEoqaf8O/MRhnbkJiKwBVvTXtqRJdx6i+0OIupBNr7?=
 =?us-ascii?Q?hr5BcL/242x6nmlAgtXQ0o+qTgNBhcoeshBBVhuZx6i/nW6eqU4cdsFpQ7GF?=
 =?us-ascii?Q?xS3aO2lk5nzEX2B3mGSPfLhJSZZL6tP98T+Swyqb?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d09ff0c5-f06b-4ae7-f4b1-08dc01457b69
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5214.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2023 10:21:51.6671
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rTwYXRV9/0KG3G4JOZKFvBHXgxMUwxfHTGo/o876t8ygp8wbXYhB94FhJ1+NfE9b15FJVkSVQuG3ZTnib2ZDUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8213

This commit adds support for controlling the use of encryption and
setting the broadcast code. On the source side the user will be
prompted to choose if he wants to use the BIG mode 3 encryption,
and the Broadcast Code to be used (custom/default value). On the
sink side only the Broadcast Code option is displayed as the use
of encryption is set according to the BASE of the source.
---
 client/player.c | 75 ++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 59 insertions(+), 16 deletions(-)

diff --git a/client/player.c b/client/player.c
index 92fc91f92..7a5277fad 100644
--- a/client/player.c
+++ b/client/player.c
@@ -1966,6 +1966,11 @@ static void append_bcast_qos(DBusMessageIter *iter, struct endpoint_config *cfg)
 	g_dbus_dict_append_entry(iter, "Framing", DBUS_TYPE_BYTE,
 						&bcast_qos.bcast.framing);
 
+	bt_shell_printf("Encryption 0x%02x\n", bcast_qos.bcast.encryption);
+
+	g_dbus_dict_append_entry(iter, "Encryption", DBUS_TYPE_BYTE,
+						&bcast_qos.bcast.encryption);
+
 	bt_shell_printf("SyncFactor %u\n", bcast_qos.bcast.sync_factor);
 
 	g_dbus_dict_append_entry(iter, "SyncFactor", DBUS_TYPE_BYTE,
@@ -3110,6 +3115,34 @@ static void endpoint_config(const char *input, void *user_data)
 	endpoint_set_config(cfg);
 }
 
+static void set_broadcast_code(const char *input, void *user_data)
+{
+	struct endpoint_config *cfg = user_data;
+	char *endptr;
+
+	/* If input is no, set the encryption flag to 0.*/
+	if (!strcasecmp(input, "n") || !strcasecmp(input, "no"))
+		bcast_qos.bcast.encryption = 0;
+	else
+		bcast_qos.bcast.encryption = 1;
+
+	/* If input is auto, do nothing, default value will be used */
+	if (!(!strcasecmp(input, "a") || !strcasecmp(input, "auto"))) {
+		bcast_qos.bcast.bcode[0] = strtol(input, &endptr, 16);
+
+		for (uint8_t i = 1; i < 16; i++)
+			bcast_qos.bcast.bcode[i] = strtol(endptr, &endptr, 16);
+	}
+	bt_shell_printf("%ld\n", sizeof(bcast_qos.bcast.bcode));
+	iov_append(&cfg->ep->bcode, bcast_qos.bcast.bcode,
+		sizeof(bcast_qos.bcast.bcode));
+	/* Copy capabilities for broadcast*/
+	iov_append(&cfg->caps, base_lc3_16_2_1,
+		sizeof(base_lc3_16_2_1));
+
+	endpoint_set_config(cfg);
+}
+
 static struct endpoint *endpoint_new(const struct capabilities *cap);
 
 static void cmd_config_endpoint(int argc, char *argv[])
@@ -3119,7 +3152,7 @@ static void cmd_config_endpoint(int argc, char *argv[])
 	const struct capabilities *cap;
 	char *uuid;
 	uint8_t codec_id;
-	bool broadcast = false;
+	bool local_ep_not_provided = false;
 
 	cfg = new0(struct endpoint_config, 1);
 
@@ -3142,7 +3175,7 @@ static void cmd_config_endpoint(int argc, char *argv[])
 		codec_id = strtol(argv[3], NULL, 0);
 		cap = find_capabilities(uuid, codec_id);
 		if (cap) {
-			broadcast = true;
+			local_ep_not_provided = true;
 			cfg->ep = endpoint_new(cap);
 			cfg->ep->preset = find_presets_name(uuid, argv[3]);
 			if (!cfg->ep->preset)
@@ -3154,9 +3187,10 @@ static void cmd_config_endpoint(int argc, char *argv[])
 		}
 	}
 
-	if (((broadcast == false) && (argc > 3)) ||
-		((broadcast == true) && (argc > 4))) {
-		char *preset_name = (broadcast == false)?argv[3]:argv[4];
+	if (((local_ep_not_provided == false) && (argc > 3)) ||
+		((local_ep_not_provided == true) && (argc > 4))) {
+		char *preset_name = (local_ep_not_provided == false)
+							? argv[3]:argv[4];
 
 		preset = preset_find_name(cfg->ep->preset, preset_name);
 		if (!preset) {
@@ -3164,23 +3198,32 @@ static void cmd_config_endpoint(int argc, char *argv[])
 			goto fail;
 		}
 
+		/* Set QoS parameters */
+		cfg->qos = &preset->qos;
+
 		if (cfg->ep->broadcast) {
-			iov_append(&cfg->ep->bcode, bcast_qos.bcast.bcode,
-				sizeof(bcast_qos.bcast.bcode));
-			/* Copy capabilities for broadcast*/
-			iov_append(&cfg->caps, base_lc3_16_2_1,
-				sizeof(base_lc3_16_2_1));
+			/* If the endpoint is configured to be a broadcast
+			 * sink or source allow the user to set a custom
+			 * broadcast code or use the default one. Selecting
+			 * 'no' will result in the broadcast not using any
+			 * encryption.
+			 */
+			if (!strcmp(cfg->ep->uuid, BAA_SERVICE_UUID) ||
+				!strcmp(cfg->ep->uuid, BCAA_SERVICE_UUID)) {
+				bt_shell_prompt_input(cfg->ep->path,
+						"Enter the broadcast code (value/auto/no):",
+						set_broadcast_code, cfg);
+				return;
+			}
+
 		} else {
 			/* Copy capabilities */
 			iov_append(&cfg->caps, preset->data.iov_base,
 							preset->data.iov_len);
-		}
 
-		/* Set QoS parameters */
-		cfg->qos = &preset->qos;
-
-		endpoint_set_config(cfg);
-		return;
+			endpoint_set_config(cfg);
+			return;
+		}
 	}
 
 	bt_shell_prompt_input(cfg->ep->path, "Enter configuration:",
-- 
2.39.2