Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-693-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f7bf2cbf-0ff4-4d97-8d50-024ad1c9efec@molgen.mpg.de>
Date: Thu, 21 Dec 2023 10:05:18 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Bluetooth: hci_sync: fix hogp device suspend bug
To: 15013537245@163.com
Cc: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com,
 linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
 zhongjun.yu@quectel.com, Clancy Shang <clancy.shang@quectel.com>
References: <20231221071621.1154462-1-15013537245@163.com>
Content-Language: en-US
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20231221071621.1154462-1-15013537245@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Dear Clancy,


Thank you for your patch.


Am 21.12.23 um 08:16 schrieb 15013537245@163.com:
> From: clancy shang <clancy.shang@quectel.com>

Not important, but you might want to start your name with a capital letter.

> when Bluetooth enter suspend, and disconnect everything with the diconnect

1.  enter*s*
2.  disconnect*s*
3.  … the di*s*connect …

> reason code of 0x15,the hogp device could not into sleep and continued

Please add a space after the comma.

> advertizing. when use the diconnect reason code of 0x13, the hogp device

1.  adverti*s*ing
2.  di*s*connect

> into sleep succeeded.

going into

What device is it exactly?

> Signed-off-by: clancy shang <clancy.shang@quectel.com>
> ---
>   net/bluetooth/hci_sync.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
> index d85a7091a116..16b5420c32d0 100644
> --- a/net/bluetooth/hci_sync.c
> +++ b/net/bluetooth/hci_sync.c
> @@ -5927,7 +5927,7 @@ int hci_suspend_sync(struct hci_dev *hdev)
>   
>   	if (hci_conn_count(hdev)) {
>   		/* Soft disconnect everything (power off) */
> -		err = hci_disconnect_all_sync(hdev, HCI_ERROR_REMOTE_POWER_OFF);
> +		err = hci_disconnect_all_sync(hdev, HCI_ERROR_REMOTE_USER_TERM);
>   		if (err) {
>   			/* Set state to BT_RUNNING so resume doesn't notify */
>   			hdev->suspend_state = BT_RUNNING;


Kind regards,

Paul