Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-859-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240103101328.1812899-1-clancy_shang@163.com>
In-Reply-To: <20240103101328.1812899-1-clancy_shang@163.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Wed, 3 Jan 2024 10:43:43 -0500
Message-ID: <CABBYNZJj6gG1kbmFSON+PrjpLuswdOiqt8AkfmYN5jzpwc1+Lg@mail.gmail.com>
Subject: Re: [PATCH] [BlueZ] adapter: Fix airpod device pair fail
To: clancy_shang@163.com
Cc: linux-bluetooth@vger.kernel.org, zhongjun.yu@quectel.com, 
	Clancy Shang <clancy.shang@quectel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, Jan 3, 2024 at 5:14=E2=80=AFAM <clancy_shang@163.com> wrote:
>
> From: Clancy Shang <clancy.shang@quectel.com>
>
> Airpod is performing inquiry scans in BR/EDR and advertising in an
> unconnectable mode with the same public address at the same time.
> with this feature, when found airpod device, set the bredr support,
> fix it pairs fail bug.
>
> Signed-off-by: Clancy Shang <clancy.shang@quectel.com>
> ---
>  src/adapter.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/src/adapter.c b/src/adapter.c
> index 022390f0d..71f7ed86d 100644
> --- a/src/adapter.c
> +++ b/src/adapter.c
> @@ -7066,6 +7066,24 @@ static void adapter_msd_notify(struct btd_adapter =
*adapter,
>         }
>  }
>
> +#define APPLE_INC_VENDOR_ID 0x004c
> +
> +static bool eir_msd_is_apple_inc(GSList *msd_list)
> +{
> +       GSList *msd_l, *msd_next;
> +
> +       for (msd_l =3D msd_list; msd_l !=3D NULL; msd_l =3D msd_next) {
> +               const struct eir_msd *msd =3D msd_l->data;
> +
> +               msd_next =3D g_slist_next(msd_l);
> +
> +               if (msd->company =3D=3D APPLE_INC_VENDOR_ID)
> +                       return true;
> +       }
> +
> +       return false;
> +}
> +
>  static bool is_filter_match(GSList *discovery_filter, struct eir_data *e=
ir_data,
>                                                                 int8_t rs=
si)
>  {
> @@ -7281,6 +7299,13 @@ void btd_adapter_device_found(struct btd_adapter *=
adapter,
>                 device_update_last_seen(dev, BDADDR_BREDR, !not_connectab=
le);
>         }
>
> +       if (eir_msd_is_apple_inc(eir_data.msd_list) &&
> +                                       (not_connectable =3D=3D true) &&
> +                                       (bdaddr_type =3D=3D BDADDR_LE_PUB=
LIC)) {
> +               device_set_bredr_support(dev);
> +               device_update_last_seen(dev, BDADDR_BREDR, true);
> +       }

NAK, we are not going to introduce device specific policy hardcoded in
the code like this, if you really want to update last seen then you
either need a dedicated driver that handles Apple UUID on its own
plugin, or make the policy plugin register a driver for it, that said
there is a flag for that indicates BR/EDR is supported not sure why
apple it no advertising using it?

>         if (eir_data.name !=3D NULL && eir_data.name_complete)
>                 device_store_cached_name(dev, eir_data.name);
>
> --
> 2.25.1
>
>


--=20
Luiz Augusto von Dentz