Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7980763rdb; Thu, 4 Jan 2024 14:20:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IF1o5BFSMq02C/IE22SlK07X5r9Un1QrXFdnSdFfla416+sKzvIhMM84f6FZ2EqsPqLKOyK X-Received: by 2002:a05:6871:7586:b0:204:2d91:b155 with SMTP id nz6-20020a056871758600b002042d91b155mr1254066oac.80.1704406850740; Thu, 04 Jan 2024 14:20:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704406850; cv=none; d=google.com; s=arc-20160816; b=y7mEqOkaPheTX0DJ8vw0QATgbQzqIckQ6PuApQxl1AMUP7lhFcM4quX2OQo0JjJuo9 NzRYtMnqYRTKU/546Nk/eLvBsijZ66EtalxsfFajQGrcknr/755id8V9JDahBrRACKuW bCSk4vKvyT9QcObfVEHM4tfohnxkdRRuNGfqxpm+lECV5qOxoS8i0XKOeDOYzubIgxG/ wmDZg17VEB2KqAKYNDoFXODZmstSnJcOBrVqIpPfexsvJhB9cNXd8NSXjx9OkCYpN+Sb OMoUdAVlOpP02h1535DSxnJWw49En3AIR1V0q73quPGTpPaGkuCrqVs5GXG4jSttc2/+ bmrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:date:message-id:from:subject :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=vP/jSRsFESWghWm1+gkb9vyil/wG/WsHQ0/wl9PA2AM=; fh=iro/qgA35p+j8U3mx9R3eJFepbkGuWFlsxPwAoXvq8E=; b=IWgQYuM8CdG06gfRK3LtWWg+XfJI4Kbu9mJ0+notybsGIjfKp9hyOujbC0Y6VCh1L4 4eygObPbbwBPs8SgBGkjZ4ZIvz1bXHGJ7ixjzroTxTQtbcpXOJvWL4gpvBVUb5xBc7mi 8Ric7k7n4Y2yyCbjZyF4pxRQCIjGcf5h7gjIEY/SRIQgmeXA2J37SYS8rq7duGB5nSC2 QJnyi8+UYMhQmJyKq2e1tHGEukFqViQkzluLAuyRG1z9AuvFUYRBhN629K90nS/uMs5z F6Brp/wA4d3RnrcektbEv5icugxlgxRpFJgF/Bq/8SPpBWvz+kQkCBzEZrcr982mz+38 c7Dg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=XA8pmP3M; spf=pass (google.com: domain of linux-bluetooth+bounces-901-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-901-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id bk33-20020a05620a1a2100b0077d9accf19fsi478298qkb.352.2024.01.04.14.20.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 14:20:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-901-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=XA8pmP3M; spf=pass (google.com: domain of linux-bluetooth+bounces-901-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-901-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7106C1C20371 for ; Thu, 4 Jan 2024 22:20:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9C2D92CCBD; Thu, 4 Jan 2024 22:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XA8pmP3M" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 073D32C860; Thu, 4 Jan 2024 22:20:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 72BC7C433C7; Thu, 4 Jan 2024 22:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704406826; bh=MvmGZmrozcWMemmPoI+jhOSNBcJqFQjtCWqa4HzCbIQ=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=XA8pmP3MF96yGkA92skcj+K/MM8N1ih/oM3Wg1HjTMOwR7lrrK7sM4QUegYvImeSS txG4Aq+N1Khq1iQ6RxiJqlLHDXY3rpzdiDo94YGs19GBOivGVp40T7OAfmT8x9Id8N 1OD6cEo5a8RI7oVYt04yhRksNL1XgHCNE7BWeL78RFa/bkvTDMLao6PAujM6oGamfH 7h50O06PDIfjJ6flUgf5wn5QwEwoO4q63m92KgchCdJjRqfEL9r7dovoe7BLlr5GuU Z8RuY8mVeKYTimZBEa9MNKf0V58VPwCKZdwFgg4yxRMYxOjbcU2Y6YoUVmXJi/mD4q BPtqsOCaPI7uA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 585F6C43168; Thu, 4 Jan 2024 22:20:26 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] Bluetooth: hci_sync: Check the correct flag before starting a scan From: patchwork-bot+bluetooth@kernel.org Message-Id: <170440682635.8457.5875385181619423548.git-patchwork-notify@kernel.org> Date: Thu, 04 Jan 2024 22:20:26 +0000 References: <20240102180810.54515-1-verdre@v0yd.nl> In-Reply-To: <20240102180810.54515-1-verdre@v0yd.nl> To: =?utf-8?q?Jonas_Dre=C3=9Fler_=3Cverdre=40v0yd=2Enl=3E?=@codeaurora.org Cc: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz : On Tue, 2 Jan 2024 19:08:08 +0100 you wrote: > There's a very confusing mistake in the code starting a HCI inquiry: We're > calling hci_dev_test_flag() to test for HCI_INQUIRY, but hci_dev_test_flag() > checks hdev->dev_flags instead of hdev->flags. HCI_INQUIRY is a bit that's > set on hdev->flags, not on hdev->dev_flags though. > > HCI_INQUIRY equals the integer 7, and in hdev->dev_flags, 7 means > HCI_BONDABLE, so we were actually checking for HCI_BONDABLE here. > > [...] Here is the summary with links: - Bluetooth: hci_sync: Check the correct flag before starting a scan https://git.kernel.org/bluetooth/bluetooth-next/c/626cef40faf0 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html