Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-907-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <1a3a481b-db1f-4325-8ca7-03f2bc44b2a2@molgen.mpg.de>
Date: Fri, 5 Jan 2024 09:03:12 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] Bluetooth: mgmt: Fix wrong param be used
Content-Language: en-US
To: Clancy Shang <clancy_shang@163.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com, luiz.dentz@gmail.com,
 linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
 zhongjun.yu@quectel.com, Clancy Shang <clancy.shang@quectel.com>
References: <20240105031111.132851-1-clancy_shang@163.com>
From: Paul Menzel <pmenzel@molgen.mpg.de>
In-Reply-To: <20240105031111.132851-1-clancy_shang@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Dear Clancy,


Thank you for your patch.

Am 05.01.24 um 04:11 schrieb clancy_shang@163.com:
> From: Clancy Shang <clancy.shang@quectel.com>
> 
> bluez lib could not receive MGMT_EV_DEVICE_FLAGS_CHANGED notifications
> after sending MGMT_OP_SET_DEVICE_FLAGS

Please add a dot/period at the end of sentences.

Please extend the commit message to describe your fix, and why it fixes 
the problem.

> Signed-off-by: Clancy Shang <clancy.shang@quectel.com>
> ---
>   net/bluetooth/mgmt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index 9dd815b6603f..c74abdf3618f 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -5177,7 +5177,7 @@ static int set_device_flags(struct sock *sk, struct hci_dev *hdev, void *data,
>   
>   done:
>   	if (status == MGMT_STATUS_SUCCESS)
> -		device_flags_changed(sk, hdev, &cp->addr.bdaddr, cp->addr.type,
> +		device_flags_changed(NULL, hdev, &cp->addr.bdaddr, cp->addr.type,
>   				     supported_flags, current_flags);
>   
>   	return mgmt_cmd_complete(sk, hdev->id, MGMT_OP_SET_DEVICE_FLAGS, status,


Kind regards,

Paul