Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp1244237rdb; Sun, 7 Jan 2024 10:03:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+48NY7V48NqSkGKPX4jZwXfCb9zQTmDI50bTbvvgk4Xe2Elkw68uhTbJ5XzKsuZdhPZop X-Received: by 2002:a50:955c:0:b0:557:1e56:c2cb with SMTP id v28-20020a50955c000000b005571e56c2cbmr1826660eda.69.1704650598893; Sun, 07 Jan 2024 10:03:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704650598; cv=none; d=google.com; s=arc-20160816; b=uJcR7QbDQeFhkpMVqcST9pqywM16mwcc+ptj/TU8L2gKX5aTv+so2sZSJ7d7GMj6H4 Dn93Qq8ibuhh72DnHuDx3/vSTtzI4L6PrIAcR+bAmg7ZghLHWZ63fYUw8RlNXZ6Z8+aa YbL88nMaQlFnJC5jh1RHhz7gHIkZU8g7ujLi6zWQ3WzZTlxYv0Pvi36jW5LOwafXLkPD fm/1W1Tw7IsI5GBIUwoEmogQhER83Ybewf2ckYNwTaKeWHLNnT60RgqdybMUW9/PFRQD ywGHMsC3S7ByCRkHPuvbLMDmku/Mh/udNyzAO7JYsjUC667djO7Rqo8QgwU1JYp2pXYp BPSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=hDuKnzfq3Kpgl1DEAfQy4oAPxDC2m6iLWDbEmf7x1Uw=; fh=S5rf2bc7VLlSXYQ0EqFAIodb1qEiUfsxulvZhQKZRws=; b=u91scqp1Ip0njQxA4ykeQ9Bxzkc7LJwVHZ9OGOJ6SVElpQ2zZ4Bo/fkYGRA+VMavXl PvjeqWiAMYiTtqXnW7dEHU/QknfRljE8Q6nqXhJBYrApnEu0sm9H/IUZeCVrT3pIgz/u r3RTqM8vbDD1AXNtQca5U4YyYpwvzJ8LjcF9OM8e2UmAU6kaCFtS5OiL0/vT/FoPMp3T 9BuIfqO4h7yH1rsO1YWsAs3YA1MlR7y7DEM64ajboQAFRMReE7AQacdQKZcPkvWLSYv2 wLPsgN0M7o4pJILng4Yrti1nioL6oTkz6ub7KnGXUg932zaFnizmof68kdVFQSPhq4GS B7+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-bluetooth+bounces-936-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-936-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ee4-20020a056402290400b0055402722c15si2434786edb.186.2024.01.07.10.03.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jan 2024 10:03:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-936-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-bluetooth+bounces-936-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-936-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9729B1F21689 for ; Sun, 7 Jan 2024 18:03:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2C03213FFA; Sun, 7 Jan 2024 18:03:11 +0000 (UTC) X-Original-To: linux-bluetooth@vger.kernel.org Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB43313FE9; Sun, 7 Jan 2024 18:03:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=v0yd.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=v0yd.nl Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4T7Q5t1ScCz9stL; Sun, 7 Jan 2024 19:02:58 +0100 (CET) From: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= To: Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz Cc: =?UTF-8?q?Jonas=20Dre=C3=9Fler?= , asahi@lists.linux.dev, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v3 0/4] Disconnect devices before rfkilling adapter Date: Sun, 7 Jan 2024 19:02:46 +0100 Message-ID: <20240107180252.73436-1-verdre@v0yd.nl> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Apparently the firmware is supposed to power off the bluetooth card properly, including disconnecting devices, when we use rfkill to block bluetooth. This doesn't work on a lot of laptops though, leading to weird issues after turning off bluetooth, like the connection timing out on the peripherals which were connected, and bluetooth not connecting properly when the adapter is turned on again after rfkilling. This series uses the rfkill hook in the bluetooth subsystem to execute a few more shutdown commands and make sure that all devices get disconnected before we close the HCI connection to the adapter. --- v1: https://lore.kernel.org/linux-bluetooth/20240102133311.6712-1-verdre@v0yd.nl/ v2: https://lore.kernel.org/linux-bluetooth/20240102181946.57288-1-verdre@v0yd.nl/ v3: - Update commit message titles to reflect what's actually happening (disconnecting devices, not sending a power-off command). - Doing the shutdown sequence synchronously instead of async now. - Move HCI_RFKILLED flag back again to be set before shutdown. - Added a "fallback" hci_dev_do_close() to the error path because hci_set_powered_sync() might bail-out early on error. Jonas Dreßler (4): Bluetooth: Remove HCI_POWER_OFF_TIMEOUT Bluetooth: mgmt: Remove leftover queuing of power_off work Bluetooth: Add new state HCI_POWERING_DOWN Bluetooth: Disconnect connected devices before rfkilling adapter include/net/bluetooth/hci.h | 2 +- net/bluetooth/hci_core.c | 35 +++++++++++++++++++++++++++++++++-- net/bluetooth/hci_sync.c | 16 +++++++++++----- net/bluetooth/mgmt.c | 30 ++++++++++++++---------------- 4 files changed, 59 insertions(+), 24 deletions(-) -- 2.43.0