Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1068-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	iulia.tanasescu@nxp.com
Subject: [PATCH BlueZ v2 1/2] shared/bap: Fix dereference of null pointer
Date: Fri, 12 Jan 2024 18:56:00 +0200
Message-Id: <20240112165601.134073-2-silviu.barbulescu@nxp.com>
In-Reply-To: <20240112165601.134073-1-silviu.barbulescu@nxp.com>
References: <20240112165601.134073-1-silviu.barbulescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VVWfVG6qsE+AhaZlY+aAWo0Z39rHksCUfYyDauSXlzwcww6keto723hZn3r8?=
 =?us-ascii?Q?Au9Y+KD6WqIhfc2amRZW8Ga21sw4P91dmDn26PAtsyoiI/YaLv7qffmsZxi2?=
 =?us-ascii?Q?oJXJkrKwrVJ9neAuO+yi+6wE0X8hY2a0hDoLfNGutlPoIruCsah+Wn2M6euj?=
 =?us-ascii?Q?L9cvnINxhm2LbGNNmiFbsyrmYuWMQkmq9VyU4xakcIwVz6RRooVdgtLrYXkO?=
 =?us-ascii?Q?4lrCun0SZaI+ta7jzjiROa9fex6YySxSH/K0a90Ty9ehDFjPogwGBwPBwxWN?=
 =?us-ascii?Q?bkhTxezjrkqlZq/IaRUXAeRP4fUd3WScXbYhdYJCYd7CgS75lFpL6bg48Nai?=
 =?us-ascii?Q?c+9ARH74CMLdVSy3oAvOudSj3GRi0NRQpwKfOg9o+X00LZ7cjzpJsC0Zjwyd?=
 =?us-ascii?Q?qYATPNnq0ZpZsH1ky+VILUdxvEqejzBIABizTUvelhmM1ZuHULRP6rAzv2xE?=
 =?us-ascii?Q?JrrhHcGNQ46q5Woda0gD7bKuWGwGPfkCoCzwhO0pylO6R1FpJOBur/OMaGbb?=
 =?us-ascii?Q?K0mRKx24cWLbDBZTCWymvsf+FBfZeUkaIytb9gpSNHybNN6bPmzDpUflbdjY?=
 =?us-ascii?Q?7J1mGQ3ABtx3SK9x+BFBYyVbZbxyqDiOIz9bnFmji5gurU++2yIijQQcwl2b?=
 =?us-ascii?Q?DY6oVSw0MDrqCBGG/KfwckwM4nD3pXJsk4+7FfcT2d0aD8eaAhAcNbv5LO3b?=
 =?us-ascii?Q?bKO4HwPEew6Li5vKFs4w7e9nzj4kJTKCSDOz0UcZS6iPZTesAkch2sCeB4Dy?=
 =?us-ascii?Q?zpQrv7g+G+JbWwT7gx236y88VVQOjSzDGEkS4KL/c9f41AypOVf+mdFUnIdd?=
 =?us-ascii?Q?UZa86H6lmcNfZ3qxKppUBmBBtms9VSoOsZXWpRZAPSW79WsaqdgnOE3IWRPV?=
 =?us-ascii?Q?G9KUl2lj/nUA4xX5RTkGZ6cx6V4sQ/BgOUe0rRfCGeicRIfk7WVXg+ov2/Ud?=
 =?us-ascii?Q?HUhGrl2zIbTuzH70BLSDKUun1V06Y1012Alcc64YJAWcRbT6+zMXePgt89S0?=
 =?us-ascii?Q?Qv6vD7RL6RU5bI1nppkcESgJ/spKYN0OPqCeqCTdYMBya9TcTzReezj03vxW?=
 =?us-ascii?Q?+ioOwvhLWdt6CO3lRXBog3ro2qUND6QxbwKQVofghcfnWTx8KH7CiGwGZ6GC?=
 =?us-ascii?Q?/hnFyKVl67/BMzlPGAlssQGScli1NewpwrIB1zflvGOccYNg3RvBRgClsarj?=
 =?us-ascii?Q?i/Pl7Zf31ygFC1DydtjFk+Up1GoT69J9jFqT5uBnaZwzTA98idzcoDR04mm0?=
 =?us-ascii?Q?IPyn16lYLa4p/2D7BTccLUzN4eciklcloQl6Fbc9JYYZNJqoTe2614B1snOR?=
 =?us-ascii?Q?IzVTy8wvi/c24cXWAgVHhpq+1yTRQb/JFDLABlzeTbaQ8AYW9EPEboRO+cIp?=
 =?us-ascii?Q?3G4kcqoXO0haU/BSwaIhOraJbR7rZc1YL6qE/Rc2ZyRNK73uohjK7MOz+iqQ?=
 =?us-ascii?Q?+Pn0MBwbzfQsOqFd4KdJStd/nDr8YouLuNTzAtbU1QS5OU8pd+7C/Xi13aWy?=
 =?us-ascii?Q?5Y5Q1Uq7IX8WK2NXJ/fcOpL71R4MJA4v22LPhxepxwXZc77UK/VMD+WpBsk4?=
 =?us-ascii?Q?zinB1O3WQrMK/13rs68S7Sz6cvI3/YXkpfjO8OZGzxtI5xM/IHeq46D1hRK9?=
 =?us-ascii?Q?ow=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5177225f-d8e6-4409-226e-08dc138f5f39
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB10073.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 16:56:07.9953
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hz5pCgpiM3mglvQEt3z1+YXL81Nue8hf81TqaP2w2WossLnU9umwjaG4OUsAb6OX4RXkqJE8vGq5kp/o8SGIv6M//J2dSNMvr7XxkPHgL6U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9568

Fix ScanBuild error: Dereference of null pointer
src/shared/bap.c	bt_bap_stream_new

---
 src/shared/bap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 078d308dc..49eb8d057 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -4763,7 +4763,7 @@ struct bt_bap_stream *bt_bap_stream_new(struct bt_bap *bap,
 			return NULL;
 
 		bt_bap_foreach_pac(bap, type, match_pac, &match);
-		if (!match.lpac)
+		if ((!match.lpac) || (!lpac))
 			return NULL;
 		if (!match.rpac && (lpac->type != BT_BAP_BCAST_SOURCE))
 			return NULL;
-- 
2.39.2