Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1081-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Silviu Florian Barbulescu <silviu.barbulescu@nxp.com>
To: linux-bluetooth@vger.kernel.org
Cc: mihai-octavian.urzica@nxp.com,
	silviu.barbulescu@nxp.com,
	vlad.pruteanu@nxp.com,
	andrei.istodorescu@nxp.com,
	luiz.dentz@gmail.com,
	iulia.tanasescu@nxp.com
Subject: [PATCH v3 1/2] shared/bap: Fix dereference of null pointer
Date: Mon, 15 Jan 2024 00:41:03 +0200
Message-Id: <20240114224104.37716-2-silviu.barbulescu@nxp.com>
In-Reply-To: <20240114224104.37716-1-silviu.barbulescu@nxp.com>
References: <20240114224104.37716-1-silviu.barbulescu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?rel1ExUKHQn4xS/DuEb3hZ3kFAhgHJxWo9+1TKsNeAc1TzVd01sw9/xHNq8/?=
 =?us-ascii?Q?MBcm85DrN9tj76SvLlnUfO2H8boraNsE4pPyZKvTHwaisiCoMh/jjNL6u9cw?=
 =?us-ascii?Q?0O729R9i7An9J4WV7uTwMOUr/UYgw0f/fy2ZoD3QqolOkXyvkelmSRqcQad+?=
 =?us-ascii?Q?i+j/k4O1RN52jWjL2M0YixB6m7tYSXPuyirhd28PgZGXENe0CSkjZQtQoLEf?=
 =?us-ascii?Q?kgNqUv0jicQLCY6zg3Bmn4LpryoUPLbfiHHPncTlV6BXe0ywEgYhyK51TDfX?=
 =?us-ascii?Q?0X3Pu+BuL6r96r8po6GpKs4RNcYMQPuJni50tVt+LGzbmxHFB/G2ynaN8A17?=
 =?us-ascii?Q?KW2Qs8Pg6bD5QpgRdn+tOxTKzOqCLbFLezWhqPmqq7jb4oUr94q4/nK5my4b?=
 =?us-ascii?Q?84NGXOEsZf+3A+khk+g0yURKMwa7q0+kS1BjH7A+DZQJ051qZ0qhuS4r4tDh?=
 =?us-ascii?Q?GCggexRfbY4+jDC8iMS8wQio1+8MyrGmJJxvSXcZ8AaOfqXMBDipWT2WWunj?=
 =?us-ascii?Q?lWYQarQWiUHiw2tijsWGsj/LHQR07EvP5uli+Hg6FfVuIPpJZxwUDtPCS0Ms?=
 =?us-ascii?Q?cYdsGguIMaBlIbPMwsTQ+zSk5RIYdCmQoNaGdOiaTCV2ypb+t5fXJCDx7/JQ?=
 =?us-ascii?Q?6Q8znpnlG08qiWcfs1TRQ9z3xHEk4v3s3/WnnDHtwi8vUfsn+BGHxq92SmYw?=
 =?us-ascii?Q?IHlCBmv8/QVapb4Ha35wBWUzwfF0/30jrU/W0T/CYmpNPKcBXzWQ2e0fSrYa?=
 =?us-ascii?Q?ZMglU/YwJkfghbSjcwfWYtIuzUTE30iA8qIwTKtInjctnIhqHsB/tT+mTBuE?=
 =?us-ascii?Q?vQo/XTv9IlqNh9KpJ+B9clWkPXd5HeFrBUS6zeISBk4H2G4bUlqzPOeJCSyI?=
 =?us-ascii?Q?W8017l+a3nYWN8ufBrBdruD2UYP5+wZGeC7XoFyoqmL5vAel603oOsuV2yY0?=
 =?us-ascii?Q?WOt/XzbBRHcV+v/ZVGzZbaXy6Cd3veTn85MkzzTczFwjzEXA2tq4WKjnaG0T?=
 =?us-ascii?Q?W6MdjFDNUkyLMw8J0wTb7mQ5yNAnLzZdy5jTkpTHbIfQWMLMi8zMmmzRjyuN?=
 =?us-ascii?Q?zB2xDijtUgMGmF7vVyKY/YkH0FpYakvCGR44vfbiTtwqaI6w8yE9UR3Payqt?=
 =?us-ascii?Q?hfvfUCh7f+U1/lcWfqHXGibNLUfi8u++ovoTG8ufo1dSeHoAHJJGVCFwxdd7?=
 =?us-ascii?Q?qDqteYPEf/Yvpo22D3BXcAJeM9vuFnL7K45+zhvYNzyztsgy02xG2WbcxHjK?=
 =?us-ascii?Q?y24Ndr/A4tfHAtdNymrrHmWUVAqGofMSusDwCBljYJdGFm1A18G6vxO/09i+?=
 =?us-ascii?Q?uggnD9/n6oarwLIMfVJ7boE+lkcTVKFJPM6Bh/QFkZH6o6oxl1hKU9n0hZry?=
 =?us-ascii?Q?tTr+7iD84bmLjBTaeffanEV2bgOfIqWpjIYaRX8rtV3Jn8CkjaBvJZXcMoJb?=
 =?us-ascii?Q?oly+BVLUXgWUW7Th+zi/jibM/+ea3NDg0XLojVMLUqfXBFb7j1EYkbiSCgAS?=
 =?us-ascii?Q?ZUihJ0ZhH9PTMuU9pmcgjCzld7/s6BQIG3uOVQEG4jSTgdSC/XUvs8YNsGUP?=
 =?us-ascii?Q?8mc5WR2h0/IACAUWJ4vP+3vT75+Q7ebyldqVH9UACodW4/YfKBbDtAqO7XFx?=
 =?us-ascii?Q?5Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 894c3d19-e235-42b0-d089-08dc1551e77e
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB10073.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jan 2024 22:41:10.1491
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ackifmN1XLcQ5+QCiBH0OmHEYUkMZull366NadRMDHh4zkvBKdSO+384ft2yn7HTzpOWq/pHaxVsLFcW4kHvJBpZhMnGjAbrnwgqEos9YRE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8961

shared/bap: Fix ScanBuild error: Dereference of null pointer

---
 src/shared/bap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/bap.c b/src/shared/bap.c
index 078d308dc..49eb8d057 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -4763,7 +4763,7 @@ struct bt_bap_stream *bt_bap_stream_new(struct bt_bap *bap,
 			return NULL;
 
 		bt_bap_foreach_pac(bap, type, match_pac, &match);
-		if (!match.lpac)
+		if ((!match.lpac) || (!lpac))
 			return NULL;
 		if (!match.rpac && (lpac->type != BT_BAP_BCAST_SOURCE))
 			return NULL;
-- 
2.39.2