Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1137-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240116-autofoo-v1-0-626f6b54bd06@gmail.com> <20240116-autofoo-v1-4-626f6b54bd06@gmail.com>
In-Reply-To: <20240116-autofoo-v1-4-626f6b54bd06@gmail.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Tue, 16 Jan 2024 13:40:18 -0500
Message-ID: <CABBYNZJUhmVUNGTsqspc3S802pDwikFf2YOPupESD1m5T-GsJw@mail.gmail.com>
Subject: Re: [PATCH BlueZ 04/10] build: remove dummy {conf,state}{dir,_DATA}
To: emil.l.velikov@gmail.com
Cc: linux-bluetooth@vger.kernel.org, Emil Velikov <emil.velikov@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Emil,

On Tue, Jan 16, 2024 at 8:52=E2=80=AFAM Emil Velikov via B4 Relay
<devnull+emil.l.velikov.gmail.com@kernel.org> wrote:
>
> From: Emil Velikov <emil.velikov@collabora.com>
>
> The project does not install anything in the respective confdir and
> statedir(s). Since no files are installed, the respective folders are
> not created either - systemd will create them prior to starting the
> service(s).
>
> The *dir variables themselves are no longer used in *service.in, so
> remove everything.
> ---
>  Makefile.am | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index e738eb3a5..16d6bf160 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -28,15 +28,9 @@ AM_CFLAGS =3D $(MISC_CFLAGS) $(WARNING_CFLAGS) $(UDEV_=
CFLAGS) $(LIBEBOOK_CFLAGS) \
>                                 $(LIBEDATASERVER_CFLAGS) $(ell_cflags)
>  AM_LDFLAGS =3D $(MISC_LDFLAGS)
>
> -confdir =3D $(sysconfdir)/bluetooth
> -statedir =3D $(localstatedir)/lib/bluetooth
> -
>  if DATAFILES
>  dbusdir =3D $(DBUS_CONFDIR)/dbus-1/system.d
>  dbus_DATA =3D src/bluetooth.conf
> -
> -conf_DATA =3D
> -state_DATA =3D
>  endif
>
>  if SYSTEMD
> @@ -747,9 +741,7 @@ MAINTAINERCLEANFILES =3D Makefile.in \
>
>  SED_PROCESS =3D $(AM_V_GEN)$(MKDIR_P) $(dir $@) && \
>                 $(SED) -e 's,@pkglibexecdir\@,$(pkglibexecdir),g' \
> -                      -e 's,@libexecdir\@,$(libexecdir),g' \
> -                      -e 's,@statedir\@,$(statedir),g' \
> -                      -e 's,@confdir\@,$(confdir),g' \
> +                      -e 's,@libexecdir\@,$(libexecdir),g'
>                 < $< > $@
>
>  if RUN_RST2MAN
>
> --
> 2.43.0

This one seems to be causing some build regression, when trying to
apply it breaks the builds.

--=20
Luiz Augusto von Dentz