Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1160-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
To: Francesco Dolcini <francesco@dolcini.it>
CC: "marcel@holtmann.org" <marcel@holtmann.org>, "johan.hedberg@gmail.com"
	<johan.hedberg@gmail.com>, "luiz.dentz@gmail.com" <luiz.dentz@gmail.com>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>, Amitkumar Karwar
	<amitkumar.karwar@nxp.com>, "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Sherry Sun <sherry.sun@nxp.com>, Rohit Fule
	<rohit.fule@nxp.com>
Subject: Re: [RFC PATCH] Bluetooth: btnxpuart: Fix nxp_setup in case chip is
 powered on late
Thread-Topic: [RFC PATCH] Bluetooth: btnxpuart: Fix nxp_setup in case chip is
 powered on late
Thread-Index: AQHaSSj19sN+8TuMTk2XZIqniCJI4Q==
Date: Wed, 17 Jan 2024 09:38:43 +0000
Message-ID:
 <AS4PR04MB9692991FC87A8FF21E455BC8E7722@AS4PR04MB9692.eurprd04.prod.outlook.com>
References: <20240117030501.149114-1-neeraj.sanjaykale@nxp.com>
 <20240117090932.GA3787@francesco-nb>
In-Reply-To: <20240117090932.GA3787@francesco-nb>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Io5qTITzwNIWkaL5ZltV5ozkPmFIKJofaUKd4RU5Hs1RA35bWysXAl5Vs7+/?=
 =?us-ascii?Q?Zg/m+t1hvKCHbGryYulZW+8hkqPe3xcYByKcBcUiPpulSA2/9jPoC02ulItc?=
 =?us-ascii?Q?dVRoKro5f03hjAZ81micE1tq9J2HW2pcgiZ/cWuixYeVf1P/qBjy2H4k6Tq3?=
 =?us-ascii?Q?56Rag/kgE6DhQNkztD3tw6sFaOPSrxq7P0y0QCIKLG+Fkn2qs7fnGfji5CId?=
 =?us-ascii?Q?tMZx5t1ObuJAZpY/ByD9dWeEjaJ8rO2Y7Vs+BtqrdeCYWpXBuNyQ8+MXyPSb?=
 =?us-ascii?Q?VY8uSiDBXH72ELQ0OFsribqy5u86S1OyDU+U1cKF7nDisoVnw6vR3dTu8541?=
 =?us-ascii?Q?uS+jzMdmt9C3DgiKuNN9IcL5Jbhbo6uiDsSGkrk6AW1oFu/OlushDgae2Ory?=
 =?us-ascii?Q?wq2inU3ZrI59GOK4OgeqpOkJzuZadas/ftBPp/J5vw6luDrzm00HD7cQSUff?=
 =?us-ascii?Q?UV6jZqOxZKFX8+DCfgbHAqbfGXOhpUiEylDC/CkNHxgVykPEmvLa3bHrrLyX?=
 =?us-ascii?Q?uL3a5c8rRQum93jA+V4byqUmnhcgvgoy3iueyZ805CrfOorFVvOpGLIKy2IQ?=
 =?us-ascii?Q?q4lizbbt8IAo8T9PClSBb7FCFnvnBp+ajyNSlVdZgKU2+f8OEa/xe5QKDzMD?=
 =?us-ascii?Q?gxNjaWYMw6rvzxvalo8AKXNjqdeQ36qxPztpOReyamwiDWkf7WTYWNgIJgkJ?=
 =?us-ascii?Q?z79YKAfsxOIajIITT0nVNyuEFpqWoBH23L3p1wEQv8dd8OaLGcYaixDXFLei?=
 =?us-ascii?Q?ZUwYztanDxr0mhDCcM0KSgK7r/xBfgyCfKnTum/GchzA5EbmQZ8fqzMX3P6t?=
 =?us-ascii?Q?/j3GhFfq2pmhARd3RLtXuxtNUI2NJre2NvIokb5VHp+s1QKSsKzdmEu+nbk4?=
 =?us-ascii?Q?Kg4PyiRhbPPcVnt6XFw35W+Ubgf2wGsoxtwBk6dKTRXyHSwMtCPmj8HCCJ0W?=
 =?us-ascii?Q?nz7m/Cf4Mzag/j7i9aVNXbaBDbOtGt+Pu/U6/8gfCitpki+3XSpbJvh242RU?=
 =?us-ascii?Q?IqrYv5uaf5tsJmZG6QGfdn1gHBFPTjnpBqNP33Goz8+ez/hPIqMn5/Z4R8DV?=
 =?us-ascii?Q?rKk4NQjVXiTqc6fFO3ogh5/tdycy/mjKhldIaWA0txfKRh/VKFM9ABgCmx0+?=
 =?us-ascii?Q?EQSjsQexl0JJLXRypQuDj6ahA3KKJ0dWbDf6d9Y63WT3/YpgOhNfQObWqmOR?=
 =?us-ascii?Q?/Vx9man7Ws04THLGp13bXQhXqmOvpHceF2x0yvwwGbtDdyUSDMjdo+NHujX7?=
 =?us-ascii?Q?GjirPqLfb5cyQzfakD+MsnnU5d4VNioFuBeH4ujh8Ih1EiEhWbmemnI6bUBi?=
 =?us-ascii?Q?nET+m84J/YV9ZQ2lPR0BXPg6rgsd3KX3MJ06eWksRM1j/JQZO5b9f5w5DIBW?=
 =?us-ascii?Q?1Ym/2hnfpfhhD+oUoygl5jz/g07u4Arm9i8p3GWZRaEftGbjJdkHKrouCa3/?=
 =?us-ascii?Q?Cnt4eWtoPCxS8FFvVNwwzcvO065WIpT9q1Fc0jgQgGnPAjt80JTpwfkVXAgt?=
 =?us-ascii?Q?K++SeQ1w4NNJvzm2NtFAUZnP8tcJr9mOuE9WJnClo0hRT4e/KtpE/jeilrXy?=
 =?us-ascii?Q?VUsW6W6jsaYe4xEZxSqX6BpewhFhU4t02x2o35Qe?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-bluetooth@vger.kernel.org
List-Id: <linux-bluetooth.vger.kernel.org>
List-Subscribe: <mailto:linux-bluetooth+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-bluetooth+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS4PR04MB9692.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f4f7fcee-348f-4802-1022-08dc17401862
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jan 2024 09:38:43.4081
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +KEhh2IiqXkJSRAAYtAdsBtp7DiwjyY9Lmwq64NS3Bdirr1MFFxaCz2798rui/LfBSpoLmKBhomgW3PLtSN+TWFdElpLMEpwiwqntNf74nY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7010

Hi Francesco,

Thankyou for the review comment.

> > diff --git a/drivers/bluetooth/btnxpuart.c
> > b/drivers/bluetooth/btnxpuart.c index 7f88b6f52f26..20a3a5bd5529
> > 100644
> > --- a/drivers/bluetooth/btnxpuart.c
> > +++ b/drivers/bluetooth/btnxpuart.c
> > @@ -1036,6 +1048,13 @@ static int nxp_setup(struct hci_dev *hdev)
> >               err =3D nxp_download_firmware(hdev);
> >               if (err < 0)
> >                       return err;
> > +     } else if (!serdev_device_get_cts(nxpdev->serdev)) {
> > +             /* CTS is high and no bootloader signatures detected */
> > +             bt_dev_dbg(hdev, "Controller not detected. Will check aga=
in in %d
> msec",
> > +                        NXP_SETUP_RETRY_TIME_MS);
> > +             schedule_delayed_work(&nxpdev->setup_retry_work,
> > +                                   msecs_to_jiffies(NXP_SETUP_RETRY_TI=
ME_MS));
> > +             return -ENODEV;
> why not just
>=20
> return -EPROBE_DEFER;
>=20
> and remove everything else, no need for any kind of retry or delayed work=
 if
> the driver core takes care of it.
>=20
Wouldn't returning -EPROBE_DEFER make more sense in driver probe context?

Here, the driver probe registers an hci interface (hci_register_dev()), and=
 returns success to kernel.

The hci_register_dev() queues hdev->power_on work at the end, which opens t=
he hci dev, and ultimately calls this setup function.

In this patch, we are queueing the same work from the delayed setup_retry_w=
ork().

Returning -ENODEV (or -EPROBE_DEFER) would only affect hci_dev_open(), whic=
h is in power_on work context, and not driver probe context.

Perhaps, we should call it hci_retry_power_on() work or something similar?

Please let me know your thoughts on this.

Thanks,
Neeraj