Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1173-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240117222317.1792594-1-luiz.dentz@gmail.com> <20240117222317.1792594-2-luiz.dentz@gmail.com>
In-Reply-To: <20240117222317.1792594-2-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Wed, 17 Jan 2024 17:36:10 -0500
Message-ID: <CABBYNZK4ODoPDy20jk48tPW8rnAgLdOMrhdkgMPeanSLz-x-mA@mail.gmail.com>
Subject: Re: [PATCH BlueZ v1 2/2] transport: Print owner information when it
 exit or release
To: linux-bluetooth@vger.kernel.org
Cc: Pauli Virtanen <pav@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Pauli,

On Wed, Jan 17, 2024 at 5:23=E2=80=AFPM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> This prints the owner name when it exits/quits/crash or releases a
> transport.
> ---
> - Looks like there is a bug/race on codec switch it appears the likes of
>   pipewire attempts to call Release in the process which stops the
>   acquire/resume:
>
>   bluetoothd[1774429]: profiles/audio/transport.c:transport_set_state() S=
tate
>   changed /org/bluez/hci0/dev_94_DB_56_F7_F2_88/sep1/fd8: TRANSPORT_G
>   bluetoothd[1774429]: profiles/audio/transport.c:media_request_create()
>   Request created: method=3DAcquire id=3D50
>   bluetoothd[1774429]: profiles/audio/transport.c:media_owner_add() Owner
>   :1.133105 Request Acquire
>   bluetoothd[1774429]: profiles/audio/transport.c:media_transport_set_own=
er()
>   Transport /org/bluez/hci0/dev_94_DB_56_F7_F2_88/sep1/fd8 Owner :1.5
>   bluetoothd[1774429]: profiles/audio/transport.c:release() Owner :1.1331=
05
>   bluetoothd[1774429]: profiles/audio/transport.c:media_owner_remove() Ow=
ner
>   :1.133105 Request Acquire

I wonder if we have a regression on BlueZ or PW for A2DP, since I
recall this used to work just fine while switching codecs back and
forth, but today it didn't work at all for me and I had to reconnect a
couple of times to get it working:

>pipewire --version
pipewire
Compiled with libpipewire 1.0.0
Linked with libpipewire 1.0.0

pw.node: (bluez_output.94_DB_56_F7_F2_88.1-70) running -> error
(Received error event)

>  profiles/audio/transport.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c
> index a4696154aba5..5395985b990f 100644
> --- a/profiles/audio/transport.c
> +++ b/profiles/audio/transport.c
> @@ -531,6 +531,8 @@ static void media_owner_exit(DBusConnection *connecti=
on, void *user_data)
>  {
>         struct media_owner *owner =3D user_data;
>
> +       DBG("Owner %s", owner->name);
> +
>         owner->watch =3D 0;
>
>         media_owner_remove(owner);
> @@ -742,6 +744,8 @@ static DBusMessage *release(DBusConnection *conn, DBu=
sMessage *msg,
>         if (owner =3D=3D NULL || g_strcmp0(owner->name, sender) !=3D 0)
>                 return btd_error_not_authorized(msg);
>
> +       DBG("Owner %s", owner->name);
> +
>         if (owner->pending) {
>                 const char *member;
>
> --
> 2.43.0

It seems you PW calls Release after Acquire, not sure if it didn't
like our response to Acquire or something.

--=20
Luiz Augusto von Dentz