Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp7218rdb; Mon, 22 Jan 2024 10:07:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IF/vyHE3Nh4KsUq25j6GPDGp1la7UvXd2KVjfSIgMfq+iR9jdec29tOR2w7D52+mivZ4cDo X-Received: by 2002:a17:90b:124c:b0:290:62:8480 with SMTP id gx12-20020a17090b124c00b0029000628480mr1304071pjb.67.1705946861138; Mon, 22 Jan 2024 10:07:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705946861; cv=pass; d=google.com; s=arc-20160816; b=b8kdzGIr0cUwdB1GRF7gJPIteOuwlS4xZWyNQtMOZSkfbznaOcAE9LSSl+Z/H6hgWE z5P69T/YWdTjv641Bgs0u0pPHPeIhvu2MPfMf3XVyT7iqIQ9bCMs51S/86xfiXuyOpA6 NyeLpDXjZI9gZUDhLvxChrhVBdMQGqrGkzct4WJBnm4PveCkwf54Jh8qaJHcfRvVd+lt z/Tf8UDLGj3+cSQ35rMNztqizu0CvsuMH0tg/NxiKKg7tMSCO/LNqc9lgq5fXFR+iK9E ocP3O8w+Om9YHLfBHI5a7fdbvrn5KPRcbm8mBYTkvijuJcF75zkZzy3b1fgKVoG6Zx7E ELKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:to:from :dkim-signature; bh=GyuZS0nuaGUOHoOcC2BSOxgof9Ll8KYegT8UdLhrH5A=; fh=4lGQI6056MBa4/oovMyIYaKLn+Wz/24RGvUivMmQP8E=; b=BbsbD9uwLFD6HurSnZ0Ezhz/4IcwJGtehE3Mifa6eH7i+W18Jvfe+MD97+XUWEeFIs PFuOr9jzM+5cIpfXAZdigfvvI+ocQRGbX5Px502ClYRYlWc8McEganaE67iKUp1ZMVaZ JdRZxM/Tfzn0CmVmWeaJY19HmPD79aaURDC9s0aixLYZaNVniAU1pWONbpJz4pK7Lw2d Cqr3pgsLGlECroEYGwF6g+jVFp28nCRGmQs6H5CQR4F9jnfybzcKSBE+zybu/8PUK6PC Lzwp4h2pkW71kNbuGysl+6xDRSs5N5Kz8rV0zDudXadHbbUjpFeu6o7YDBrSpCvK/cHH 5Mlg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kpi3uDdi; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-bluetooth+bounces-1224-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1224-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id r2-20020a17090b050200b002907dd9f69bsi3566917pjz.143.2024.01.22.10.07.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 10:07:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1224-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=kpi3uDdi; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-bluetooth+bounces-1224-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1224-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 94F66B26F4B for ; Mon, 22 Jan 2024 17:16:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47E644E1A7; Mon, 22 Jan 2024 16:05:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="kpi3uDdi" X-Original-To: linux-bluetooth@vger.kernel.org Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4489A64A96 for ; Mon, 22 Jan 2024 16:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705939503; cv=none; b=KlK9kcb1B+kDb4i+VHkb/rMmUrQ7otIBV2yP4UgxBKKySKKXRjHeyNpElJLxmFw+GBiFMvfOmx3RqqrAQ3pXimcmsRkGJwhn8VuX7Pjz339VrRzjML1pgmC0h8wX0uprYD8ZECtde2nKFw0W+SciHNyDsfi98fG9fxuQfUlISUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705939503; c=relaxed/simple; bh=vZ3u219SkU5oVGHBkp9Sjp2g/zobncmCdXb4FGQnXy8=; h=From:To:Subject:Date:Message-Id:MIME-Version:Content-Type: Content-Type; b=at3vq9dwqBYNkQx4i9dY7tUN6Pe/m4O5FyDNXodab2yIsyxyQU0XxEeQB3s4Nyl9rtAonZurxJT5L08YWsX34mtSOJFqa52+ytq5Tfl7xa1WG42ifWDtDN6d6j+Q7U/mcP6pVE2ceeFhz4opHE7CYYlNNGSCKwp32SEARRapL30= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=kpi3uDdi; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1705939499; bh=vZ3u219SkU5oVGHBkp9Sjp2g/zobncmCdXb4FGQnXy8=; h=From:To:Subject:Date:From; b=kpi3uDdiTi5MNd2JRNKGBCLXLrQQ4cbsbvj+kCarjXkajQNXgKZYETUIVu/rdqrhI /MSbhVhYFWztN8ikZO0M2V5+HdgxwM3fWgJ03IRv6jCi8A9067WIZPNloXGt8AwK5t U0wRabC4bKxa5RzizBo1k2hmtnMtNO30bqr25SZAxqoBxsaee596Jd/+xbUqY8dbgH kP+nhwxy/kjuypb1WXvr0DEsBf6Su4p6wewZpbPhpCfVk4dJH4hJ4x7Zj0zb/hgLAK lCeX2MErZ/bTeOZ9/Uy2skvcYBAFQz1RTkkqSlUU7dJaLtnXBSfEpVopMgp1X2W+0c +30GbTdOGJYCw== Received: from fdanis-XPS-13-9370.. (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: fdanis) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 418223780029 for ; Mon, 22 Jan 2024 16:04:59 +0000 (UTC) From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Danis?= To: linux-bluetooth@vger.kernel.org Subject: [PATCH] Bluetooth: mgmt: Fix limited discoverable off timeout Date: Mon, 22 Jan 2024 17:04:53 +0100 Message-Id: <20240122160453.270919-1-frederic.danis@collabora.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit LIMITED_DISCOVERABLE flag is not reset from Class of Device and advertisement on limited discoverable timeout. This prevents to pass PTS test GAP/DISC/LIMM/BV-02-C Calling set_discoverable_sync as when the limited discovery is set correctly update the Class of Device and advertisement. Signed-off-by: Frédéric Danis --- net/bluetooth/mgmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index 173986f3405f..c5022c90584c 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -1063,7 +1063,7 @@ static void discov_off(struct work_struct *work) hci_dev_clear_flag(hdev, HCI_DISCOVERABLE); hdev->discov_timeout = 0; - hci_update_discoverable(hdev); + hci_cmd_sync_queue(hdev, set_discoverable_sync, NULL, NULL); mgmt_new_settings(hdev); -- 2.34.1