Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1261-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240116-rm-ext-plugins-v1-0-62990fb07369@gmail.com> <CABBYNZKv+KFAAY-5-LwMdYKDHKtyh3BRbigUv06h_ZBLJPQobQ@mail.gmail.com>
In-Reply-To: <CABBYNZKv+KFAAY-5-LwMdYKDHKtyh3BRbigUv06h_ZBLJPQobQ@mail.gmail.com>
From: Emil Velikov <emil.l.velikov@gmail.com>
Date: Tue, 23 Jan 2024 13:54:03 +0000
Message-ID: <CACvgo535rjwHh1J+kX8L8wYrgZJ0ui4DaLsjDqtptm5XU8dSHw@mail.gmail.com>
Subject: Re: [PATCH BlueZ 0/8] Remove support for external plugins
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, Emil Velikov <emil.velikov@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 22 Jan 2024 at 18:35, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Emil,
>
> On Tue, Jan 16, 2024 at 9:19=E2=80=AFAM Emil Velikov via B4 Relay
> <devnull+emil.l.velikov.gmail.com@kernel.org> wrote:
> >
> > Greetings one and all,
> >
> > In this series, we prune support for external plugins and cleanup the
> > associated code. The inspiration here is multiple-fold:
> >  - the plugins are under linked - generally a bad idea
> >  - the plugins use undefined, unscoped, unversioned internal API
> >  - the main daemons expose their internal API increasing their size
>
> Im not so sure I want to remove the external plugins support
> completely, but I do understand that normally distros don't really
> want to have it enabled in production due to the reasons mentioned
> above, but I think we could find a middle ground here by disabling it
> by default but still let systems to re-enable it if they have some
> custom plugin that they may still want to use as external plugin.
>

Thanks for the feedback. Sure, I can convert this to a "configure
--support-external-plugins", where all the presently removed code will
be compiled out.

Still not entirely sure how external plugins are supposed to work,
considering the API/ABI mentioned earlier - any pointers? Do you know
of any example plugins that you can mention?

-Emil