Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1360-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240125-rm-ext-plugins-v3-0-d141f7870bb6@gmail.com>
In-Reply-To: <20240125-rm-ext-plugins-v3-0-d141f7870bb6@gmail.com>
From: Szymon Janc <szymon.janc@codecoup.pl>
Date: Thu, 25 Jan 2024 14:02:12 +0100
Message-ID: <CAAEJBhKW3XZCZiz6MZ8NbCW61iU0gxL_LGru5y0Ubb_hbGAt_g@mail.gmail.com>
Subject: Re: [PATCH BlueZ v3 0/8] Remove support for external plugins
To: emil.l.velikov@gmail.com
Cc: linux-bluetooth@vger.kernel.org, Emil Velikov <emil.velikov@collabora.com>
Content-Type: text/plain; charset="UTF-8"

Hi,

On Thu, 25 Jan 2024 at 01:07, Emil Velikov via B4 Relay
<devnull+emil.l.velikov.gmail.com@kernel.org> wrote:
>
> Hello everyone,
>
> Here's v3 fixing a small bug with the previous patches, which was
> tripping the CI.
>
> Link to the previous revision can be found below.

Just a comment that external plugins support was added to avoid udev
dependency (from sixaxis) in bluetoothd.
(not that I have strong opinion on this, just a note, I don't remember
exactly why it was done, maybe Marcel recalls?)

>
> Thanks
> Emil
>
> - Link to v2: https://lore.kernel.org/r/20240124-rm-ext-plugins-v2-0-5244906f05ff@gmail.com
>
> ---
> Emil Velikov (8):
>       configure, README: introduce --enable-external-plugins
>       obexd: factor out external plugin support
>       bluetoothd: remove external-dummy plugin
>       bluetoothd: convert external sixaxis plugin to builtin
>       bluetoothd: factor out external plugin support
>       bluetoothd: don't export internal API
>       bluetoothd: change plugin loading alike obexd
>       android: export only (android) entrypoint from the modules
>
>  Makefile.am              |  17 ++----
>  Makefile.obexd           |   2 +
>  Makefile.plugins         |   8 +--
>  README                   |  13 +++++
>  android/Makefile.am      |   3 +
>  android/hal-audio.c      |   1 +
>  android/hal-bluetooth.c  |   1 +
>  android/hal-sco.c        |   1 +
>  configure.ac             |  10 ++++
>  obexd/src/obexd.h        |   2 +-
>  obexd/src/plugin.c       |  93 +++++++++++++++++++++----------
>  obexd/src/plugin.h       |   4 ++
>  plugins/external-dummy.c |  28 ----------
>  src/btd.h                |   2 +-
>  src/plugin.c             | 140 +++++++++++++++++++++++++++++------------------
>  src/plugin.h             |  16 ++++++
>  16 files changed, 209 insertions(+), 132 deletions(-)
> ---
> base-commit: a9d1f6f6a625607de6c3f5b7a40a3aac5f36c02b
> change-id: 20240116-rm-ext-plugins-ba0b852a492b
>
> Best regards,
> --
> Emil Velikov <emil.l.velikov@gmail.com>
>
>


--
pozdrawiam
Szymon K. Janc