Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1413-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: Marcel Holtmann <marcel@holtmann.org>, Johan Hedberg
	<johan.hedberg@gmail.com>, Luiz Augusto von Dentz <luiz.dentz@gmail.com>
CC: Kuniyuki Iwashima <kuniyu@amazon.com>, Kuniyuki Iwashima
	<kuni1840@gmail.com>, <linux-bluetooth@vger.kernel.org>
Subject: [PATCH v1 net-next] af_bluetooth: Don't hold sk_peer_lock in bt_sock_alloc().
Date: Sun, 28 Jan 2024 02:40:27 -0800
Message-ID: <20240128104027.18868-1-kuniyu@amazon.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: Bulk

In bt_sock_alloc(), we need not lock sk_peer_lock because sk has
not been published to anywhere.

Let's not hold sk_peer_lock in bt_sock_alloc().

Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
---
 net/bluetooth/af_bluetooth.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/bluetooth/af_bluetooth.c b/net/bluetooth/af_bluetooth.c
index b93464ac3517..6588654429ae 100644
--- a/net/bluetooth/af_bluetooth.c
+++ b/net/bluetooth/af_bluetooth.c
@@ -159,10 +159,8 @@ struct sock *bt_sock_alloc(struct net *net, struct socket *sock,
 
 	/* Init peer information so it can be properly monitored */
 	if (!kern) {
-		spin_lock(&sk->sk_peer_lock);
 		sk->sk_peer_pid  = get_pid(task_tgid(current));
 		sk->sk_peer_cred = get_current_cred();
-		spin_unlock(&sk->sk_peer_lock);
 	}
 
 	return sk;
-- 
2.30.2