Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1434-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240129114900.92919-1-verdre@v0yd.nl> <20240129114900.92919-3-verdre@v0yd.nl>
In-Reply-To: <20240129114900.92919-3-verdre@v0yd.nl>
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: Mon, 29 Jan 2024 08:41:48 -0500
Message-ID: <CABBYNZKEYUgf0kvsKVMnQio6-eVm3ziCFmPYTGMrzew9qxjiGA@mail.gmail.com>
Subject: Re: [PATCH BlueZ 2/4] mgmt-tester: Adjust a test for recent kernel changes
To: =?UTF-8?Q?Jonas_Dre=C3=9Fler?= <verdre@v0yd.nl>
Cc: linux-bluetooth@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Jonas,

On Mon, Jan 29, 2024 at 6:49=E2=80=AFAM Jonas Dre=C3=9Fler <verdre@v0yd.nl>=
 wrote:
>
> With the changes in the kernel to move to hci_sync for connecting ACL
> devices (see kernel commit "Bluetooth: hci_conn: Only do ACL connections
> sequentially", https://lore.kernel.org/linux-bluetooth/20240108224614.569=
00-1-verdre@v0yd.nl/),
> the "ETIMEDOUT" error path for the "HCI Create Connection" command was
> changed, sending a "HCI Create Connection Cancel" after the timeout.
>
> This leads to the returned error in the "Pair Device - Power off 1"
> test to change from NOT_POWERED to DISCONNECTED, so adjust for that.
> ---
>  tools/mgmt-tester.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
> index ee12ed7d5..7c9e63cbb 100644
> --- a/tools/mgmt-tester.c
> +++ b/tools/mgmt-tester.c
> @@ -3216,7 +3216,7 @@ static const struct generic_data pair_device_power_=
off_test_1 =3D {
>         .send_opcode =3D MGMT_OP_PAIR_DEVICE,
>         .send_func =3D pair_device_send_param_func,
>         .force_power_off =3D true,
> -       .expect_status =3D MGMT_STATUS_NOT_POWERED,
> +       .expect_status =3D MGMT_STATUS_DISCONNECTED,
>         .expect_func =3D pair_device_expect_param_func,
>  };
>
> --
> 2.43.0

We haven't applied all the changes from that set though, are you
planning to resend them?

--=20
Luiz Augusto von Dentz