Received: by 2002:a05:7412:d1aa:b0:fc:a2b0:25d7 with SMTP id ba42csp431024rdb; Mon, 29 Jan 2024 06:48:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IHbIJMEh1U/bvIXJyFNQ89uGwUad0dnzgvFImXhTrdyR1AnS2lWP4cRl5dv7SACGOmiY57B X-Received: by 2002:a05:6358:910d:b0:176:5180:81bc with SMTP id q13-20020a056358910d00b00176518081bcmr3027187rwq.52.1706539685230; Mon, 29 Jan 2024 06:48:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706539685; cv=pass; d=google.com; s=arc-20160816; b=0rnIpB7IKoKcAcoxy9NKb4UI70MSnVDEt0G4HZ144/9iEOVZZFwtMen98nj2zj2ike OyxT5rgjUJNcizlYLHzekKxGkyju7H4HzG4vGLblVMSwfDEN58k3JJP/+pY8pCEScECv ER/zil3RnVn3m3Fy86qQfHVEu6jEN9TGDmt9AHi2UGV4UdPlg1yJHYnby7wH+Qy5Y9ah uaIivJvEHh2eLCNlTWx+A+Lz+IGMT4P73MIQlh9e8B6+r1PoWXezjSIWtTEcvUktG+l/ tY2O8JeuAFzIbea1qAVrhJjLifeC4l2rn+W6POF88YOAjcVX2iQwEC+skT/ZVzoIXtIT 0izw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:cc:to:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:from:dkim-signature; bh=MdhmvP/A933gB56CNSo40Enahmofb7pPKZna8a1XyJA=; fh=wm3knQjNzlzhSYO3l6/R1dJNTO7aXLaAzT309a/t7Bw=; b=IIArSj0wyrL++lVn4chWv6MwNTmnSj9zuqJq3mr69jz0+CUkEadhuIf38b1gmubzfQ t2kQbM4d+T/DGLWsie0BqCGPz8qfW+6rO9pTHv75A2vWtcrC3SgqFKHdbRNS6fJ0GwNs 6fmZaDoonEk4bTZU84YU78CtUx5H1fYHUm2ku0+BRMd1+gi2Yn2U9rT8FTtlZHupfPg0 PYIOXWzKwVd8zzeN6clnDbeSyKvJp91hHtJfvYmjfbtBA7becZgGJARWLaiXQs6TtUYk QYn4ra8oMUvffxu3XaqtWnJywZyxThrThpTLhD+uqoxfQO/n+Flhg4S1bJ/qH3f2BjiM 5diA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="G4XF/KvH"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-1437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1437-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s24-20020a656918000000b005d8bb99ff3asi3633333pgq.780.2024.01.29.06.48.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 06:48:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-bluetooth+bounces-1437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="G4XF/KvH"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-bluetooth+bounces-1437-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-bluetooth+bounces-1437-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1869F281D25 for ; Mon, 29 Jan 2024 14:44:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B86B4152E17; Mon, 29 Jan 2024 14:44:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G4XF/KvH" X-Original-To: linux-bluetooth@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 253B22E415 for ; Mon, 29 Jan 2024 14:44:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706539457; cv=none; b=Do0IQxRnRL/KbGedu85SDl7TpLQ7ZQGqUAXgDllJcHxa/d3RspkxhcZvRgEOTcNDxN67XwfnHRs3M2V4ZKj1R0NeGFw+dNlAvrbAulO+T14ZmlemSf4aXdvQKdltEdOn87yRzwcBOkcLybsfU8AcA+s6GJmlAeDkTm6KUK/aPMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706539457; c=relaxed/simple; bh=yeoFlTl9a/bqgLVxGb60Ke+4mr2ZgTSxsYBZYPeh9ZQ=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=cuhhTLWqmPwVz3uW00fpkz05Ss/ldxKUBX41X9ZYO5OHFM+yfeJXVtB+JortehP8ajN6RSljxmwh7qJic9YGS6OmcSjWf0Jtz1/YfgUPLV5MA1KnpFYLi/ErUV+2ZAoWT6jEvGejiKvw5gAStcZdRWV6oJCP2iGvEwwRVSswDj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G4XF/KvH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id BFEF5C433F1; Mon, 29 Jan 2024 14:44:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706539456; bh=yeoFlTl9a/bqgLVxGb60Ke+4mr2ZgTSxsYBZYPeh9ZQ=; h=From:Subject:Date:To:Cc:Reply-To:From; b=G4XF/KvHG7CrczCQ6KFmSgTTcyVH7xakoqoRrWV7M6nWl1sblNJJc+meErE862dbG k2mx+QC/mmndPFfCALrRXM0ovongQkf+iPaWg/R896jsqgTk+CdY1eHGVf+VRaOUiN WVtfkckSTO/S15Vb0K2ernNE1fWH/r0z3Tmu7ucuOSdXONtaUTef8H+9jpWndzHWnZ Mu0krHPDlu4Da67kmWqUWoYx7V+hlWYC2RH0tJKXaYFBAYrTmrVdnNlHZiv7B8hfWy PvdTfz0+V6N9lJ7FKkOVGa6X9BNbdFaOR1XVqH0EaOv5uob7Z53SvncMPHzUtciJDc k6VIGW8KdC9RQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8615C47DDB; Mon, 29 Jan 2024 14:44:16 +0000 (UTC) From: Emil Velikov via B4 Relay Subject: [PATCH BlueZ v4 0/8] Remove support for external plugins Date: Mon, 29 Jan 2024 14:44:14 +0000 Message-Id: <20240129-rm-ext-plugins-v4-0-bfd1e08c7f99@gmail.com> Precedence: bulk X-Mailing-List: linux-bluetooth@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAL65t2UC/3XMSw6DIBSF4a0YxqW5XAFLR91H04EoKImvgDU2x r0XHZmaDs9Jvn8hwXhnArknC/FmcsH1XRz8kpCizrvKUFfGTRCQA2OS+paaeaRD865cF6jOQd8 E5lyhJhEN3lg378HnK+7ahbH3n70/se39m5oYBSpRKbAaslSqR9XmrrkWfUu21IQHjvzEMXKBn CuQFoS1vzw9cnHiaeQl48xmtwy0lke+rusXo3zlNCoBAAA= To: linux-bluetooth@vger.kernel.org Cc: Emil Velikov X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1706539455; l=1855; i=emil.l.velikov@gmail.com; s=20230301; h=from:subject:message-id; bh=yeoFlTl9a/bqgLVxGb60Ke+4mr2ZgTSxsYBZYPeh9ZQ=; b=sPY/5c0BPa6VBrBUEtPGbDN87T622o2uippFPQTBrX4qFE2GvRhFWK1VMpoY1hJLwFoWrYR16 +d6kX37R/sSDj1U/rNHpPEcPfnH2RCiGkKExQnrOTkkV2CTa7XOUpae X-Developer-Key: i=emil.l.velikov@gmail.com; a=ed25519; pk=qeUTVTNyI3rcR2CfNNWsloTihgzmtbZo98GdxwZKCkY= X-Endpoint-Received: by B4 Relay for emil.l.velikov@gmail.com/20230301 with auth_id=35 X-Original-From: Emil Velikov Reply-To: Hello everyone, With v4 we have moved from pre-processor to compilation checking for the external plugins support. Namely, as we build without one the dead-code elimination will discard all the relevant code. Ultimately this means we compile check both paths in order to catch mistakes. Thanks to Luiz for the suggestion. Link to the previous revision can be found below. Thanks Emil - Link to v3: https://lore.kernel.org/r/20240125-rm-ext-plugins-v3-0-d141f7870bb6@gmail.com --- Emil Velikov (8): configure, README: introduce --enable-external-plugins obexd: factor out external plugin support bluetoothd: remove external-dummy plugin bluetoothd: convert external sixaxis plugin to builtin bluetoothd: factor out external plugin support bluetoothd: don't export internal API bluetoothd: change plugin loading alike obexd android: export only (android) entrypoint from the modules Makefile.am | 17 ++---- Makefile.obexd | 2 + Makefile.plugins | 8 ++- README | 13 +++++ android/Makefile.am | 3 ++ android/hal-audio.c | 1 + android/hal-bluetooth.c | 1 + android/hal-sco.c | 1 + configure.ac | 10 ++++ obexd/src/obexd.h | 2 +- obexd/src/plugin.c | 89 ++++++++++++++++++++----------- obexd/src/plugin.h | 4 ++ plugins/external-dummy.c | 28 ---------- src/btd.h | 2 +- src/plugin.c | 135 ++++++++++++++++++++++++++++------------------- src/plugin.h | 4 ++ 16 files changed, 188 insertions(+), 132 deletions(-) --- base-commit: 0de32f67f685b95c35a5c2f1206081af89bd88b6 change-id: 20240116-rm-ext-plugins-ba0b852a492b Best regards, -- Emil Velikov